| Message ID | 1476803249-23328-2-git-send-email-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Pete, On 18/10/16 16:07, Peter Griffin wrote: > proc.py:22:1: E302 expected 2 blank lines, found 1 > proc.py:200:1: E302 expected 2 blank lines, found 1 > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > scripts/gdb/linux/proc.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py > index f20fcfa..2d6f74e 100644 > --- a/scripts/gdb/linux/proc.py > +++ b/scripts/gdb/linux/proc.py > @@ -18,6 +18,7 @@ from linux import tasks > from linux import lists > from struct import * > > + This was added by patch 1, and can be squashed there. > class LxCmdLine(gdb.Command): > """ Report the Linux Commandline used in the current kernel. > Equivalent to cat /proc/cmdline on a running target""" > @@ -196,6 +197,7 @@ values of that process namespace""" > > LxMounts() > > + Likewise... > class LxFdtDump(gdb.Command): > """Output Flattened Device Tree header and dump FDT blob to a file > Equivalent to 'cat /proc/fdt > fdtdump.dtb' on a running target""" >
Hi Kieran, On Tue, 18 Oct 2016, Kieran Bingham wrote: > Hi Pete, > > On 18/10/16 16:07, Peter Griffin wrote: > > proc.py:22:1: E302 expected 2 blank lines, found 1 > > proc.py:200:1: E302 expected 2 blank lines, found 1 > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > scripts/gdb/linux/proc.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py > > index f20fcfa..2d6f74e 100644 > > --- a/scripts/gdb/linux/proc.py > > +++ b/scripts/gdb/linux/proc.py > > @@ -18,6 +18,7 @@ from linux import tasks > > from linux import lists > > from struct import * > > > > + > > This was added by patch 1, and can be squashed there. Doh, I had deliberately done it as a separate commit, as I thought it was a pre-existing pep8 error. Will squash in v2. regards, Peter.
diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py index f20fcfa..2d6f74e 100644 --- a/scripts/gdb/linux/proc.py +++ b/scripts/gdb/linux/proc.py @@ -18,6 +18,7 @@ from linux import tasks from linux import lists from struct import * + class LxCmdLine(gdb.Command): """ Report the Linux Commandline used in the current kernel. Equivalent to cat /proc/cmdline on a running target""" @@ -196,6 +197,7 @@ values of that process namespace""" LxMounts() + class LxFdtDump(gdb.Command): """Output Flattened Device Tree header and dump FDT blob to a file Equivalent to 'cat /proc/fdt > fdtdump.dtb' on a running target"""
proc.py:22:1: E302 expected 2 blank lines, found 1 proc.py:200:1: E302 expected 2 blank lines, found 1 Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- scripts/gdb/linux/proc.py | 2 ++ 1 file changed, 2 insertions(+)