| Message ID | dfe69226-fb23-0bd5-c371-ad55c1356340@dev.mellanox.co.il (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Oct 18, 2016 at 01:20:18PM -0400, Hal Rosenstock wrote: > > Signed-off-by: Hal Rosenstock <hal@mellanox.com> Thanks, applied. https://github.com/linux-rdma/rdma-core/pull/22 > --- > diff --git a/libibumad/sysfs.h b/libibumad/sysfs.h > index 7f8cbfe..489f24b 100644 > --- a/libibumad/sysfs.h > +++ b/libibumad/sysfs.h > @@ -1,3 +1,35 @@ > +/* > + * Copyright (c) 2008 Voltaire Inc. All rights reserved. > + * > + * This software is available to you under a choice of one of two > + * licenses. You may choose to be licensed under the terms of the GNU > + * General Public License (GPL) Version 2, available from the file > + * COPYING in the main directory of this source tree, or the > + * OpenIB.org BSD license below: > + * > + * Redistribution and use in source and binary forms, with or > + * without modification, are permitted provided that the following > + * conditions are met: > + * > + * - Redistributions of source code must retain the above > + * copyright notice, this list of conditions and the following > + * disclaimer. > + * > + * - Redistributions in binary form must reproduce the above > + * copyright notice, this list of conditions and the following > + * disclaimer in the documentation and/or other materials > + * provided with the distribution. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS > + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN > + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN > + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > + * SOFTWARE. > + * > + */ > #ifndef _UMAD_SYSFS_H > #define _UMAD_SYSFS_H > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
That seems like an odd copyright statement for a file that I created.. While the delcarations came from another file the whitespaces and oinclude headers take up just as little lines and have just as little substance.. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/18/2016 2:43 PM, Christoph Hellwig wrote: > That seems like an odd copyright statement for a file that I created.. > > While the delcarations came from another file the whitespaces and > oinclude headers take up just as little lines and have just as little > substance.. What's the best thing to do ? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 18, 2016 at 02:53:44PM -0400, Hal Rosenstock wrote: > On 10/18/2016 2:43 PM, Christoph Hellwig wrote: > > That seems like an odd copyright statement for a file that I created.. > > > > While the delcarations came from another file the whitespaces and > > oinclude headers take up just as little lines and have just as little > > substance.. > > What's the best thing to do ? Just not bother with copyright notices for trivial files. E.g. we don't bother with one for README.md or rdma-core.spec either. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/18/2016 3:07 PM, Christoph Hellwig wrote: > On Tue, Oct 18, 2016 at 02:53:44PM -0400, Hal Rosenstock wrote: >> On 10/18/2016 2:43 PM, Christoph Hellwig wrote: >>> That seems like an odd copyright statement for a file that I created.. >>> >>> While the delcarations came from another file the whitespaces and >>> oinclude headers take up just as little lines and have just as little >>> substance.. >> >> What's the best thing to do ? > > Just not bother with copyright notices for trivial files. E.g. we don't > bother with one for README.md or rdma-core.spec either. My understanding is that when a new file is originated from an existing file that it should maintain the copyright of the original file. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 18, 2016 at 04:07:18PM -0400, Hal Rosenstock wrote: > My understanding is that when a new file is originated from an existing > file that it should maintain the copyright of the original file. IFF there is copytightable material, yes. Either way, no need to waste time discussing this - I think it's fairly silly, but it it allows ticking a checkbox go ahead with it.. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/libibumad/sysfs.h b/libibumad/sysfs.h index 7f8cbfe..489f24b 100644 --- a/libibumad/sysfs.h +++ b/libibumad/sysfs.h @@ -1,3 +1,35 @@ +/* + * Copyright (c) 2008 Voltaire Inc. All rights reserved. + * + * This software is available to you under a choice of one of two + * licenses. You may choose to be licensed under the terms of the GNU + * General Public License (GPL) Version 2, available from the file + * COPYING in the main directory of this source tree, or the + * OpenIB.org BSD license below: + * + * Redistribution and use in source and binary forms, with or + * without modification, are permitted provided that the following + * conditions are met: + * + * - Redistributions of source code must retain the above + * copyright notice, this list of conditions and the following + * disclaimer. + * + * - Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following + * disclaimer in the documentation and/or other materials + * provided with the distribution. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE + * SOFTWARE. + * + */ #ifndef _UMAD_SYSFS_H #define _UMAD_SYSFS_H
Signed-off-by: Hal Rosenstock <hal@mellanox.com> --- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html