| Message ID | 20161005155112.13774-2-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote: > The i2c subsys does not load modules by compatible, only by > i2c-id, with e.g. a modalias of: "i2c:axp209". > > Populate the axp20x_i2c_id[] table with supported ids, so that > module auto-loading will work. > > Reported-by: Dennis Gilmore <dennis@ausil.us> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Chen-Yu Tsai <wens@csie.org> Even though axp20x-i2c seems to be the only "DT only" i2c client, would it make sense to add DT-based module autoloading to the i2c core? This also made me realize we probably don't have module auto-loading for sunxi-rsb either. Both should be doable with Stephen Boyd's "of: device: Export of_device_{get_modalias, uvent_modalias} to modules" patch. Regards ChenYu
Hi, On 18-10-16 07:25, Chen-Yu Tsai wrote: > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote: >> The i2c subsys does not load modules by compatible, only by >> i2c-id, with e.g. a modalias of: "i2c:axp209". >> >> Populate the axp20x_i2c_id[] table with supported ids, so that >> module auto-loading will work. >> >> Reported-by: Dennis Gilmore <dennis@ausil.us> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > Even though axp20x-i2c seems to be the only "DT only" i2c client, > would it make sense to add DT-based module autoloading to the i2c > core? If it is not too invasive, then yes that would be a sensible addition IMHO. Regards, Hans
Hi, On Wed, Oct 05, 2016 at 05:51:12PM +0200, Hans de Goede wrote: > The i2c subsys does not load modules by compatible, only by > i2c-id, with e.g. a modalias of: "i2c:axp209". > > Populate the axp20x_i2c_id[] table with supported ids, so that > module auto-loading will work. > > Reported-by: Dennis Gilmore <dennis@ausil.us> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/mfd/axp20x-i2c.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c > index b1b8658..d35a5fe 100644 > --- a/drivers/mfd/axp20x-i2c.c > +++ b/drivers/mfd/axp20x-i2c.c > @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match); > > -/* > - * This is useless for OF-enabled devices, but it is needed by I2C subsystem > - */ > static const struct i2c_device_id axp20x_i2c_id[] = { > + { "axp152", 0 }, > + { "axp202", 0 }, > + { "axp209", 0 }, > + { "axp221", 0 }, > { }, > }; > MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id); Thanks, queued. -- Sebastian
Hi, On Wed, Oct 19, 2016 at 04:51:55AM +0200, Sebastian Reichel wrote: > > diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c > > index b1b8658..d35a5fe 100644 > > --- a/drivers/mfd/axp20x-i2c.c > > +++ b/drivers/mfd/axp20x-i2c.c > > @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = { > > }; > > MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match); > > > > -/* > > - * This is useless for OF-enabled devices, but it is needed by I2C subsystem > > - */ > > static const struct i2c_device_id axp20x_i2c_id[] = { > > + { "axp152", 0 }, > > + { "axp202", 0 }, > > + { "axp209", 0 }, > > + { "axp221", 0 }, > > { }, > > }; > > MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id); > > Thanks, queued. My mistake. It should obviously go through mfd. So take this instead: Acked-By: Sebastian Reichel <sre@kernel.org> -- Sebastian
On Tue, 18 Oct 2016, Hans de Goede wrote: > On 18-10-16 07:25, Chen-Yu Tsai wrote: > > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote: > > > The i2c subsys does not load modules by compatible, only by > > > i2c-id, with e.g. a modalias of: "i2c:axp209". > > > > > > Populate the axp20x_i2c_id[] table with supported ids, so that > > > module auto-loading will work. > > > > > > Reported-by: Dennis Gilmore <dennis@ausil.us> > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > > > Acked-by: Chen-Yu Tsai <wens@csie.org> > > > > Even though axp20x-i2c seems to be the only "DT only" i2c client, > > would it make sense to add DT-based module autoloading to the i2c > > core? > > If it is not too invasive, then yes that would be a sensible addition IMHO. If I understand you correctly, I already have a patch-set on the ML that does this.
> > > Even though axp20x-i2c seems to be the only "DT only" i2c client, > > > would it make sense to add DT-based module autoloading to the i2c > > > core? > > > > If it is not too invasive, then yes that would be a sensible addition IMHO. > > If I understand you correctly, I already have a patch-set on the ML > that does this. Incomplete, though. But we will see if Kieran finds time somewhen...
On Mon, 24 Oct 2016, Wolfram Sang wrote: > > > > > Even though axp20x-i2c seems to be the only "DT only" i2c client, > > > > would it make sense to add DT-based module autoloading to the i2c > > > > core? > > > > > > If it is not too invasive, then yes that would be a sensible addition IMHO. > > > > If I understand you correctly, I already have a patch-set on the ML > > that does this. > > Incomplete, though. But we will see if Kieran finds time somewhen... I was under the impression it was all but ready. What are you waiting on?
> I was under the impression it was all but ready. Then, I would have applied it. > What are you waiting on? Lee, I don't want to explain it *again*. Please re-read Kieran's last attempt.
On Mon, 24 Oct 2016, Wolfram Sang wrote: > > > I was under the impression it was all but ready. > > Then, I would have applied it. > > > What are you waiting on? > > Lee, I don't want to explain it *again*. Please re-read Kieran's last > attempt. I met with Kieran. He's submitted a new version. Here's hoping! ;)
On Wed, 05 Oct 2016, Hans de Goede wrote: > The i2c subsys does not load modules by compatible, only by > i2c-id, with e.g. a modalias of: "i2c:axp209". > > Populate the axp20x_i2c_id[] table with supported ids, so that > module auto-loading will work. > > Reported-by: Dennis Gilmore <dennis@ausil.us> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/mfd/axp20x-i2c.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied (for now), thanks. > diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c > index b1b8658..d35a5fe 100644 > --- a/drivers/mfd/axp20x-i2c.c > +++ b/drivers/mfd/axp20x-i2c.c > @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match); > > -/* > - * This is useless for OF-enabled devices, but it is needed by I2C subsystem > - */ > static const struct i2c_device_id axp20x_i2c_id[] = { > + { "axp152", 0 }, > + { "axp202", 0 }, > + { "axp209", 0 }, > + { "axp221", 0 }, > { }, > }; > MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c index b1b8658..d35a5fe 100644 --- a/drivers/mfd/axp20x-i2c.c +++ b/drivers/mfd/axp20x-i2c.c @@ -69,10 +69,11 @@ static const struct of_device_id axp20x_i2c_of_match[] = { }; MODULE_DEVICE_TABLE(of, axp20x_i2c_of_match); -/* - * This is useless for OF-enabled devices, but it is needed by I2C subsystem - */ static const struct i2c_device_id axp20x_i2c_id[] = { + { "axp152", 0 }, + { "axp202", 0 }, + { "axp209", 0 }, + { "axp221", 0 }, { }, }; MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
The i2c subsys does not load modules by compatible, only by i2c-id, with e.g. a modalias of: "i2c:axp209". Populate the axp20x_i2c_id[] table with supported ids, so that module auto-loading will work. Reported-by: Dennis Gilmore <dennis@ausil.us> Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/mfd/axp20x-i2c.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)