| Message ID | 20161014073328.GC15168@mwanda (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 10/14/2016 4:33 PM, Dan Carpenter wrote: > We checked that "pdata->chg_params" is non-NULL earlier in this function > so when we add "i" to it, it's still non-NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Milo Kim <milo.kim@ti.com> Thanks for catching this. Best regards, Milo -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Dan, On Fri, Oct 14, 2016 at 10:33:28AM +0300, Dan Carpenter wrote: > We checked that "pdata->chg_params" is non-NULL earlier in this function > so when we add "i" to it, it's still non-NULL. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c > index 7321b72..509e2b3 100644 > --- a/drivers/power/supply/lp8788-charger.c > +++ b/drivers/power/supply/lp8788-charger.c > @@ -384,9 +384,6 @@ static int lp8788_update_charger_params(struct platform_device *pdev, > for (i = 0; i < pdata->num_chg_params; i++) { > param = pdata->chg_params + i; > > - if (!param) > - continue; > - > if (lp8788_is_valid_charger_register(param->addr)) { > ret = lp8788_write_byte(lp, param->addr, param->val); > if (ret) Thanks, queued. -- Sebastian
diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c index 7321b72..509e2b3 100644 --- a/drivers/power/supply/lp8788-charger.c +++ b/drivers/power/supply/lp8788-charger.c @@ -384,9 +384,6 @@ static int lp8788_update_charger_params(struct platform_device *pdev, for (i = 0; i < pdata->num_chg_params; i++) { param = pdata->chg_params + i; - if (!param) - continue; - if (lp8788_is_valid_charger_register(param->addr)) { ret = lp8788_write_byte(lp, param->addr, param->val); if (ret)
We checked that "pdata->chg_params" is non-NULL earlier in this function so when we add "i" to it, it's still non-NULL. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html