diff mbox

[2/3] Staging: media: radio-bcm2048: Fix alignment issues

Message ID 20161019171713.19181-2-jb@abbadie.fr (mailing list archive)
State New, archived
Headers show

Commit Message

Jean-Baptiste Abbadie Oct. 19, 2016, 5:17 p.m. UTC
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Greg KH Oct. 19, 2016, 5:51 p.m. UTC | #1
On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote:
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>

I can't take a patch with no changelog text, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jean-Baptiste Abbadie Oct. 19, 2016, 6:10 p.m. UTC | #2
On 19/10/16 19:51, Greg Kroah-Hartman wrote:
> I can't take a patch with no changelog text, sorry. 
Hello,

Should I add the changelog in the same thread or start a new thread ?

Sorry, for the mistakes that's my first submitted patch.

Regards,

Jean-Baptiste

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg KH Oct. 19, 2016, 6:21 p.m. UTC | #3
On Wed, Oct 19, 2016 at 08:10:25PM +0200, Jean-Baptiste Abbadie wrote:
> On 19/10/16 19:51, Greg Kroah-Hartman wrote:
> > I can't take a patch with no changelog text, sorry.
> Hello,
> 
> Should I add the changelog in the same thread or start a new thread ?

Whole new patch please.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Johannes Stezenbach Oct. 19, 2016, 7:34 p.m. UTC | #4
On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote:
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
> ---
>  drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 188d045d44ad..f66bea631e8e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -997,7 +997,7 @@ static int bcm2048_set_fm_search_tune_mode(struct bcm2048_device *bdev,
>  		timeout = BCM2048_AUTO_SEARCH_TIMEOUT;
>  
>  	if (!wait_for_completion_timeout(&bdev->compl,
> -		msecs_to_jiffies(timeout)))
> +					 msecs_to_jiffies(timeout)))
>  		dev_err(&bdev->client->dev, "IRQ timeout.\n");
>  
>  	if (value)
> @@ -2202,7 +2202,7 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
>  		}
>  		/* interruptible_sleep_on(&bdev->read_queue); */
>  		if (wait_event_interruptible(bdev->read_queue,
> -		    bdev->rds_data_available) < 0) {
> +					     bdev->rds_data_available) < 0) {

FWIW, a better Subject: would be "fix indentation" because
"alignment issue" usually means some address not
aligned to some border.

HTH,
Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 188d045d44ad..f66bea631e8e 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -997,7 +997,7 @@  static int bcm2048_set_fm_search_tune_mode(struct bcm2048_device *bdev,
 		timeout = BCM2048_AUTO_SEARCH_TIMEOUT;
 
 	if (!wait_for_completion_timeout(&bdev->compl,
-		msecs_to_jiffies(timeout)))
+					 msecs_to_jiffies(timeout)))
 		dev_err(&bdev->client->dev, "IRQ timeout.\n");
 
 	if (value)
@@ -2202,7 +2202,7 @@  static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
 		}
 		/* interruptible_sleep_on(&bdev->read_queue); */
 		if (wait_event_interruptible(bdev->read_queue,
-		    bdev->rds_data_available) < 0) {
+					     bdev->rds_data_available) < 0) {
 			retval = -EINTR;
 			goto done;
 		}