Message ID | 84c06fb2-d147-689d-8d42-ce6b1f400a1f@sakamocchi.jp (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Oct 19 Takashi Sakamoto wrote: > --- a/drivers/media/firewire/firedtv-rc.c > +++ b/drivers/media/firewire/firedtv-rc.c > @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned > int code) > else if (code >= 0x4540 && code <= 0x4542) > code = oldtable[code - 0x4521]; > else { > - printk(KERN_DEBUG "firedtv: invalid key code 0x%04x " > - "from remote control\n", code); > + dev_dbg(fdtv->device, > + "invalid key code 0x%04x from remote control\n", > + code); > return; > } > Yes, dev_XYZ(fdtv->device, ...) is better here and is already used this way throughout the firedtv driver. firedtv-rc.c somehow fell through the cracks when firedtv was made to use dev_XYZ(). (On an unrelated note, this reminds me that I still need to take care of Mauro's patches "Add a keymap for FireDTV board" and "firedtv: Port it to use rc_core" from May 28, 2012.)
Em Wed, 19 Oct 2016 08:03:01 +0900 Takashi Sakamoto <o-takashi@sakamocchi.jp> escreveu: > From: Takashi Sakamoto <o-takashi@sakamocchi.jp> > Date: Wed, 19 Oct 2016 07:53:35 +0900 > Subject: [PATCH] [media] firewire: use dev_dbg() instead of printk() > > A structure for firedtv (struct firedtv) has a member for a pointer to > struct device. In this case, we can use dev_dbg() for debug printing. > This is more preferrable behaviour in device driver development. > > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > --- > drivers/media/firewire/firedtv-rc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/firewire/firedtv-rc.c > b/drivers/media/firewire/firedtv-rc.c > index f82d4a9..04dea2a 100644 > --- a/drivers/media/firewire/firedtv-rc.c > +++ b/drivers/media/firewire/firedtv-rc.c > @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code) > else if (code >= 0x4540 && code <= 0x4542) > code = oldtable[code - 0x4521]; > else { > - printk(KERN_DEBUG "firedtv: invalid key code 0x%04x " > - "from remote control\n", code); > + dev_dbg(fdtv->device, > + "invalid key code 0x%04x from remote control\n", > + code); > return; > } Looks good to me. Applied to my development tree: https://git.linuxtv.org/mchehab/experimental.git/commit/?h=printk&id=e0de6d90145753bf40415d670471fcc536b2a26c https://git.linuxtv.org/mchehab/experimental.git/commit/?h=printk&id=9532ba4af6a7619bb028ddd3b829e6f163917b79 Stefan, Would the above be OK for you? Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Wed, 19 Oct 2016 09:56:25 +0200 Stefan Richter <stefanr@s5r6.in-berlin.de> escreveu: > On Oct 19 Takashi Sakamoto wrote: > > --- a/drivers/media/firewire/firedtv-rc.c > > +++ b/drivers/media/firewire/firedtv-rc.c > > @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned > > int code) > > else if (code >= 0x4540 && code <= 0x4542) > > code = oldtable[code - 0x4521]; > > else { > > - printk(KERN_DEBUG "firedtv: invalid key code 0x%04x " > > - "from remote control\n", code); > > + dev_dbg(fdtv->device, > > + "invalid key code 0x%04x from remote control\n", > > + code); > > return; > > } > > > > Yes, dev_XYZ(fdtv->device, ...) is better here and is already used this > way throughout the firedtv driver. firedtv-rc.c somehow fell through the > cracks when firedtv was made to use dev_XYZ(). > > (On an unrelated note, this reminds me that I still need to take care of > Mauro's patches "Add a keymap for FireDTV board" and "firedtv: Port it to > use rc_core" from May 28, 2012.) Oh! I forgot about those a long time ago ;) Yeah, it would be great if you could look into those patches when you have some time. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Oct 19 Mauro Carvalho Chehab wrote: > Em Wed, 19 Oct 2016 08:03:01 +0900 > Takashi Sakamoto <o-takashi@sakamocchi.jp> escreveu: > > A structure for firedtv (struct firedtv) has a member for a pointer to > > struct device. In this case, we can use dev_dbg() for debug printing. [...] > Stefan, > > Would the above be OK for you? ACK.
diff --git a/drivers/media/firewire/firedtv-rc.c b/drivers/media/firewire/firedtv-rc.c index f82d4a9..04dea2a 100644 --- a/drivers/media/firewire/firedtv-rc.c +++ b/drivers/media/firewire/firedtv-rc.c @@ -184,8 +184,9 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code) else if (code >= 0x4540 && code <= 0x4542) code = oldtable[code - 0x4521]; else { - printk(KERN_DEBUG "firedtv: invalid key code 0x%04x " - "from remote control\n", code); + dev_dbg(fdtv->device, + "invalid key code 0x%04x from remote control\n", + code); return; }