| Message ID | 21c48d771ab8a9d37ec19ea5f7a48ed5b84c8984.1477336045.git.swise@opengridcomputing.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 10/24/2016 12:07 PM, Steve Wise wrote: > Signed-off-by: Steve Wise <swise@opengridcomputing.com> > --- > net/rds/rdma_transport.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/rds/rdma_transport.c b/net/rds/rdma_transport.c > index 345f090..6bd2814 100644 > --- a/net/rds/rdma_transport.c > +++ b/net/rds/rdma_transport.c > @@ -100,11 +100,14 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id, > trans->cm_connect_complete(conn, event); > break; > > + case RDMA_CM_EVENT_REJECTED: > + rdsdebug("Connection rejected: %s\n", > + rdma_reject_msg(cm_id, event->status)); For current code above is fine but I will need the other helper while adding few connection cases where ARI field carries information for the reason for the reject. I assume, rdma_consumer_reject_data() is meant to be used for that ? The patch looks fine to me. FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Santosh Shilimkar [mailto:santosh.shilimkar@oracle.com] > Sent: Tuesday, October 25, 2016 10:52 AM > To: Steve Wise; dledford@redhat.com; sean.hefty@intel.com > Cc: linux-rdma@vger.kernel.org; bart.vanassche@sandisk.com; linux- > nvme@lists.infradead.org; sagi@grimberg.me; hch@lst.de; axboe@fb.com > Subject: Re: [PATCH v3 6/6] rds_rdma: log the connection reject message > > On 10/24/2016 12:07 PM, Steve Wise wrote: > > Signed-off-by: Steve Wise <swise@opengridcomputing.com> > > --- > > net/rds/rdma_transport.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/net/rds/rdma_transport.c b/net/rds/rdma_transport.c > > index 345f090..6bd2814 100644 > > --- a/net/rds/rdma_transport.c > > +++ b/net/rds/rdma_transport.c > > @@ -100,11 +100,14 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id > *cm_id, > > trans->cm_connect_complete(conn, event); > > break; > > > > + case RDMA_CM_EVENT_REJECTED: > > + rdsdebug("Connection rejected: %s\n", > > + rdma_reject_msg(cm_id, event->status)); > For current code above is fine but I will need the other helper > while adding few connection cases where ARI field carries information > for the reason for the reject. > > I assume, rdma_consumer_reject_data() is meant to be used for that ? Yep. You can see the nvme_rdma patch in this series for an example. > > The patch looks fine to me. > FWIW, Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/25/2016 9:04 AM, Steve Wise wrote: > > >> -----Original Message----- >> From: Santosh Shilimkar [mailto:santosh.shilimkar@oracle.com] >> Sent: Tuesday, October 25, 2016 10:52 AM >> To: Steve Wise; dledford@redhat.com; sean.hefty@intel.com >> Cc: linux-rdma@vger.kernel.org; bart.vanassche@sandisk.com; linux- >> nvme@lists.infradead.org; sagi@grimberg.me; hch@lst.de; axboe@fb.com >> Subject: Re: [PATCH v3 6/6] rds_rdma: log the connection reject message >> >> On 10/24/2016 12:07 PM, Steve Wise wrote: >>> Signed-off-by: Steve Wise <swise@opengridcomputing.com> >>> --- >>> net/rds/rdma_transport.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/net/rds/rdma_transport.c b/net/rds/rdma_transport.c >>> index 345f090..6bd2814 100644 >>> --- a/net/rds/rdma_transport.c >>> +++ b/net/rds/rdma_transport.c >>> @@ -100,11 +100,14 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id >> *cm_id, >>> trans->cm_connect_complete(conn, event); >>> break; >>> >>> + case RDMA_CM_EVENT_REJECTED: >>> + rdsdebug("Connection rejected: %s\n", >>> + rdma_reject_msg(cm_id, event->status)); >> For current code above is fine but I will need the other helper >> while adding few connection cases where ARI field carries information >> for the reason for the reject. >> >> I assume, rdma_consumer_reject_data() is meant to be used for that ? > > Yep. You can see the nvme_rdma patch in this series for an example. > Cool. Thanks for info Steve. regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/rdma_transport.c b/net/rds/rdma_transport.c index 345f090..6bd2814 100644 --- a/net/rds/rdma_transport.c +++ b/net/rds/rdma_transport.c @@ -100,11 +100,14 @@ int rds_rdma_cm_event_handler(struct rdma_cm_id *cm_id, trans->cm_connect_complete(conn, event); break; + case RDMA_CM_EVENT_REJECTED: + rdsdebug("Connection rejected: %s\n", + rdma_reject_msg(cm_id, event->status)); + /*FALLTHROUGH*/ case RDMA_CM_EVENT_ADDR_ERROR: case RDMA_CM_EVENT_ROUTE_ERROR: case RDMA_CM_EVENT_CONNECT_ERROR: case RDMA_CM_EVENT_UNREACHABLE: - case RDMA_CM_EVENT_REJECTED: case RDMA_CM_EVENT_DEVICE_REMOVAL: case RDMA_CM_EVENT_ADDR_CHANGE: if (conn)
Signed-off-by: Steve Wise <swise@opengridcomputing.com> --- net/rds/rdma_transport.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)