| Message ID | 1473479250-2225-1-git-send-email-axel.lin@ingics.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On 09/10, Axel Lin wrote: > Drop the assignment of regmap_read return code to val, so the code checks > the value read. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> Looks obviously correct. I'll have to dig up the hardware to test it though so I'm considering just applying it directly and assuming there won't be any fallout.
On 09/10, Axel Lin wrote: > Drop the assignment of regmap_read return code to val, so the code checks > the value read. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- I never got around to testing it, but it looks correct enough. Applied to clk-next
diff --git a/drivers/clk/qcom/lcc-ipq806x.c b/drivers/clk/qcom/lcc-ipq806x.c index db3998e..977e98e 100644 --- a/drivers/clk/qcom/lcc-ipq806x.c +++ b/drivers/clk/qcom/lcc-ipq806x.c @@ -443,7 +443,7 @@ static int lcc_ipq806x_probe(struct platform_device *pdev) return PTR_ERR(regmap); /* Configure the rate of PLL4 if the bootloader hasn't already */ - val = regmap_read(regmap, 0x0, &val); + regmap_read(regmap, 0x0, &val); if (!val) clk_pll_configure_sr(&pll4, regmap, &pll4_config, true); /* Enable PLL4 source on the LPASS Primary PLL Mux */
Drop the assignment of regmap_read return code to val, so the code checks the value read. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/clk/qcom/lcc-ipq806x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)