diff mbox

[2/2] ARM: dts: add new compatible stream for i.MX6QP mmdc

Message ID 1477430817-20381-2-git-send-email-Frank.Li@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Frank Li Oct. 25, 2016, 9:26 p.m. UTC
mmdc of i.MX6QP are little difference with i.MX6Q.
added new compatible stream fsl,imx6qp-mmdc

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/imx6qp.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Shawn Guo Nov. 2, 2016, 2:42 p.m. UTC | #1
On Tue, Oct 25, 2016 at 04:26:57PM -0500, Frank Li wrote:
> mmdc of i.MX6QP are little difference with i.MX6Q.
> added new compatible stream fsl,imx6qp-mmdc
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm/boot/dts/imx6qp.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qp.dtsi b/arch/arm/boot/dts/imx6qp.dtsi
> index 886dbf2..e0fdd0f 100644
> --- a/arch/arm/boot/dts/imx6qp.dtsi
> +++ b/arch/arm/boot/dts/imx6qp.dtsi
> @@ -85,5 +85,12 @@
>  		pcie: pcie@0x01000000 {
>  			compatible = "fsl,imx6qp-pcie", "snps,dw-pcie";
>  		};
> +
> +		aips-bus@02100000 {
> +			mmdc0: mmdc@021b0000 { /* MMDC0 */
> +				compatible = "fsl,imx6qp-mmdc", "fsl,imx6q-mmdc";

Sine we already know that imx6qp-mmdc has a different programming model
from imx6q-mmdc, it makes less sense to have "fsl,imx6q-mmdc" here.

Shawn

> +				reg = <0x021b0000 0x4000>;
> +			};
> +		};
>  	};
>  };
> -- 
> 2.5.2
>
Zhi Li Nov. 2, 2016, 3:16 p.m. UTC | #2
On Wed, Nov 2, 2016 at 9:42 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Tue, Oct 25, 2016 at 04:26:57PM -0500, Frank Li wrote:
>> mmdc of i.MX6QP are little difference with i.MX6Q.
>> added new compatible stream fsl,imx6qp-mmdc
>>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>>  arch/arm/boot/dts/imx6qp.dtsi | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qp.dtsi b/arch/arm/boot/dts/imx6qp.dtsi
>> index 886dbf2..e0fdd0f 100644
>> --- a/arch/arm/boot/dts/imx6qp.dtsi
>> +++ b/arch/arm/boot/dts/imx6qp.dtsi
>> @@ -85,5 +85,12 @@
>>               pcie: pcie@0x01000000 {
>>                       compatible = "fsl,imx6qp-pcie", "snps,dw-pcie";
>>               };
>> +
>> +             aips-bus@02100000 {
>> +                     mmdc0: mmdc@021b0000 { /* MMDC0 */
>> +                             compatible = "fsl,imx6qp-mmdc", "fsl,imx6q-mmdc";
>
> Sine we already know that imx6qp-mmdc has a different programming model
> from imx6q-mmdc, it makes less sense to have "fsl,imx6q-mmdc" here.

PM code (Suspend and resume) use  "fsl,imx6q-mmdc" to get mmdc's base
address to do some works.

best regards
Frank Li

>
> Shawn
>
>> +                             reg = <0x021b0000 0x4000>;
>> +                     };
>> +             };
>>       };
>>  };
>> --
>> 2.5.2
>>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx6qp.dtsi b/arch/arm/boot/dts/imx6qp.dtsi
index 886dbf2..e0fdd0f 100644
--- a/arch/arm/boot/dts/imx6qp.dtsi
+++ b/arch/arm/boot/dts/imx6qp.dtsi
@@ -85,5 +85,12 @@ 
 		pcie: pcie@0x01000000 {
 			compatible = "fsl,imx6qp-pcie", "snps,dw-pcie";
 		};
+
+		aips-bus@02100000 {
+			mmdc0: mmdc@021b0000 { /* MMDC0 */
+				compatible = "fsl,imx6qp-mmdc", "fsl,imx6q-mmdc";
+				reg = <0x021b0000 0x4000>;
+			};
+		};
 	};
 };