diff mbox

xattr: Fix setting security xattrs on sockfs

Message ID 1478188859-12354-1-git-send-email-agruenba@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Gruenbacher Nov. 3, 2016, 4 p.m. UTC
On Thu, Nov 3, 2016 at 4:51 PM, Casey Schaufler <casey@schaufler-ca.com> wrote:
> On 11/3/2016 6:45 AM, Andreas Gruenbacher wrote:
>> Casey, the first patch broke filesystems that support setxattr for some xattrs
>> but not security xattrs.  Here's an updated patch; could you please test?
>
> This patch does not fix the problem. I am back to EOPTNOTSUP.

Ah, I forgot to register the new sockfs xattr handler.  Does this help?

Thanks,
Andreas

---
 net/socket.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Casey Schaufler Nov. 3, 2016, 4:25 p.m. UTC | #1
On 11/3/2016 9:00 AM, Andreas Gruenbacher wrote:
> On Thu, Nov 3, 2016 at 4:51 PM, Casey Schaufler <casey@schaufler-ca.com> wrote:
>> On 11/3/2016 6:45 AM, Andreas Gruenbacher wrote:
>>> Casey, the first patch broke filesystems that support setxattr for some xattrs
>>> but not security xattrs.  Here's an updated patch; could you please test?
>> This patch does not fix the problem. I am back to EOPTNOTSUP.
> Ah, I forgot to register the new sockfs xattr handler.  Does this help?

Yes. With this addition it looks good.

>
> Thanks,
> Andreas
>
> ---
>  net/socket.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/socket.c b/net/socket.c
> index 816392a..9820725 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -357,6 +357,7 @@ static const struct xattr_handler sockfs_security_xattr_handler = {
>  
>  static const struct xattr_handler *sockfs_xattr_handlers[] = {
>  	&sockfs_xattr_handler,
> +	&sockfs_security_xattr_handler,
>  	NULL
>  };
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/socket.c b/net/socket.c
index 816392a..9820725 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -357,6 +357,7 @@  static const struct xattr_handler sockfs_security_xattr_handler = {
 
 static const struct xattr_handler *sockfs_xattr_handlers[] = {
 	&sockfs_xattr_handler,
+	&sockfs_security_xattr_handler,
 	NULL
 };