| Message ID | 1478276094-19135-3-git-send-email-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Friday 04 November 2016, Sylwester Nawrocki wrote: > + } else { > + pl08x->slave.filter.map = pl08x->pd->slave_map; > + pl08x->slave.filter.mapcnt = pl08x->pd->slave_map_len; > } I think you miss the setup of the filter function here. Filtering by string in this driver is a bit awkward, so I wonder if we might want to go one step further here and pass the actual data (i.e. struct pl08x_channel_data) rather than the string here. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 939a7c3..d5c75c8 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -2307,6 +2307,9 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) ret = -EINVAL; goto out_no_platdata; } + } else { + pl08x->slave.filter.map = pl08x->pd->slave_map; + pl08x->slave.filter.mapcnt = pl08x->pd->slave_map_len; } /* By default, AHB1 only. If dualmaster, from platform */ diff --git a/include/linux/amba/pl08x.h b/include/linux/amba/pl08x.h index 27e9ec8..5308eae 100644 --- a/include/linux/amba/pl08x.h +++ b/include/linux/amba/pl08x.h @@ -84,6 +84,8 @@ struct pl08x_channel_data { * running any DMA transfer and multiplexing can be recycled * @lli_buses: buses which LLIs can be fetched from: PL08X_AHB1 | PL08X_AHB2 * @mem_buses: buses which memory can be accessed from: PL08X_AHB1 | PL08X_AHB2 + * @slave_map: DMA slave matching table + * @slave_map_len: number of elements in @slave_map */ struct pl08x_platform_data { struct pl08x_channel_data *slave_channels; @@ -93,6 +95,8 @@ struct pl08x_platform_data { void (*put_xfer_signal)(const struct pl08x_channel_data *, int); u8 lli_buses; u8 mem_buses; + const struct dma_slave_map *slave_map; + int slave_map_len; }; #ifdef CONFIG_AMBA_PL08X
This patch add support for the new channel request API introduced in commit a8135d0d79e9d0ad3a4ff494fceeaae83 "dmaengine: core: Introduce new, universal API to request a channel" Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- drivers/dma/amba-pl08x.c | 3 +++ include/linux/amba/pl08x.h | 4 ++++ 2 files changed, 7 insertions(+)