| Message ID | 1478694996-4200-1-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 9, 2016 at 4:36 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > Not setting the fb modifiers flag is something different from setting > the fb modifiers to 0 (which means explicitly linear). We kinda failed > to document that properly. Spotted by Kristian. > > Cc: hoegsberg@google.com > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Thanks, looks good. Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com> > --- > include/uapi/drm/drm_fourcc.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index da49f69e4d7e..2fca7e1f6aab 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -172,6 +172,16 @@ extern "C" { > * authoritative source for all of these. > */ > > +/* > + * Linear Layout > + * > + * Just plain linear layout. Note that this is different from no > specifying any > + * modifier (e.g. not setting DRM_MODE_FB_MODIFIERS in the DRM_ADDFB2 > ioctl), > + * which tells the driver to also take driver-internal information into > account > + * and so might actually result in a tiled framebuffer. > + */ > +#define DRM_FORMAT_MOD_LINEAR fourcc_mod_code(NONE, 0) > + > /* Intel framebuffer modifiers */ > > /* > -- > 2.7.4 > >
Did we forget about this one? I guess I could commit it myself, but I'm not sure which branch to push it too... Kristian On Wed, Nov 9, 2016 at 4:10 PM Kristian Kristensen <hoegsberg@google.com> wrote: > On Wed, Nov 9, 2016 at 4:36 AM, Daniel Vetter <daniel.vetter@ffwll.ch> > wrote: > > Not setting the fb modifiers flag is something different from setting > the fb modifiers to 0 (which means explicitly linear). We kinda failed > to document that properly. Spotted by Kristian. > > Cc: hoegsberg@google.com > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > Thanks, looks good. > > Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com> > > > --- > include/uapi/drm/drm_fourcc.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index da49f69e4d7e..2fca7e1f6aab 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -172,6 +172,16 @@ extern "C" { > * authoritative source for all of these. > */ > > +/* > + * Linear Layout > + * > + * Just plain linear layout. Note that this is different from no > specifying any > + * modifier (e.g. not setting DRM_MODE_FB_MODIFIERS in the DRM_ADDFB2 > ioctl), > + * which tells the driver to also take driver-internal information into > account > + * and so might actually result in a tiled framebuffer. > + */ > +#define DRM_FORMAT_MOD_LINEAR fourcc_mod_code(NONE, 0) > + > /* Intel framebuffer modifiers */ > > /* > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >
On Tue, Dec 13, 2016 at 05:32:29AM +0000, Kristian Høgsberg wrote: > Did we forget about this one? I guess I could commit it myself, but I'm not > sure which branch to push it too... Indeed this got lost, applied to drm-misc now. -Daniel > > Kristian > > On Wed, Nov 9, 2016 at 4:10 PM Kristian Kristensen <hoegsberg@google.com> > wrote: > > > On Wed, Nov 9, 2016 at 4:36 AM, Daniel Vetter <daniel.vetter@ffwll.ch> > > wrote: > > > > Not setting the fb modifiers flag is something different from setting > > the fb modifiers to 0 (which means explicitly linear). We kinda failed > > to document that properly. Spotted by Kristian. > > > > Cc: hoegsberg@google.com > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > > > Thanks, looks good. > > > > Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com> > > > > > > --- > > include/uapi/drm/drm_fourcc.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > > index da49f69e4d7e..2fca7e1f6aab 100644 > > --- a/include/uapi/drm/drm_fourcc.h > > +++ b/include/uapi/drm/drm_fourcc.h > > @@ -172,6 +172,16 @@ extern "C" { > > * authoritative source for all of these. > > */ > > > > +/* > > + * Linear Layout > > + * > > + * Just plain linear layout. Note that this is different from no > > specifying any > > + * modifier (e.g. not setting DRM_MODE_FB_MODIFIERS in the DRM_ADDFB2 > > ioctl), > > + * which tells the driver to also take driver-internal information into > > account > > + * and so might actually result in a tiled framebuffer. > > + */ > > +#define DRM_FORMAT_MOD_LINEAR fourcc_mod_code(NONE, 0) > > + > > /* Intel framebuffer modifiers */ > > > > /* > > -- > > 2.7.4 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > >
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index da49f69e4d7e..2fca7e1f6aab 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -172,6 +172,16 @@ extern "C" { * authoritative source for all of these. */ +/* + * Linear Layout + * + * Just plain linear layout. Note that this is different from no specifying any + * modifier (e.g. not setting DRM_MODE_FB_MODIFIERS in the DRM_ADDFB2 ioctl), + * which tells the driver to also take driver-internal information into account + * and so might actually result in a tiled framebuffer. + */ +#define DRM_FORMAT_MOD_LINEAR fourcc_mod_code(NONE, 0) + /* Intel framebuffer modifiers */ /*
Not setting the fb modifiers flag is something different from setting the fb modifiers to 0 (which means explicitly linear). We kinda failed to document that properly. Spotted by Kristian. Cc: hoegsberg@google.com Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> --- include/uapi/drm/drm_fourcc.h | 10 ++++++++++ 1 file changed, 10 insertions(+)