| Message ID | 1479136968-24477-3-git-send-email-hverkuil@xs4all.nl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
I can't comment on these, you've not included me in patch 1 nor the covering message. On Mon, Nov 14, 2016 at 04:22:45PM +0100, Hans Verkuil wrote: > From: Russell King <rmk+kernel@arm.linux.org.uk> > > We don't need the CEC engine register definitions, so let's remove them. > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > --- > drivers/gpu/drm/bridge/dw-hdmi.h | 45 ---------------------------------------- > 1 file changed, 45 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/dw-hdmi.h > index fc9a560..26d6845 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.h > +++ b/drivers/gpu/drm/bridge/dw-hdmi.h > @@ -478,51 +478,6 @@ > #define HDMI_A_PRESETUP 0x501A > #define HDMI_A_SRM_BASE 0x5020 > > -/* CEC Engine Registers */ > -#define HDMI_CEC_CTRL 0x7D00 > -#define HDMI_CEC_STAT 0x7D01 > -#define HDMI_CEC_MASK 0x7D02 > -#define HDMI_CEC_POLARITY 0x7D03 > -#define HDMI_CEC_INT 0x7D04 > -#define HDMI_CEC_ADDR_L 0x7D05 > -#define HDMI_CEC_ADDR_H 0x7D06 > -#define HDMI_CEC_TX_CNT 0x7D07 > -#define HDMI_CEC_RX_CNT 0x7D08 > -#define HDMI_CEC_TX_DATA0 0x7D10 > -#define HDMI_CEC_TX_DATA1 0x7D11 > -#define HDMI_CEC_TX_DATA2 0x7D12 > -#define HDMI_CEC_TX_DATA3 0x7D13 > -#define HDMI_CEC_TX_DATA4 0x7D14 > -#define HDMI_CEC_TX_DATA5 0x7D15 > -#define HDMI_CEC_TX_DATA6 0x7D16 > -#define HDMI_CEC_TX_DATA7 0x7D17 > -#define HDMI_CEC_TX_DATA8 0x7D18 > -#define HDMI_CEC_TX_DATA9 0x7D19 > -#define HDMI_CEC_TX_DATA10 0x7D1a > -#define HDMI_CEC_TX_DATA11 0x7D1b > -#define HDMI_CEC_TX_DATA12 0x7D1c > -#define HDMI_CEC_TX_DATA13 0x7D1d > -#define HDMI_CEC_TX_DATA14 0x7D1e > -#define HDMI_CEC_TX_DATA15 0x7D1f > -#define HDMI_CEC_RX_DATA0 0x7D20 > -#define HDMI_CEC_RX_DATA1 0x7D21 > -#define HDMI_CEC_RX_DATA2 0x7D22 > -#define HDMI_CEC_RX_DATA3 0x7D23 > -#define HDMI_CEC_RX_DATA4 0x7D24 > -#define HDMI_CEC_RX_DATA5 0x7D25 > -#define HDMI_CEC_RX_DATA6 0x7D26 > -#define HDMI_CEC_RX_DATA7 0x7D27 > -#define HDMI_CEC_RX_DATA8 0x7D28 > -#define HDMI_CEC_RX_DATA9 0x7D29 > -#define HDMI_CEC_RX_DATA10 0x7D2a > -#define HDMI_CEC_RX_DATA11 0x7D2b > -#define HDMI_CEC_RX_DATA12 0x7D2c > -#define HDMI_CEC_RX_DATA13 0x7D2d > -#define HDMI_CEC_RX_DATA14 0x7D2e > -#define HDMI_CEC_RX_DATA15 0x7D2f > -#define HDMI_CEC_LOCK 0x7D30 > -#define HDMI_CEC_WKUPCTRL 0x7D31 > - > /* I2C Master Registers (E-DDC) */ > #define HDMI_I2CM_SLAVE 0x7E00 > #define HDMI_I2CM_ADDRESS 0x7E01 > -- > 2.8.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
You're CC-ed for all, so if you don't receive it in the next 15 minutes let me know and I'll forward it to you. But my guess is that the mails were delayed for some reason and that they simply haven't arrived yet. Hans On 11/14/2016 04:39 PM, Russell King - ARM Linux wrote: > I can't comment on these, you've not included me in patch 1 nor the > covering message. > > On Mon, Nov 14, 2016 at 04:22:45PM +0100, Hans Verkuil wrote: >> From: Russell King <rmk+kernel@arm.linux.org.uk> >> >> We don't need the CEC engine register definitions, so let's remove them. >> >> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> >> --- >> drivers/gpu/drm/bridge/dw-hdmi.h | 45 ---------------------------------------- >> 1 file changed, 45 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/dw-hdmi.h >> index fc9a560..26d6845 100644 >> --- a/drivers/gpu/drm/bridge/dw-hdmi.h >> +++ b/drivers/gpu/drm/bridge/dw-hdmi.h >> @@ -478,51 +478,6 @@ >> #define HDMI_A_PRESETUP 0x501A >> #define HDMI_A_SRM_BASE 0x5020 >> >> -/* CEC Engine Registers */ >> -#define HDMI_CEC_CTRL 0x7D00 >> -#define HDMI_CEC_STAT 0x7D01 >> -#define HDMI_CEC_MASK 0x7D02 >> -#define HDMI_CEC_POLARITY 0x7D03 >> -#define HDMI_CEC_INT 0x7D04 >> -#define HDMI_CEC_ADDR_L 0x7D05 >> -#define HDMI_CEC_ADDR_H 0x7D06 >> -#define HDMI_CEC_TX_CNT 0x7D07 >> -#define HDMI_CEC_RX_CNT 0x7D08 >> -#define HDMI_CEC_TX_DATA0 0x7D10 >> -#define HDMI_CEC_TX_DATA1 0x7D11 >> -#define HDMI_CEC_TX_DATA2 0x7D12 >> -#define HDMI_CEC_TX_DATA3 0x7D13 >> -#define HDMI_CEC_TX_DATA4 0x7D14 >> -#define HDMI_CEC_TX_DATA5 0x7D15 >> -#define HDMI_CEC_TX_DATA6 0x7D16 >> -#define HDMI_CEC_TX_DATA7 0x7D17 >> -#define HDMI_CEC_TX_DATA8 0x7D18 >> -#define HDMI_CEC_TX_DATA9 0x7D19 >> -#define HDMI_CEC_TX_DATA10 0x7D1a >> -#define HDMI_CEC_TX_DATA11 0x7D1b >> -#define HDMI_CEC_TX_DATA12 0x7D1c >> -#define HDMI_CEC_TX_DATA13 0x7D1d >> -#define HDMI_CEC_TX_DATA14 0x7D1e >> -#define HDMI_CEC_TX_DATA15 0x7D1f >> -#define HDMI_CEC_RX_DATA0 0x7D20 >> -#define HDMI_CEC_RX_DATA1 0x7D21 >> -#define HDMI_CEC_RX_DATA2 0x7D22 >> -#define HDMI_CEC_RX_DATA3 0x7D23 >> -#define HDMI_CEC_RX_DATA4 0x7D24 >> -#define HDMI_CEC_RX_DATA5 0x7D25 >> -#define HDMI_CEC_RX_DATA6 0x7D26 >> -#define HDMI_CEC_RX_DATA7 0x7D27 >> -#define HDMI_CEC_RX_DATA8 0x7D28 >> -#define HDMI_CEC_RX_DATA9 0x7D29 >> -#define HDMI_CEC_RX_DATA10 0x7D2a >> -#define HDMI_CEC_RX_DATA11 0x7D2b >> -#define HDMI_CEC_RX_DATA12 0x7D2c >> -#define HDMI_CEC_RX_DATA13 0x7D2d >> -#define HDMI_CEC_RX_DATA14 0x7D2e >> -#define HDMI_CEC_RX_DATA15 0x7D2f >> -#define HDMI_CEC_LOCK 0x7D30 >> -#define HDMI_CEC_WKUPCTRL 0x7D31 >> - >> /* I2C Master Registers (E-DDC) */ >> #define HDMI_I2CM_SLAVE 0x7E00 >> #define HDMI_I2CM_ADDRESS 0x7E01 >> -- >> 2.8.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
Hi, 2016-11-14 16:22 GMT+01:00 Hans Verkuil <hverkuil@xs4all.nl>: > From: Russell King <rmk+kernel@arm.linux.org.uk> > > We don't need the CEC engine register definitions, so let's remove them. > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > --- > drivers/gpu/drm/bridge/dw-hdmi.h | 45 ---------------------------------------- > 1 file changed, 45 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/dw-hdmi.h > index fc9a560..26d6845 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.h > +++ b/drivers/gpu/drm/bridge/dw-hdmi.h > @@ -478,51 +478,6 @@ > #define HDMI_A_PRESETUP 0x501A > #define HDMI_A_SRM_BASE 0x5020 > > -/* CEC Engine Registers */ > -#define HDMI_CEC_CTRL 0x7D00 > -#define HDMI_CEC_STAT 0x7D01 > -#define HDMI_CEC_MASK 0x7D02 I don't know if this is relevant for a submission, but the build stops working here because of a missing definition HDMI_CEC_MASK Perhaps this should be inverted with 3/5 to make bissecting easier? I was trying to bissect a kernel panic, and I had to fix this by hand > -#define HDMI_CEC_POLARITY 0x7D03 > -#define HDMI_CEC_INT 0x7D04 > -#define HDMI_CEC_ADDR_L 0x7D05 > -#define HDMI_CEC_ADDR_H 0x7D06 > -#define HDMI_CEC_TX_CNT 0x7D07 > -#define HDMI_CEC_RX_CNT 0x7D08 > -#define HDMI_CEC_TX_DATA0 0x7D10 > -#define HDMI_CEC_TX_DATA1 0x7D11 > -#define HDMI_CEC_TX_DATA2 0x7D12 > -#define HDMI_CEC_TX_DATA3 0x7D13 > -#define HDMI_CEC_TX_DATA4 0x7D14 > -#define HDMI_CEC_TX_DATA5 0x7D15 > -#define HDMI_CEC_TX_DATA6 0x7D16 > -#define HDMI_CEC_TX_DATA7 0x7D17 > -#define HDMI_CEC_TX_DATA8 0x7D18 > -#define HDMI_CEC_TX_DATA9 0x7D19 > -#define HDMI_CEC_TX_DATA10 0x7D1a > -#define HDMI_CEC_TX_DATA11 0x7D1b > -#define HDMI_CEC_TX_DATA12 0x7D1c > -#define HDMI_CEC_TX_DATA13 0x7D1d > -#define HDMI_CEC_TX_DATA14 0x7D1e > -#define HDMI_CEC_TX_DATA15 0x7D1f > -#define HDMI_CEC_RX_DATA0 0x7D20 > -#define HDMI_CEC_RX_DATA1 0x7D21 > -#define HDMI_CEC_RX_DATA2 0x7D22 > -#define HDMI_CEC_RX_DATA3 0x7D23 > -#define HDMI_CEC_RX_DATA4 0x7D24 > -#define HDMI_CEC_RX_DATA5 0x7D25 > -#define HDMI_CEC_RX_DATA6 0x7D26 > -#define HDMI_CEC_RX_DATA7 0x7D27 > -#define HDMI_CEC_RX_DATA8 0x7D28 > -#define HDMI_CEC_RX_DATA9 0x7D29 > -#define HDMI_CEC_RX_DATA10 0x7D2a > -#define HDMI_CEC_RX_DATA11 0x7D2b > -#define HDMI_CEC_RX_DATA12 0x7D2c > -#define HDMI_CEC_RX_DATA13 0x7D2d > -#define HDMI_CEC_RX_DATA14 0x7D2e > -#define HDMI_CEC_RX_DATA15 0x7D2f > -#define HDMI_CEC_LOCK 0x7D30 > -#define HDMI_CEC_WKUPCTRL 0x7D31 > - > /* I2C Master Registers (E-DDC) */ > #define HDMI_I2CM_SLAVE 0x7E00 > #define HDMI_I2CM_ADDRESS 0x7E01 > -- > 2.8.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Wed, Nov 16, 2016 at 12:23:50AM +0100, Pierre-Hugues Husson wrote: > Hi, > > > 2016-11-14 16:22 GMT+01:00 Hans Verkuil <hverkuil@xs4all.nl>: > > From: Russell King <rmk+kernel@arm.linux.org.uk> > > > > We don't need the CEC engine register definitions, so let's remove them. > > > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> > > --- > > drivers/gpu/drm/bridge/dw-hdmi.h | 45 ---------------------------------------- > > 1 file changed, 45 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/dw-hdmi.h > > index fc9a560..26d6845 100644 > > --- a/drivers/gpu/drm/bridge/dw-hdmi.h > > +++ b/drivers/gpu/drm/bridge/dw-hdmi.h > > @@ -478,51 +478,6 @@ > > #define HDMI_A_PRESETUP 0x501A > > #define HDMI_A_SRM_BASE 0x5020 > > > > -/* CEC Engine Registers */ > > -#define HDMI_CEC_CTRL 0x7D00 > > -#define HDMI_CEC_STAT 0x7D01 > > -#define HDMI_CEC_MASK 0x7D02 > I don't know if this is relevant for a submission, but the build stops > working here because of a missing definition HDMI_CEC_MASK > Perhaps this should be inverted with 3/5 to make bissecting easier? > I was trying to bissect a kernel panic, and I had to fix this by hand Doesn't make sense - patch 3 doesn't reference HDMI_CEC_MASK. Please show the build error in full.
2016-11-16 0:27 GMT+01:00 Russell King - ARM Linux <linux@armlinux.org.uk>: > On Wed, Nov 16, 2016 at 12:23:50AM +0100, Pierre-Hugues Husson wrote: >> Hi, >> >> >> 2016-11-14 16:22 GMT+01:00 Hans Verkuil <hverkuil@xs4all.nl>: >> > From: Russell King <rmk+kernel@arm.linux.org.uk> >> > >> > We don't need the CEC engine register definitions, so let's remove them. >> > >> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> >> > --- >> > drivers/gpu/drm/bridge/dw-hdmi.h | 45 ---------------------------------------- >> > 1 file changed, 45 deletions(-) >> > >> > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/dw-hdmi.h >> > index fc9a560..26d6845 100644 >> > --- a/drivers/gpu/drm/bridge/dw-hdmi.h >> > +++ b/drivers/gpu/drm/bridge/dw-hdmi.h >> > @@ -478,51 +478,6 @@ >> > #define HDMI_A_PRESETUP 0x501A >> > #define HDMI_A_SRM_BASE 0x5020 >> > >> > -/* CEC Engine Registers */ >> > -#define HDMI_CEC_CTRL 0x7D00 >> > -#define HDMI_CEC_STAT 0x7D01 >> > -#define HDMI_CEC_MASK 0x7D02 >> I don't know if this is relevant for a submission, but the build stops >> working here because of a missing definition HDMI_CEC_MASK >> Perhaps this should be inverted with 3/5 to make bissecting easier? >> I was trying to bissect a kernel panic, and I had to fix this by hand > > Doesn't make sense - patch 3 doesn't reference HDMI_CEC_MASK. > > Please show the build error in full. The build is actually fixed with patch 4. Building after patch 2 fails with: drivers/gpu/drm/bridge/dw-hdmi.c: In function ‘initialize_hdmi_ih_mutes’: drivers/gpu/drm/bridge/dw-hdmi.c:1300:26: error: ‘HDMI_CEC_MASK’ undeclared (first use in this function) hdmi_writeb(hdmi, 0xff, HDMI_CEC_MASK); The point of switching patch 3 and patch 2, is that the build works with patch 1,3 applied. Applying patch 2 breaks the build, but doesn't change any active code, so it's ok. So with the order 1,3,2,4,5, the build is broken only after 2, while with 1,2,3,4,5, it is broken after 2 and 3. I hope this makes my remark more explicit. If it doesn't, I think it is quite safe to just ignore it
diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/dw-hdmi.h index fc9a560..26d6845 100644 --- a/drivers/gpu/drm/bridge/dw-hdmi.h +++ b/drivers/gpu/drm/bridge/dw-hdmi.h @@ -478,51 +478,6 @@ #define HDMI_A_PRESETUP 0x501A #define HDMI_A_SRM_BASE 0x5020 -/* CEC Engine Registers */ -#define HDMI_CEC_CTRL 0x7D00 -#define HDMI_CEC_STAT 0x7D01 -#define HDMI_CEC_MASK 0x7D02 -#define HDMI_CEC_POLARITY 0x7D03 -#define HDMI_CEC_INT 0x7D04 -#define HDMI_CEC_ADDR_L 0x7D05 -#define HDMI_CEC_ADDR_H 0x7D06 -#define HDMI_CEC_TX_CNT 0x7D07 -#define HDMI_CEC_RX_CNT 0x7D08 -#define HDMI_CEC_TX_DATA0 0x7D10 -#define HDMI_CEC_TX_DATA1 0x7D11 -#define HDMI_CEC_TX_DATA2 0x7D12 -#define HDMI_CEC_TX_DATA3 0x7D13 -#define HDMI_CEC_TX_DATA4 0x7D14 -#define HDMI_CEC_TX_DATA5 0x7D15 -#define HDMI_CEC_TX_DATA6 0x7D16 -#define HDMI_CEC_TX_DATA7 0x7D17 -#define HDMI_CEC_TX_DATA8 0x7D18 -#define HDMI_CEC_TX_DATA9 0x7D19 -#define HDMI_CEC_TX_DATA10 0x7D1a -#define HDMI_CEC_TX_DATA11 0x7D1b -#define HDMI_CEC_TX_DATA12 0x7D1c -#define HDMI_CEC_TX_DATA13 0x7D1d -#define HDMI_CEC_TX_DATA14 0x7D1e -#define HDMI_CEC_TX_DATA15 0x7D1f -#define HDMI_CEC_RX_DATA0 0x7D20 -#define HDMI_CEC_RX_DATA1 0x7D21 -#define HDMI_CEC_RX_DATA2 0x7D22 -#define HDMI_CEC_RX_DATA3 0x7D23 -#define HDMI_CEC_RX_DATA4 0x7D24 -#define HDMI_CEC_RX_DATA5 0x7D25 -#define HDMI_CEC_RX_DATA6 0x7D26 -#define HDMI_CEC_RX_DATA7 0x7D27 -#define HDMI_CEC_RX_DATA8 0x7D28 -#define HDMI_CEC_RX_DATA9 0x7D29 -#define HDMI_CEC_RX_DATA10 0x7D2a -#define HDMI_CEC_RX_DATA11 0x7D2b -#define HDMI_CEC_RX_DATA12 0x7D2c -#define HDMI_CEC_RX_DATA13 0x7D2d -#define HDMI_CEC_RX_DATA14 0x7D2e -#define HDMI_CEC_RX_DATA15 0x7D2f -#define HDMI_CEC_LOCK 0x7D30 -#define HDMI_CEC_WKUPCTRL 0x7D31 - /* I2C Master Registers (E-DDC) */ #define HDMI_I2CM_SLAVE 0x7E00 #define HDMI_I2CM_ADDRESS 0x7E01