| Message ID | 20161111184302.2438-7-tony@atomide.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Nov 11, 2016 at 10:43:02AM -0800, Tony Lindgren wrote: > This already gets done automatically by PM runtime and we have > a separate autosuspend timeout in musb_core.c. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > @@ -816,8 +801,6 @@ static int dsps_remove(struct platform_device *pdev) > platform_device_unregister(glue->musb); > > /* disable usbss clocks */ Perhaps also drop this comment which no longer applies. > - pm_runtime_dont_use_autosuspend(&pdev->dev); > - pm_runtime_put_sync(&pdev->dev); > pm_runtime_disable(&pdev->dev); Reviewed-by: Johan Hovold <johan@kernel.org> Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Johan Hovold <johan@kernel.org> [161114 07:59]: > On Fri, Nov 11, 2016 at 10:43:02AM -0800, Tony Lindgren wrote: > > This already gets done automatically by PM runtime and we have > > a separate autosuspend timeout in musb_core.c. > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > @@ -816,8 +801,6 @@ static int dsps_remove(struct platform_device *pdev) > > platform_device_unregister(glue->musb); > > > > /* disable usbss clocks */ > > Perhaps also drop this comment which no longer applies. OK will drop and repost the whole series one more time on Tuesday in case more comments are still coming. > > - pm_runtime_dont_use_autosuspend(&pdev->dev); > > - pm_runtime_put_sync(&pdev->dev); > > pm_runtime_disable(&pdev->dev); > > Reviewed-by: Johan Hovold <johan@kernel.org> Thanks, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -783,28 +783,13 @@ static int dsps_probe(struct platform_device *pdev) platform_set_drvdata(pdev, glue); pm_runtime_enable(&pdev->dev); - pm_runtime_use_autosuspend(&pdev->dev); - pm_runtime_set_autosuspend_delay(&pdev->dev, 200); - - ret = pm_runtime_get_sync(&pdev->dev); - if (ret < 0) { - dev_err(&pdev->dev, "pm_runtime_get_sync FAILED"); - goto err2; - } - ret = dsps_create_musb_pdev(glue, pdev); if (ret) - goto err3; - - pm_runtime_mark_last_busy(&pdev->dev); - pm_runtime_put_autosuspend(&pdev->dev); + goto err; return 0; -err3: - pm_runtime_put_sync(&pdev->dev); -err2: - pm_runtime_dont_use_autosuspend(&pdev->dev); +err: pm_runtime_disable(&pdev->dev); return ret; } @@ -816,8 +801,6 @@ static int dsps_remove(struct platform_device *pdev) platform_device_unregister(glue->musb); /* disable usbss clocks */ - pm_runtime_dont_use_autosuspend(&pdev->dev); - pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); return 0;
This already gets done automatically by PM runtime and we have a separate autosuspend timeout in musb_core.c. Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/usb/musb/musb_dsps.c | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-)