| Message ID | 1479498793-31021-20-git-send-email-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Ville, Thank you for the patch. On Friday 18 Nov 2016 21:52:55 ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > To avoid having to look up the format information struct every time, > let's just store a pointer to it under drm_framebuffer. > > v2: Don't populate the fb->format pointer in drm_framebuffer_init(). > instead we'll treat a NULL format as an error later > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/drm_modeset_helper.c | 1 + > include/drm/drm_framebuffer.h | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/drm_modeset_helper.c > b/drivers/gpu/drm/drm_modeset_helper.c index 57a319e3f780..1aa5e3bcc8a1 > 100644 > --- a/drivers/gpu/drm/drm_modeset_helper.c > +++ b/drivers/gpu/drm/drm_modeset_helper.c > @@ -91,6 +91,7 @@ void drm_helper_mode_fill_fb_struct(struct drm_device > *dev, } > > fb->dev = dev; > + fb->format = info; > fb->width = mode_cmd->width; > fb->height = mode_cmd->height; > for (i = 0; i < 4; i++) { > diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h > index b3141a0e609b..741b3a994d1f 100644 > --- a/include/drm/drm_framebuffer.h > +++ b/include/drm/drm_framebuffer.h > @@ -122,6 +122,10 @@ struct drm_framebuffer { > */ > struct drm_mode_object base; > /** > + * @format: framebuffer format information > + */ > + const struct drm_format_info *format; > + /** > * @funcs: framebuffer vfunc table > */ > const struct drm_framebuffer_funcs *funcs;
diff --git a/drivers/gpu/drm/drm_modeset_helper.c b/drivers/gpu/drm/drm_modeset_helper.c index 57a319e3f780..1aa5e3bcc8a1 100644 --- a/drivers/gpu/drm/drm_modeset_helper.c +++ b/drivers/gpu/drm/drm_modeset_helper.c @@ -91,6 +91,7 @@ void drm_helper_mode_fill_fb_struct(struct drm_device *dev, } fb->dev = dev; + fb->format = info; fb->width = mode_cmd->width; fb->height = mode_cmd->height; for (i = 0; i < 4; i++) { diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h index b3141a0e609b..741b3a994d1f 100644 --- a/include/drm/drm_framebuffer.h +++ b/include/drm/drm_framebuffer.h @@ -122,6 +122,10 @@ struct drm_framebuffer { */ struct drm_mode_object base; /** + * @format: framebuffer format information + */ + const struct drm_format_info *format; + /** * @funcs: framebuffer vfunc table */ const struct drm_framebuffer_funcs *funcs;