| Message ID | 1479800961-6249-5-git-send-email-zhangfei.gao@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday, November 22, 2016 3:49:19 PM CET Zhangfei Gao wrote: > Required properties: > - compatible: should be one of the following: > - - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller. > - - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller. > -- reg: should be register base and length as documented in the > - datasheet > + - "hisilicon,hi6220-reset-sysctrl" : For peripheral reset controller. > + - "hisilicon,hi6220-reset-mediactrl" : For media reset controller. > +- hisi,rst-syscon: phandle of the reset's syscon. > - #reset-cells: 1, see below > Please keep the old strings around for compatibility. Arnd
On Tue, Nov 22, 2016 at 09:48:32AM +0100, Arnd Bergmann wrote: > On Tuesday, November 22, 2016 3:49:19 PM CET Zhangfei Gao wrote: > > Required properties: > > - compatible: should be one of the following: > > - - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller. > > - - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller. > > -- reg: should be register base and length as documented in the > > - datasheet > > + - "hisilicon,hi6220-reset-sysctrl" : For peripheral reset controller. > > + - "hisilicon,hi6220-reset-mediactrl" : For media reset controller. > > +- hisi,rst-syscon: phandle of the reset's syscon. > > - #reset-cells: 1, see below > > > > Please keep the old strings around for compatibility. Why are these even changing? The commit message should say why. Rob
Hi, Rob On 2016年11月24日 07:06, Rob Herring wrote: > On Tue, Nov 22, 2016 at 09:48:32AM +0100, Arnd Bergmann wrote: >> On Tuesday, November 22, 2016 3:49:19 PM CET Zhangfei Gao wrote: >>> Required properties: >>> - compatible: should be one of the following: >>> - - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller. >>> - - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller. >>> -- reg: should be register base and length as documented in the >>> - datasheet >>> + - "hisilicon,hi6220-reset-sysctrl" : For peripheral reset controller. >>> + - "hisilicon,hi6220-reset-mediactrl" : For media reset controller. >>> +- hisi,rst-syscon: phandle of the reset's syscon. >>> - #reset-cells: 1, see below >>> >> Please keep the old strings around for compatibility. > Why are these even changing? The commit message should say why. Have send [RFC V2:PATCH 0/2] add reset-hi3660 Not touching this file any more. Only handle hi3660. But hi6220 can directly use the driver. Only need list reset info to hi6220.dts, same as hi3660. Like + iomcu_rst: iomcu_rst_controller { + compatible = "hisilicon,hi3660-reset"; + #reset-cells = <1>; + hisi,rst-syscon = <&iomcu>; + hisi,reset-bits = <0x20 0x8 /* 0: i2c0 */ + 0x20 0x10 /* 1: i2c1 */ + 0x20 0x20 /* 2: i2c2 */ + 0x20 0x8000000>; /* 3: i2c6 */ + }; Thanks
diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt index c25da39..6a864f3 100644 --- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt @@ -9,10 +9,9 @@ hi6220 SoC. Required properties: - compatible: should be one of the following: - - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller. - - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller. -- reg: should be register base and length as documented in the - datasheet + - "hisilicon,hi6220-reset-sysctrl" : For peripheral reset controller. + - "hisilicon,hi6220-reset-mediactrl" : For media reset controller. +- hisi,rst-syscon: phandle of the reset's syscon. - #reset-cells: 1, see below Example: @@ -20,7 +19,12 @@ sys_ctrl: sys_ctrl@f7030000 { compatible = "hisilicon,hi6220-sysctrl", "syscon"; reg = <0x0 0xf7030000 0x0 0x2000>; #clock-cells = <1>; +}; + +sys_ctrl_rst: sys_rst_controller { + compatible = "hisilicon,hi6220-reset-sysctrl"; #reset-cells = <1>; + hisi,rst-syscon = <&sys_ctrl>; }; Specifying reset lines connected to IP modules @@ -29,7 +33,7 @@ example: uart1: serial@..... { ... - resets = <&sys_ctrl PERIPH_RSTEN3_UART1>; + resets = <&sys_ctrl_rst PERIPH_RSTEN3_UART1>; ... };
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> --- .../devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)