| Message ID | 20161121161541.27048-2-ahaslam@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: > The card detect gpio on the hawk board is gpio4_0 and not gpio3_12 > > Signed-off-by: Axel Haslam <ahaslam@baylibre.com> The LCDK and HawkBoard are different boards. The HawkBoard schematic from eLinux.org page is broken, but looking for it on the net, I found one and the MMC/SD CD pin in that schematic is indeed connected to GPIO3_12. So I believe the original code is correct. Thanks, Sekhar
On Tue, Nov 22, 2016 at 10:53 AM, Sekhar Nori <nsekhar@ti.com> wrote: > On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: >> The card detect gpio on the hawk board is gpio4_0 and not gpio3_12 >> >> Signed-off-by: Axel Haslam <ahaslam@baylibre.com> > > The LCDK and HawkBoard are different boards. The HawkBoard schematic > from eLinux.org page is broken, but looking for it on the net, I found > one and the MMC/SD CD pin in that schematic is indeed connected to GPIO3_12. > > So I believe the original code is correct. mmm, ok, the lcdk is booted using the hawk board file, so we should differentiate the two boards? or should we just live with inconsistencies on the lcdk? (im guessing the same will be ture for the usb) Regards Axel. > > Thanks, > Sekhar >
On Tuesday 22 November 2016 03:40 PM, Axel Haslam wrote: > On Tue, Nov 22, 2016 at 10:53 AM, Sekhar Nori <nsekhar@ti.com> wrote: >> On Monday 21 November 2016 09:45 PM, Axel Haslam wrote: >>> The card detect gpio on the hawk board is gpio4_0 and not gpio3_12 >>> >>> Signed-off-by: Axel Haslam <ahaslam@baylibre.com> >> >> The LCDK and HawkBoard are different boards. The HawkBoard schematic >> from eLinux.org page is broken, but looking for it on the net, I found >> one and the MMC/SD CD pin in that schematic is indeed connected to GPIO3_12. >> >> So I believe the original code is correct. > > mmm, ok, the lcdk is booted using the hawk board file, I think this is just a coincidence. The LCDK came after the hawkboard as its replacement, and I guess there was some effort to derive out of hawkboard design. But they are not 100% software compatible, like you are discovering now. > so we should differentiate the two boards? Yes. > or should we just live with inconsistencies on the lcdk? Not sure what you mean by "live with inconsistencies on the lcdk". The two boards need to be treated as close cousins, but independent boards. Thanks, Sekhar
diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c index a4e8726..c0c24ba9 100644 --- a/arch/arm/mach-davinci/board-omapl138-hawk.c +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c @@ -25,7 +25,7 @@ #include <mach/mux.h> #define HAWKBOARD_PHY_ID "davinci_mdio-0:07" -#define DA850_HAWK_MMCSD_CD_PIN GPIO_TO_PIN(3, 12) +#define DA850_HAWK_MMCSD_CD_PIN GPIO_TO_PIN(4, 0) #define DA850_HAWK_MMCSD_WP_PIN GPIO_TO_PIN(3, 13) #define DA850_USB1_VBUS_PIN GPIO_TO_PIN(2, 4) @@ -119,7 +119,7 @@ static struct edma_rsv_info *da850_edma_rsv[2] = { static const short hawk_mmcsd0_pins[] = { DA850_MMCSD0_DAT_0, DA850_MMCSD0_DAT_1, DA850_MMCSD0_DAT_2, DA850_MMCSD0_DAT_3, DA850_MMCSD0_CLK, DA850_MMCSD0_CMD, - DA850_GPIO3_12, DA850_GPIO3_13, + DA850_GPIO4_0, DA850_GPIO3_13, -1 };
The card detect gpio on the hawk board is gpio4_0 and not gpio3_12 Signed-off-by: Axel Haslam <ahaslam@baylibre.com> --- arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)