| Message ID | 20161122014408.22388-5-khilman@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 22/11/16 02:44, Kevin Hilman wrote: > Cc: Rob Herring <robh@kernel.org> > Signed-off-by: Kevin Hilman <khilman@baylibre.com> > --- > .../bindings/media/ti,da850-vpif-capture.txt | 65 ++++++++++++++++++++++ > .../devicetree/bindings/media/ti,da850-vpif.txt | 8 +++ > 2 files changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt > create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt > > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt > new file mode 100644 > index 000000000000..bdd93267301f > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt > @@ -0,0 +1,65 @@ > +Texas Instruments VPIF Capture > +------------------------------ > + > +The TI Video Port InterFace (VPIF) capture component is the primary > +component for video capture on the DA850 family of TI DaVinci SoCs. > + > +TI Document number reference: SPRUH82C > + > +Required properties: > +- compatible: must be "ti,da850-vpif-capture" > +- reg: physical base address and length of the registers set for the device; > +- interrupts: should contain IRQ line for the VPIF > + > +VPIF capture has a 16-bit parallel bus input, supporting 2 8-bit > +channels or a single 16-bit channel. It should contain at least one > +port child node with child 'endpoint' node. Please refer to the > +bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +Example using 2 8-bit input channels, one of which is connected to an > +I2C-connected TVP5147 decoder: > + > + vpif_capture: video-capture@0x00217000 { > + compatible = "ti,vpif-capture"; Did you forget to update the compatible string to ti,da850-vpif-capture? Hans > + reg = <0x00217000 0x1000>; > + interrupts = <92>; > + > + port { > + vpif_ch0: endpoint@0 { > + reg = <0>; > + bus-width = <8>; > + remote-endpoint = <&composite>; > + }; > + > + vpif_ch1: endpoint@1 { > + reg = <1>; > + bus-width = <8>; > + data-shift = <8>; > + }; > + }; > + }; > + > +[ ... ] > + > +&i2c0 { > + > + tvp5147@5d { > + compatible = "ti,tvp5147"; > + reg = <0x5d>; > + status = "okay"; > + > + port { > + composite: endpoint { > + hsync-active = <1>; > + vsync-active = <1>; > + pclk-sample = <0>; > + > + /* VPIF channel 0 (lower 8-bits) */ > + remote-endpoint = <&vpif_ch0>; > + bus-width = <8>; > + }; > + }; > + }; > + > +}; > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > new file mode 100644 > index 000000000000..d004e600aabe > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > @@ -0,0 +1,8 @@ > +Texas Instruments VPIF > +---------------------- > + > +The Video Port InterFace (VPIF) is the core component for video output > +and capture on DA850 TI Davinci SoCs. > + > +- compatible: must be "ti,da850-vpif" > +- reg: physical base address and length of the registers set for the device; > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hans Verkuil <hverkuil@xs4all.nl> writes: > On 22/11/16 02:44, Kevin Hilman wrote: >> Cc: Rob Herring <robh@kernel.org> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> --- >> .../bindings/media/ti,da850-vpif-capture.txt | 65 ++++++++++++++++++++++ >> .../devicetree/bindings/media/ti,da850-vpif.txt | 8 +++ >> 2 files changed, 73 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt >> create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt >> >> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt >> new file mode 100644 >> index 000000000000..bdd93267301f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt >> @@ -0,0 +1,65 @@ >> +Texas Instruments VPIF Capture >> +------------------------------ >> + >> +The TI Video Port InterFace (VPIF) capture component is the primary >> +component for video capture on the DA850 family of TI DaVinci SoCs. >> + >> +TI Document number reference: SPRUH82C >> + >> +Required properties: >> +- compatible: must be "ti,da850-vpif-capture" >> +- reg: physical base address and length of the registers set for the device; >> +- interrupts: should contain IRQ line for the VPIF >> + >> +VPIF capture has a 16-bit parallel bus input, supporting 2 8-bit >> +channels or a single 16-bit channel. It should contain at least one >> +port child node with child 'endpoint' node. Please refer to the >> +bindings defined in >> +Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example using 2 8-bit input channels, one of which is connected to an >> +I2C-connected TVP5147 decoder: >> + >> + vpif_capture: video-capture@0x00217000 { >> + compatible = "ti,vpif-capture"; > > Did you forget to update the compatible string to ti,da850-vpif-capture? > Ugh, yup. v3 coming right up. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt new file mode 100644 index 000000000000..bdd93267301f --- /dev/null +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt @@ -0,0 +1,65 @@ +Texas Instruments VPIF Capture +------------------------------ + +The TI Video Port InterFace (VPIF) capture component is the primary +component for video capture on the DA850 family of TI DaVinci SoCs. + +TI Document number reference: SPRUH82C + +Required properties: +- compatible: must be "ti,da850-vpif-capture" +- reg: physical base address and length of the registers set for the device; +- interrupts: should contain IRQ line for the VPIF + +VPIF capture has a 16-bit parallel bus input, supporting 2 8-bit +channels or a single 16-bit channel. It should contain at least one +port child node with child 'endpoint' node. Please refer to the +bindings defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Example using 2 8-bit input channels, one of which is connected to an +I2C-connected TVP5147 decoder: + + vpif_capture: video-capture@0x00217000 { + compatible = "ti,vpif-capture"; + reg = <0x00217000 0x1000>; + interrupts = <92>; + + port { + vpif_ch0: endpoint@0 { + reg = <0>; + bus-width = <8>; + remote-endpoint = <&composite>; + }; + + vpif_ch1: endpoint@1 { + reg = <1>; + bus-width = <8>; + data-shift = <8>; + }; + }; + }; + +[ ... ] + +&i2c0 { + + tvp5147@5d { + compatible = "ti,tvp5147"; + reg = <0x5d>; + status = "okay"; + + port { + composite: endpoint { + hsync-active = <1>; + vsync-active = <1>; + pclk-sample = <0>; + + /* VPIF channel 0 (lower 8-bits) */ + remote-endpoint = <&vpif_ch0>; + bus-width = <8>; + }; + }; + }; + +}; diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt new file mode 100644 index 000000000000..d004e600aabe --- /dev/null +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt @@ -0,0 +1,8 @@ +Texas Instruments VPIF +---------------------- + +The Video Port InterFace (VPIF) is the core component for video output +and capture on DA850 TI Davinci SoCs. + +- compatible: must be "ti,da850-vpif" +- reg: physical base address and length of the registers set for the device;
Cc: Rob Herring <robh@kernel.org> Signed-off-by: Kevin Hilman <khilman@baylibre.com> --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++++++++++++++++++++++ .../devicetree/bindings/media/ti,da850-vpif.txt | 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txt