| Message ID | 1480449039-14774-1-git-send-email-martin@kaiser.cx (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 29, 2016 at 08:50:39PM +0100, Martin Kaiser wrote: > The current definitions of DMACR_HM() and DMACR_TM() are correct only > for imx1, they're wrong for imx21. > > The macros are meant for legacy board files only, they're not applicable > for boards using device tree. > > At the moment, there are no boards using these macros. So it should be > safe to drop them rather than making them work for both imx1 and imx21, > which would require a change in the platform data struct. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
Hi, On Tuesday, November 29, 2016 08:57:21 PM Uwe Kleine-König wrote: > On Tue, Nov 29, 2016 at 08:50:39PM +0100, Martin Kaiser wrote: > > The current definitions of DMACR_HM() and DMACR_TM() are correct only > > for imx1, they're wrong for imx21. > > > > The macros are meant for legacy board files only, they're not applicable > > for boards using device tree. > > > > At the moment, there are no boards using these macros. So it should be > > safe to drop them rather than making them work for both imx1 and imx21, > > which would require a change in the platform data struct. > > > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks, queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/platform_data/video-imxfb.h b/include/linux/platform_data/video-imxfb.h index 18e9083..a5c0a71 100644 --- a/include/linux/platform_data/video-imxfb.h +++ b/include/linux/platform_data/video-imxfb.h @@ -47,10 +47,6 @@ #define LSCR1_GRAY2(x) (((x) & 0xf) << 4) #define LSCR1_GRAY1(x) (((x) & 0xf)) -#define DMACR_BURST (1 << 31) -#define DMACR_HM(x) (((x) & 0xf) << 16) -#define DMACR_TM(x) ((x) & 0xf) - struct imx_fb_videomode { struct fb_videomode mode; u32 pcr;
The current definitions of DMACR_HM() and DMACR_TM() are correct only for imx1, they're wrong for imx21. The macros are meant for legacy board files only, they're not applicable for boards using device tree. At the moment, there are no boards using these macros. So it should be safe to drop them rather than making them work for both imx1 and imx21, which would require a change in the platform data struct. Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- Change in v2: fixed the commit message include/linux/platform_data/video-imxfb.h | 4 ---- 1 file changed, 4 deletions(-)