| Message ID | 1480681381-1188-3-git-send-email-ian.jackson@eu.citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 02.12.16 at 13:23, <ian.jackson@eu.citrix.com> wrote: > AFAICT following bacbf0cb7349 "build: convert debug to Kconfig" > hypervisor debug enablement is controlled here, rather than in > Config.mk. > > The release checklist says that when branching, the new staging should > have debug enabled. It seems to me that I should be changing this > here, therefore. > > As additional evidence, I offer e1d1c68ea8a3 "xen: disable debug > build" which went in between 4.8.0 RC5 and RC6. It does not explain > why this was done but it does STM that reverting that change is right. > > CC: Andrew Cooper <andrew.cooper3@citrix.com> > CC: George Dunlap <George.Dunlap@eu.citrix.com> > CC: Jan Beulich <jbeulich@suse.com> > CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Tim Deegan <tim@xen.org> > CC: Wei Liu <wei.liu2@citrix.com> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com>
Jan Beulich writes ("Re: [PATCH 2/2] Re-enable hypervisor debug as part of opening 4.9"):
> Acked-by: Jan Beulich <jbeulich@suse.com>
Thanks, pushed. I have also updated the checklist.
Ian.
diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index b3bb085..e9f7dcd 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -3,7 +3,7 @@ menu "Debugging Options" config DEBUG bool "Developer Checks" - default n + default y ---help--- If you say Y here this will enable developer checks such as asserts and extra printks. This option is intended for development purposes
AFAICT following bacbf0cb7349 "build: convert debug to Kconfig" hypervisor debug enablement is controlled here, rather than in Config.mk. The release checklist says that when branching, the new staging should have debug enabled. It seems to me that I should be changing this here, therefore. As additional evidence, I offer e1d1c68ea8a3 "xen: disable debug build" which went in between 4.8.0 RC5 and RC6. It does not explain why this was done but it does STM that reverting that change is right. CC: Andrew Cooper <andrew.cooper3@citrix.com> CC: George Dunlap <George.Dunlap@eu.citrix.com> CC: Jan Beulich <jbeulich@suse.com> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Tim Deegan <tim@xen.org> CC: Wei Liu <wei.liu2@citrix.com> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> --- xen/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)