| Message ID | 1480420624-23544-2-git-send-email-bgolaszewski@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 29/11/16 13:57, Bartosz Golaszewski wrote: > Add the dumb-vga-dac node to the board DT together with corresponding > ports and vga connector. This allows to retrieve the edid info from > the display automatically. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++ > 2 files changed, 75 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index 711b9ad..d864f11 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -50,6 +50,53 @@ > system-clock-frequency = <24576000>; > }; > }; > + > + vga_bridge { > + compatible = "dumb-vga-dac"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_pins>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + vga_bridge_in: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&display_out_vga>; > + }; > + }; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + vga_bridge_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_con_in>; > + }; > + }; > + }; > + }; > + > + vga { > + compatible = "vga-connector"; > + > + ddc-i2c-bus = <&i2c0>; > + > + port { > + vga_con_in: endpoint { > + remote-endpoint = <&vga_bridge_out>; > + }; > + }; > + }; > }; > > &pmx_core { > @@ -235,3 +282,14 @@ > &memctrl { > status = "okay"; > }; > + > +&display { > + status = "okay"; > +}; > + > +&display_out { > + display_out_vga: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_bridge_in>; > + }; > +}; > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 4070619..5f4ba2e 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -454,6 +454,23 @@ > reg = <0x213000 0x1000>; > interrupts = <52>; > status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display_in: port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + }; > + > + display_out: port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + }; > + }; > }; It's a bit difficult to follow this as there's been so many patches going around. But I take the above is the LCDC node in the base da850 dtsi file? In that case, what is the display_in supposed to present? It's the first node in the "display chain", so it has no input. Also, don't touch da850.dtsi here, just add the "ports" node in the da850-lcdk.dts file. If the da850.dtsi has not been merged yet, I'd change the name of the lcdc node to something else than "display". It's rather vague. If it's named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll refer to "lcdc". Tomi
On Tue, Nov 29, 2016 at 5:57 AM, Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > Add the dumb-vga-dac node to the board DT together with corresponding > ports and vga connector. This allows to retrieve the edid info from > the display automatically. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++ > 2 files changed, 75 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index 711b9ad..d864f11 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -50,6 +50,53 @@ > system-clock-frequency = <24576000>; > }; > }; > + > + vga_bridge { s/_/-/ > + compatible = "dumb-vga-dac"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_pins>; Are these pins from the LCD controller? They should be part of the LCD controller node. Rob
2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: > On 29/11/16 13:57, Bartosz Golaszewski wrote: >> Add the dumb-vga-dac node to the board DT together with corresponding >> ports and vga connector. This allows to retrieve the edid info from >> the display automatically. >> > > It's a bit difficult to follow this as there's been so many patches > going around. But I take the above is the LCDC node in the base da850 > dtsi file? In that case, what is the display_in supposed to present? > It's the first node in the "display chain", so it has no input. > > Also, don't touch da850.dtsi here, just add the "ports" node in the > da850-lcdk.dts file. > > If the da850.dtsi has not been merged yet, I'd change the name of the > lcdc node to something else than "display". It's rather vague. If it's > named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll > refer to "lcdc". > The node is already in Sekhar's branch. Thanks, Bartosz
On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: > 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: >> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>> Add the dumb-vga-dac node to the board DT together with corresponding >>> ports and vga connector. This allows to retrieve the edid info from >>> the display automatically. >>> >> >> It's a bit difficult to follow this as there's been so many patches >> going around. But I take the above is the LCDC node in the base da850 >> dtsi file? In that case, what is the display_in supposed to present? >> It's the first node in the "display chain", so it has no input. >> >> Also, don't touch da850.dtsi here, just add the "ports" node in the >> da850-lcdk.dts file. >> >> If the da850.dtsi has not been merged yet, I'd change the name of the >> lcdc node to something else than "display". It's rather vague. If it's >> named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll >> refer to "lcdc". >> > > The node is already in Sekhar's branch. The node name should be 'display' as thats the ePAPR 1.1 generic name recommendation. The label is also set to 'display' though and that can be changed to lcdc. A pre-patch to fix that before we modify the node further is welcome. Thanks, Sekhar
2016-12-06 16:03 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: > On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: >> 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: >>> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>>> Add the dumb-vga-dac node to the board DT together with corresponding >>>> ports and vga connector. This allows to retrieve the edid info from >>>> the display automatically. >>>> >>> >>> It's a bit difficult to follow this as there's been so many patches >>> going around. But I take the above is the LCDC node in the base da850 >>> dtsi file? In that case, what is the display_in supposed to present? >>> It's the first node in the "display chain", so it has no input. >>> >>> Also, don't touch da850.dtsi here, just add the "ports" node in the >>> da850-lcdk.dts file. >>> >>> If the da850.dtsi has not been merged yet, I'd change the name of the >>> lcdc node to something else than "display". It's rather vague. If it's >>> named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll >>> refer to "lcdc". >>> >> >> The node is already in Sekhar's branch. > > The node name should be 'display' as thats the ePAPR 1.1 generic name > recommendation. The label is also set to 'display' though and that can > be changed to lcdc. > > A pre-patch to fix that before we modify the node further is welcome. > > Thanks, > Sekhar I'll include this in v5 together with the change requested by Laurent. Thanks, Bartosz
diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts index 711b9ad..d864f11 100644 --- a/arch/arm/boot/dts/da850-lcdk.dts +++ b/arch/arm/boot/dts/da850-lcdk.dts @@ -50,6 +50,53 @@ system-clock-frequency = <24576000>; }; }; + + vga_bridge { + compatible = "dumb-vga-dac"; + pinctrl-names = "default"; + pinctrl-0 = <&lcd_pins>; + #address-cells = <1>; + #size-cells = <0>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + vga_bridge_in: endpoint@0 { + reg = <0>; + remote-endpoint = <&display_out_vga>; + }; + }; + + port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + vga_bridge_out: endpoint@0 { + reg = <0>; + remote-endpoint = <&vga_con_in>; + }; + }; + }; + }; + + vga { + compatible = "vga-connector"; + + ddc-i2c-bus = <&i2c0>; + + port { + vga_con_in: endpoint { + remote-endpoint = <&vga_bridge_out>; + }; + }; + }; }; &pmx_core { @@ -235,3 +282,14 @@ &memctrl { status = "okay"; }; + +&display { + status = "okay"; +}; + +&display_out { + display_out_vga: endpoint@0 { + reg = <0>; + remote-endpoint = <&vga_bridge_in>; + }; +}; diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 4070619..5f4ba2e 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -454,6 +454,23 @@ reg = <0x213000 0x1000>; interrupts = <52>; status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + display_in: port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + }; + + display_out: port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + }; + }; }; }; aemif: aemif@68000000 {
Add the dumb-vga-dac node to the board DT together with corresponding ports and vga connector. This allows to retrieve the edid info from the display automatically. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++ 2 files changed, 75 insertions(+)