Message ID | 20161207125130.5184-1-fziglio@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 12/07/2016 07:51 AM, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > --- > ui/egl-helpers.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c > index 79cee05..cd24568 100644 > --- a/ui/egl-helpers.c > +++ b/ui/egl-helpers.c > @@ -1,3 +1,19 @@ > +/* > + * Copyright (C) 2015-2016 Gerd Hoffmann <kraxel@redhat.com> > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, see <http://www.gnu.org/licenses/>. > + */ > #include "qemu/osdep.h" > #include <glob.h> > #include <dirent.h> > ACK, I'm fine with relicensing my changes - Cole
On 7 December 2016 at 12:51, Frediano Ziglio <fziglio@redhat.com> wrote: > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > --- > ui/egl-helpers.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c > index 79cee05..cd24568 100644 > --- a/ui/egl-helpers.c > +++ b/ui/egl-helpers.c > @@ -1,3 +1,19 @@ > +/* > + * Copyright (C) 2015-2016 Gerd Hoffmann <kraxel@redhat.com> This looks a bit odd. Is the code copyright Gerd as an individual, or Red Hat as a company? thanks -- PMM
On 12/07/2016 06:51 AM, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Very sparse on the commit message. I would highly recommend being
verbose with something like "all people listed below have agreed to the
relicense" (prior to listing the signatures that have been collected in
the various threads so far), as well as stating that the relicense
permits sharing the code with LGPL Spice. See commits 74523b8 or
2b3bc6c for examples of commit text justifying a relicense.
On Mi, 2016-12-07 at 14:45 +0000, Peter Maydell wrote: > On 7 December 2016 at 12:51, Frediano Ziglio <fziglio@redhat.com> wrote: > > Signed-off-by: Frediano Ziglio <fziglio@redhat.com> > > --- > > ui/egl-helpers.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c > > index 79cee05..cd24568 100644 > > --- a/ui/egl-helpers.c > > +++ b/ui/egl-helpers.c > > @@ -1,3 +1,19 @@ > > +/* > > + * Copyright (C) 2015-2016 Gerd Hoffmann <kraxel@redhat.com> > > This looks a bit odd. Is the code copyright Gerd as an > individual, or Red Hat as a company? As individual, with email address added. Although it probably doesn't make that much sense these days to put the email into the source code as you can easily figure them from git log ... cheers, Gerd
On 7 December 2016 at 15:53, Gerd Hoffmann <kraxel@redhat.com> wrote: > On Mi, 2016-12-07 at 14:45 +0000, Peter Maydell wrote: >> On 7 December 2016 at 12:51, Frediano Ziglio <fziglio@redhat.com> wrote: >> > + * Copyright (C) 2015-2016 Gerd Hoffmann <kraxel@redhat.com> >> >> This looks a bit odd. Is the code copyright Gerd as an >> individual, or Red Hat as a company? > > As individual, with email address added. That's OK then -- I just wanted to check because very often contributions from company email addresses are work-for-hire that's copyright the company, not the employee. thanks -- PMM
diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 79cee05..cd24568 100644 --- a/ui/egl-helpers.c +++ b/ui/egl-helpers.c @@ -1,3 +1,19 @@ +/* + * Copyright (C) 2015-2016 Gerd Hoffmann <kraxel@redhat.com> + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, see <http://www.gnu.org/licenses/>. + */ #include "qemu/osdep.h" #include <glob.h> #include <dirent.h>
Signed-off-by: Frediano Ziglio <fziglio@redhat.com> --- ui/egl-helpers.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)