| Message ID | 1481268131-1264-1-git-send-email-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Dec 09, 2016 at 08:22:10AM +0100, Marek Szyprowski wrote: > "iis", "i2s_opclk0" and "i2s_opclk1" are standard clocks for Exynos4 I2S > hardware module, so they should be defined in .dtsi file not in the random > board .dts file. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > Changelog: > v2: > - added changes for exynos4412-itop-elite board > --- > arch/arm/boot/dts/exynos4.dtsi | 6 ++++-- > arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ---- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ---- > 3 files changed, 4 insertions(+), 10 deletions(-) For the reference: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 09, 2016 at 04:29:19PM +0200, Krzysztof Kozlowski wrote: > On Fri, Dec 09, 2016 at 08:22:10AM +0100, Marek Szyprowski wrote: > > "iis", "i2s_opclk0" and "i2s_opclk1" are standard clocks for Exynos4 I2S > > hardware module, so they should be defined in .dtsi file not in the random > > board .dts file. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > --- > > Changelog: > > v2: > > - added changes for exynos4412-itop-elite board > > --- > > arch/arm/boot/dts/exynos4.dtsi | 6 ++++-- > > arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ---- > > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ---- > > 3 files changed, 4 insertions(+), 10 deletions(-) Thanks, applied. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index c64737b..23d85601 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -64,8 +64,10 @@ i2s0: i2s@03830000 { compatible = "samsung,s5pv210-i2s"; reg = <0x03830000 0x100>; - clocks = <&clock_audss EXYNOS_I2S_BUS>; - clock-names = "iis"; + clocks = <&clock_audss EXYNOS_I2S_BUS>, + <&clock_audss EXYNOS_DOUT_AUD_BUS>, + <&clock_audss EXYNOS_SCLK_I2S>; + clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; #clock-cells = <1>; clock-output-names = "i2s_cdclk0"; dmas = <&pdma0 12>, <&pdma0 11>, <&pdma0 10>; diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts index 76d87f3..1ac9129 100644 --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts @@ -198,10 +198,6 @@ pinctrl-0 = <&i2s0_bus>; pinctrl-names = "default"; status = "okay"; - clocks = <&clock_audss EXYNOS_I2S_BUS>, - <&clock_audss EXYNOS_DOUT_AUD_BUS>, - <&clock_audss EXYNOS_SCLK_I2S>; - clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; }; &pinctrl_1 { diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index 8aa19ba..7815efd 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -503,10 +503,6 @@ pinctrl-0 = <&i2s0_bus>; pinctrl-names = "default"; status = "okay"; - clocks = <&clock_audss EXYNOS_I2S_BUS>, - <&clock_audss EXYNOS_DOUT_AUD_BUS>, - <&clock_audss EXYNOS_SCLK_I2S>; - clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; }; &mixer {
"iis", "i2s_opclk0" and "i2s_opclk1" are standard clocks for Exynos4 I2S hardware module, so they should be defined in .dtsi file not in the random board .dts file. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- Changelog: v2: - added changes for exynos4412-itop-elite board --- arch/arm/boot/dts/exynos4.dtsi | 6 ++++-- arch/arm/boot/dts/exynos4412-itop-elite.dts | 4 ---- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ---- 3 files changed, 4 insertions(+), 10 deletions(-)