| Message ID | 20161206025321.1792-3-andrew@aj.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Dec 06, 2016 at 01:53:17PM +1100, Andrew Jeffery wrote: > Whilst describing a device and not a bus, simple-mfd is modelled on > simple-bus where child nodes are iterated and registered as platform > devices. Some complex devices, e.g. the Aspeed LPC controller, can > benefit from address space mapping such that child nodes can use the > regs property to describe their resources within the multi-function > device. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > --- > Documentation/devicetree/bindings/mfd/mfd.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) No objections to this, but this is all implied by having a reg property. Acked-by: Rob Herring <robh@kernel.org> Rob
On Fri, 2016-12-09 at 16:49 -0600, Rob Herring wrote: > On Tue, Dec 06, 2016 at 01:53:17PM +1100, Andrew Jeffery wrote: > > Whilst describing a device and not a bus, simple-mfd is modelled on > > simple-bus where child nodes are iterated and registered as platform > > devices. Some complex devices, e.g. the Aspeed LPC controller, can > > benefit from address space mapping such that child nodes can use the > > regs property to describe their resources within the multi-function > > device. > > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> > > --- > > Documentation/devicetree/bindings/mfd/mfd.txt | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > No objections to this, but this is all implied by having a reg property. Thanks for clarifying. I wasn't sure so I wrote the patch with the thought that we could drop it if it wasn't necessary. Regardless, I think being explicit about the properties is nice. > > Acked-by: Rob Herring <robh@kernel.org> Thanks, Andrew > > Rob
On Tue, 06 Dec 2016, Andrew Jeffery wrote: > Whilst describing a device and not a bus, simple-mfd is modelled on > simple-bus where child nodes are iterated and registered as platform > devices. Some complex devices, e.g. the Aspeed LPC controller, can > benefit from address space mapping such that child nodes can use the > regs property to describe their resources within the multi-function > device. > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Applied with Acks, thanks. > --- > Documentation/devicetree/bindings/mfd/mfd.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mfd.txt b/Documentation/devicetree/bindings/mfd/mfd.txt > index f1fceeda12f1..bcb6abb9d413 100644 > --- a/Documentation/devicetree/bindings/mfd/mfd.txt > +++ b/Documentation/devicetree/bindings/mfd/mfd.txt > @@ -25,6 +25,16 @@ Optional properties: > be used. In the latter case the child devices will be determined by the > operating system. > > +- ranges: Describes the address mapping relationship to the parent. Should set > + the child's base address to 0, the physical address within parent's address > + space, and the length of the address map. > + > +- #address-cells: Specifies the number of cells used to represent physical base > + addresses. Must be present if ranges is used. > + > +- #size-cells: Specifies the number of cells used to represent the size of an > + address. Must be present if ranges is used. > + > Example: > > foo@1000 {
diff --git a/Documentation/devicetree/bindings/mfd/mfd.txt b/Documentation/devicetree/bindings/mfd/mfd.txt index f1fceeda12f1..bcb6abb9d413 100644 --- a/Documentation/devicetree/bindings/mfd/mfd.txt +++ b/Documentation/devicetree/bindings/mfd/mfd.txt @@ -25,6 +25,16 @@ Optional properties: be used. In the latter case the child devices will be determined by the operating system. +- ranges: Describes the address mapping relationship to the parent. Should set + the child's base address to 0, the physical address within parent's address + space, and the length of the address map. + +- #address-cells: Specifies the number of cells used to represent physical base + addresses. Must be present if ranges is used. + +- #size-cells: Specifies the number of cells used to represent the size of an + address. Must be present if ranges is used. + Example: foo@1000 {
Whilst describing a device and not a bus, simple-mfd is modelled on simple-bus where child nodes are iterated and registered as platform devices. Some complex devices, e.g. the Aspeed LPC controller, can benefit from address space mapping such that child nodes can use the regs property to describe their resources within the multi-function device. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- Documentation/devicetree/bindings/mfd/mfd.txt | 10 ++++++++++ 1 file changed, 10 insertions(+)