| Message ID | 20161213152252.53749-4-icenowy@aosc.xyz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Dec 13, 2016 at 11:22:49PM +0800, Icenowy Zheng wrote: > A "cpu0" label is needed on cpu@0 for cpufreq-dt to work. > > Add such a label, in order to prepare for cpufreq support of A23/33. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> Applied, thanks! Maxime
On 13/12/16 15:22, Icenowy Zheng wrote: > A "cpu0" label is needed on cpu@0 for cpufreq-dt to work. > IIUC any label should be fine and I don't see anything in the driver looking for such label name. All I see is it looks for cpu0 regulator for *legacy* DTs > Add such a label, in order to prepare for cpufreq support of A23/33. > You need this as you add the same label in the following patches. The commit message sounds like cpufreq-dt search for that label by name.
On Wed, Dec 14, 2016 at 12:09 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > On 13/12/16 15:22, Icenowy Zheng wrote: >> A "cpu0" label is needed on cpu@0 for cpufreq-dt to work. >> > > IIUC any label should be fine and I don't see anything in the driver > looking for such label name. All I see is it looks for cpu0 regulator > for *legacy* DTs > >> Add such a label, in order to prepare for cpufreq support of A23/33. >> > > You need this as you add the same label in the following patches. The > commit message sounds like cpufreq-dt search for that label by name. I think a more proper explanation would be: The cpu's supply regulator is specified at the board level, hence we need to add a label to it to reference it without replicating the whole tree structure. ChenYu
On 13/12/16 16:31, Chen-Yu Tsai wrote: > On Wed, Dec 14, 2016 at 12:09 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: >> >> >> On 13/12/16 15:22, Icenowy Zheng wrote: >>> A "cpu0" label is needed on cpu@0 for cpufreq-dt to work. >>> >> >> IIUC any label should be fine and I don't see anything in the driver >> looking for such label name. All I see is it looks for cpu0 regulator >> for *legacy* DTs >> >>> Add such a label, in order to prepare for cpufreq support of A23/33. >>> >> >> You need this as you add the same label in the following patches. The >> commit message sounds like cpufreq-dt search for that label by name. > > I think a more proper explanation would be: > > The cpu's supply regulator is specified at the board level, hence we > need to add a label to it to reference it without replicating the whole > tree structure. Thanks for clarifying, was confused based on the commit log.
diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi index 817747f41288..5931cc4d1567 100644 --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi @@ -84,7 +84,7 @@ #address-cells = <1>; #size-cells = <0>; - cpu@0 { + cpu0: cpu@0 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <0>;
A "cpu0" label is needed on cpu@0 for cpufreq-dt to work. Add such a label, in order to prepare for cpufreq support of A23/33. Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> --- arch/arm/boot/dts/sun8i-a23-a33.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)