| Message ID | 20161213130937.25655-1-emil.l.velikov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 13 Dec 2016, Emil Velikov <emil.l.velikov@gmail.com> wrote: > Just set the rules automatically rather than asking each contributor to > update thing locally. > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > --- > autogen.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/autogen.sh b/autogen.sh > index c896097..e936f04 100755 > --- a/autogen.sh > +++ b/autogen.sh > @@ -9,6 +9,12 @@ cd "$srcdir" > autoreconf --force --verbose --install || exit 1 > cd "$ORIGDIR" || exit $? > > +git config --local --get format.subjectPrefix || > + git config --local format.subjectPrefix "PATCH libdrm" > + > +git config --local --get sendemail.to || > + git config --local sendemail.to "dri-devel@lists.freedesktop.org" > + So I don't really play with libdrm source much, but can you expect this to only be run in a git repo? How about source/distro/tarball releases? BR, Jani. > if test -z "$NOCONFIGURE"; then > "$srcdir"/configure "$@" > fi
On Tuesday, 2016-12-13 16:16:50 +0200, Jani Nikula wrote: > On Tue, 13 Dec 2016, Emil Velikov <emil.l.velikov@gmail.com> wrote: > > Just set the rules automatically rather than asking each contributor to > > update thing locally. > > > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > > --- > > autogen.sh | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/autogen.sh b/autogen.sh > > index c896097..e936f04 100755 > > --- a/autogen.sh > > +++ b/autogen.sh > > @@ -9,6 +9,12 @@ cd "$srcdir" > > autoreconf --force --verbose --install || exit 1 > > cd "$ORIGDIR" || exit $? > > > > +git config --local --get format.subjectPrefix || > > + git config --local format.subjectPrefix "PATCH libdrm" > > + > > +git config --local --get sendemail.to || > > + git config --local sendemail.to "dri-devel@lists.freedesktop.org" > > + > > So I don't really play with libdrm source much, but can you expect this > to only be run in a git repo? How about source/distro/tarball releases? These will print an error like this and not do anything, so it should be fine: error: could not lock config file .git/config: No such file or directory These errors should be hidden though, as we don't care about such failures, and the config reads should also be silenced as they will print the previously set values. With that fixed: Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> > > BR, > Jani. > > > if test -z "$NOCONFIGURE"; then > > "$srcdir"/configure "$@" > > fi > > -- > Jani Nikula, Intel Open Source Technology Center
On 13 December 2016 at 15:42, Eric Engestrom <eric.engestrom@imgtec.com> wrote: > On Tuesday, 2016-12-13 16:16:50 +0200, Jani Nikula wrote: >> On Tue, 13 Dec 2016, Emil Velikov <emil.l.velikov@gmail.com> wrote: >> > Just set the rules automatically rather than asking each contributor to >> > update thing locally. >> > >> > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> >> > --- >> > autogen.sh | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git a/autogen.sh b/autogen.sh >> > index c896097..e936f04 100755 >> > --- a/autogen.sh >> > +++ b/autogen.sh >> > @@ -9,6 +9,12 @@ cd "$srcdir" >> > autoreconf --force --verbose --install || exit 1 >> > cd "$ORIGDIR" || exit $? >> > >> > +git config --local --get format.subjectPrefix || >> > + git config --local format.subjectPrefix "PATCH libdrm" >> > + >> > +git config --local --get sendemail.to || >> > + git config --local sendemail.to "dri-devel@lists.freedesktop.org" >> > + >> >> So I don't really play with libdrm source much, but can you expect this >> to only be run in a git repo? How about source/distro/tarball releases? > > These will print an error like this and not do anything, so it should be > fine: > error: could not lock config file .git/config: No such file or directory > > These errors should be hidden though, as we don't care about such > failures, and the config reads should also be silenced as they will > print the previously set values. > > With that fixed: > Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com> > Actually we don't ship autogen.sh within the tarball, but regardless. With a simple "2>/dev/null" things seems to be fine ... Thanks Emil P.S. I wonder if we really shouldn't do this for wayland/weston, Xorg, and dozens of others ;-)
On 13/12/16 10:09 PM, Emil Velikov wrote: > Just set the rules automatically rather than asking each contributor to > update thing locally. > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> > --- > autogen.sh | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/autogen.sh b/autogen.sh > index c896097..e936f04 100755 > --- a/autogen.sh > +++ b/autogen.sh > @@ -9,6 +9,12 @@ cd "$srcdir" > autoreconf --force --verbose --install || exit 1 > cd "$ORIGDIR" || exit $? > > +git config --local --get format.subjectPrefix || > + git config --local format.subjectPrefix "PATCH libdrm" > + > +git config --local --get sendemail.to || > + git config --local sendemail.to "dri-devel@lists.freedesktop.org" This is nice in general, but e.g. patches for the amdgpu/radeon subdirectories should go to the amd-gfx list instead, and possibly also have a different subject prefix. But maybe this is a good starting point anyway.
On 14 December 2016 at 07:04, Michel Dänzer <michel@daenzer.net> wrote: > On 13/12/16 10:09 PM, Emil Velikov wrote: >> Just set the rules automatically rather than asking each contributor to >> update thing locally. >> >> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> >> --- >> autogen.sh | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/autogen.sh b/autogen.sh >> index c896097..e936f04 100755 >> --- a/autogen.sh >> +++ b/autogen.sh >> @@ -9,6 +9,12 @@ cd "$srcdir" >> autoreconf --force --verbose --install || exit 1 >> cd "$ORIGDIR" || exit $? >> >> +git config --local --get format.subjectPrefix || >> + git config --local format.subjectPrefix "PATCH libdrm" >> + >> +git config --local --get sendemail.to || >> + git config --local sendemail.to "dri-devel@lists.freedesktop.org" > > This is nice in general, but e.g. patches for the amdgpu/radeon > subdirectories should go to the amd-gfx list instead, and possibly also > have a different subject prefix. But maybe this is a good starting point > anyway. > Fully agreed. For now it's ~ reasonable, but we might want something better for the future. Thanks Emil
diff --git a/autogen.sh b/autogen.sh index c896097..e936f04 100755 --- a/autogen.sh +++ b/autogen.sh @@ -9,6 +9,12 @@ cd "$srcdir" autoreconf --force --verbose --install || exit 1 cd "$ORIGDIR" || exit $? +git config --local --get format.subjectPrefix || + git config --local format.subjectPrefix "PATCH libdrm" + +git config --local --get sendemail.to || + git config --local sendemail.to "dri-devel@lists.freedesktop.org" + if test -z "$NOCONFIGURE"; then "$srcdir"/configure "$@" fi
Just set the rules automatically rather than asking each contributor to update thing locally. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> --- autogen.sh | 6 ++++++ 1 file changed, 6 insertions(+)