| Message ID | 20161214145724.42745-1-manu@bidouilliste.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 14, 2016 at 03:57:24PM +0100, Emmanuel Vadot wrote: > The node name for the power seq pin is mmc2@0 like the mmc2_pins_a one. > This makes the original node (mmc2_pins_a) scrapped out of the dtb and > result in a unusable eMMC if U-Boot didn't configured the pins to the > correct functions. > > Changes since v1: > * Rename the node mmc2-rst-pin That changelog should be after the ---. Removed it and applied. Thanks! Maxime
Hi Maxime, On Wed, 14 Dec 2016 16:30:13 +0100 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Wed, Dec 14, 2016 at 03:57:24PM +0100, Emmanuel Vadot wrote: > > The node name for the power seq pin is mmc2@0 like the mmc2_pins_a one. > > This makes the original node (mmc2_pins_a) scrapped out of the dtb and > > result in a unusable eMMC if U-Boot didn't configured the pins to the > > correct functions. > > > > Changes since v1: > > * Rename the node mmc2-rst-pin > > That changelog should be after the ---. Removed it and applied. > > Thanks! > Maxime Sorry, still kinda new at doing patches for Linux, will be more carefull next time. Quick question, when you say applied, applied where exactly ? I had a quick look at your branches on git.kernel.org didn't find anything. Thanks.
On Thu, Dec 15, 2016 at 12:35:33PM +0100, Emmanuel Vadot wrote: > > Hi Maxime, > > On Wed, 14 Dec 2016 16:30:13 +0100 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > On Wed, Dec 14, 2016 at 03:57:24PM +0100, Emmanuel Vadot wrote: > > > The node name for the power seq pin is mmc2@0 like the mmc2_pins_a one. > > > This makes the original node (mmc2_pins_a) scrapped out of the dtb and > > > result in a unusable eMMC if U-Boot didn't configured the pins to the > > > correct functions. > > > > > > Changes since v1: > > > * Rename the node mmc2-rst-pin > > > > That changelog should be after the ---. Removed it and applied. > > > > Thanks! > > Maxime > > Sorry, still kinda new at doing patches for Linux, will be more > carefull next time. > Quick question, when you say applied, applied where exactly ? I had a > quick look at your branches on git.kernel.org didn't find anything. In general, my tree on kernel.org. In this case, my local tree for now. We're right in the middle of the merge window for 4.10, so in order not to pollute next and not to confuse everyone (or rebasing a branch at some point), I just gather the patches here. I'll publish a branch based on 4.10 as soon as 4.10-rc1 is released. Maxime
diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts index 5ea4915..10d3074 100644 --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts @@ -56,7 +56,7 @@ }; &pio { - mmc2_pins_nrst: mmc2@0 { + mmc2_pins_nrst: mmc2-rst-pin { allwinner,pins = "PC16"; allwinner,function = "gpio_out"; allwinner,drive = <SUN4I_PINCTRL_10_MA>;
The node name for the power seq pin is mmc2@0 like the mmc2_pins_a one. This makes the original node (mmc2_pins_a) scrapped out of the dtb and result in a unusable eMMC if U-Boot didn't configured the pins to the correct functions. Changes since v1: * Rename the node mmc2-rst-pin Signed-off-by: Emmanuel Vadot <manu@bidouilliste.com> --- arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)