| Message ID | 1482064022-8998-1-git-send-email-ykaneko0929@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Kaneko-san, On Sun, Dec 18, 2016 at 1:27 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com> > > This patch adds support for r8a7796. > > Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > --- > > This patch is based on the next branch of the pci tree. > > Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + > drivers/pci/host/pcie-rcar.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt > index eee518d..34712d6 100644 > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -6,6 +6,7 @@ compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; > "renesas,pcie-r8a7791" for the R8A7791 SoC; > "renesas,pcie-r8a7793" for the R8A7793 SoC; > "renesas,pcie-r8a7795" for the R8A7795 SoC; > + "renesas,pcie-r8a7796" for the R8A7796 SoC; > "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. > "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > index aca85be..02e5777 100644 > --- a/drivers/pci/host/pcie-rcar.c > +++ b/drivers/pci/host/pcie-rcar.c > @@ -1078,6 +1078,7 @@ static int rcar_pcie_parse_map_dma_ranges(struct rcar_pcie *pcie, > { .compatible = "renesas,pcie-rcar-gen2", > .data = rcar_pcie_hw_init_gen2 }, > { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, > + { .compatible = "renesas,pcie-r8a7796", .data = rcar_pcie_hw_init }, > { .compatible = "renesas,pcie-rcar-gen3", .data = rcar_pcie_hw_init }, > {}, Given the driver already matches against "renesas,pcie-rcar-gen3", and mainline arch/arm64/boot/dts/renesas/r8a7796.dtsi doesn't have pcie nodes yet, I think there's no need to update the driver, only the bindings. Hence if you drop the last chunk, you can add my Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, Thanks for your review. 2016-12-19 18:49 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: > Hi Kaneko-san, > > On Sun, Dec 18, 2016 at 1:27 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: >> From: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com> >> >> This patch adds support for r8a7796. >> >> Signed-off-by: Harunobu Kurokawa <harunobu.kurokawa.dn@renesas.com> >> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> >> --- >> >> This patch is based on the next branch of the pci tree. >> >> Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + >> drivers/pci/host/pcie-rcar.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt >> index eee518d..34712d6 100644 >> --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt >> +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt >> @@ -6,6 +6,7 @@ compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; >> "renesas,pcie-r8a7791" for the R8A7791 SoC; >> "renesas,pcie-r8a7793" for the R8A7793 SoC; >> "renesas,pcie-r8a7795" for the R8A7795 SoC; >> + "renesas,pcie-r8a7796" for the R8A7796 SoC; >> "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. >> "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. >> >> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c >> index aca85be..02e5777 100644 >> --- a/drivers/pci/host/pcie-rcar.c >> +++ b/drivers/pci/host/pcie-rcar.c >> @@ -1078,6 +1078,7 @@ static int rcar_pcie_parse_map_dma_ranges(struct rcar_pcie *pcie, >> { .compatible = "renesas,pcie-rcar-gen2", >> .data = rcar_pcie_hw_init_gen2 }, >> { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, >> + { .compatible = "renesas,pcie-r8a7796", .data = rcar_pcie_hw_init }, >> { .compatible = "renesas,pcie-rcar-gen3", .data = rcar_pcie_hw_init }, >> {}, > > Given the driver already matches against "renesas,pcie-rcar-gen3", > and mainline arch/arm64/boot/dts/renesas/r8a7796.dtsi doesn't have pcie > nodes yet, I think there's no need to update the driver, only the bindings. I agree with you. > > Hence if you drop the last chunk, you can add my > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> I will do it. Thanks, kaneko > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt index eee518d..34712d6 100644 --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt @@ -6,6 +6,7 @@ compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC; "renesas,pcie-r8a7791" for the R8A7791 SoC; "renesas,pcie-r8a7793" for the R8A7793 SoC; "renesas,pcie-r8a7795" for the R8A7795 SoC; + "renesas,pcie-r8a7796" for the R8A7796 SoC; "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device. "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c index aca85be..02e5777 100644 --- a/drivers/pci/host/pcie-rcar.c +++ b/drivers/pci/host/pcie-rcar.c @@ -1078,6 +1078,7 @@ static int rcar_pcie_parse_map_dma_ranges(struct rcar_pcie *pcie, { .compatible = "renesas,pcie-rcar-gen2", .data = rcar_pcie_hw_init_gen2 }, { .compatible = "renesas,pcie-r8a7795", .data = rcar_pcie_hw_init }, + { .compatible = "renesas,pcie-r8a7796", .data = rcar_pcie_hw_init }, { .compatible = "renesas,pcie-rcar-gen3", .data = rcar_pcie_hw_init }, {}, };