| Message ID | 1481933536-12844-4-git-send-email-axboe@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe <axboe@fb.com> ha scritto: > > We want to use it outside of blk-core.c. > Hi Jens, no hooks equivalent to elevator_init_icq_fn and elevator_exit_icq_fn are invoked. In particular, the second hook let bfq (as with cfq) know when it could finally exit the queue associated with the icq. I'm trying to figure out how to make it without these hooks/signals, but at no avail so far ... Thanks, Paolo > Signed-off-by: Jens Axboe <axboe@fb.com> > --- > block/blk-core.c | 16 ---------------- > block/blk.h | 16 ++++++++++++++++ > 2 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/block/blk-core.c b/block/blk-core.c > index 61ba08c58b64..92baea07acbc 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -1040,22 +1040,6 @@ static bool blk_rq_should_init_elevator(struct bio *bio) > } > > /** > - * rq_ioc - determine io_context for request allocation > - * @bio: request being allocated is for this bio (can be %NULL) > - * > - * Determine io_context to use for request allocation for @bio. May return > - * %NULL if %current->io_context doesn't exist. > - */ > -static struct io_context *rq_ioc(struct bio *bio) > -{ > -#ifdef CONFIG_BLK_CGROUP > - if (bio && bio->bi_ioc) > - return bio->bi_ioc; > -#endif > - return current->io_context; > -} > - > -/** > * __get_request - get a free request > * @rl: request list to allocate from > * @op: operation and flags > diff --git a/block/blk.h b/block/blk.h > index f46c0ac8ae3d..9a716b5925a4 100644 > --- a/block/blk.h > +++ b/block/blk.h > @@ -264,6 +264,22 @@ void ioc_clear_queue(struct request_queue *q); > int create_task_io_context(struct task_struct *task, gfp_t gfp_mask, int node); > > /** > + * rq_ioc - determine io_context for request allocation > + * @bio: request being allocated is for this bio (can be %NULL) > + * > + * Determine io_context to use for request allocation for @bio. May return > + * %NULL if %current->io_context doesn't exist. > + */ > +static inline struct io_context *rq_ioc(struct bio *bio) > +{ > +#ifdef CONFIG_BLK_CGROUP > + if (bio && bio->bi_ioc) > + return bio->bi_ioc; > +#endif > + return current->io_context; > +} > + > +/** > * create_io_context - try to create task->io_context > * @gfp_mask: allocation mask > * @node: allocation node > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/20/2016 03:12 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe <axboe@fb.com> ha scritto: >> >> We want to use it outside of blk-core.c. >> > > Hi Jens, > no hooks equivalent to elevator_init_icq_fn and elevator_exit_icq_fn > are invoked. In particular, the second hook let bfq (as with cfq) > know when it could finally exit the queue associated with the icq. > I'm trying to figure out how to make it without these hooks/signals, > but at no avail so far ... Yep, those need to be added.
On 12/20/2016 08:46 AM, Jens Axboe wrote: > On 12/20/2016 03:12 AM, Paolo Valente wrote: >> >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe <axboe@fb.com> ha scritto: >>> >>> We want to use it outside of blk-core.c. >>> >> >> Hi Jens, >> no hooks equivalent to elevator_init_icq_fn and elevator_exit_icq_fn >> are invoked. In particular, the second hook let bfq (as with cfq) >> know when it could finally exit the queue associated with the icq. >> I'm trying to figure out how to make it without these hooks/signals, >> but at no avail so far ... > > Yep, those need to be added. Done, pushed out.
diff --git a/block/blk-core.c b/block/blk-core.c index 61ba08c58b64..92baea07acbc 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1040,22 +1040,6 @@ static bool blk_rq_should_init_elevator(struct bio *bio) } /** - * rq_ioc - determine io_context for request allocation - * @bio: request being allocated is for this bio (can be %NULL) - * - * Determine io_context to use for request allocation for @bio. May return - * %NULL if %current->io_context doesn't exist. - */ -static struct io_context *rq_ioc(struct bio *bio) -{ -#ifdef CONFIG_BLK_CGROUP - if (bio && bio->bi_ioc) - return bio->bi_ioc; -#endif - return current->io_context; -} - -/** * __get_request - get a free request * @rl: request list to allocate from * @op: operation and flags diff --git a/block/blk.h b/block/blk.h index f46c0ac8ae3d..9a716b5925a4 100644 --- a/block/blk.h +++ b/block/blk.h @@ -264,6 +264,22 @@ void ioc_clear_queue(struct request_queue *q); int create_task_io_context(struct task_struct *task, gfp_t gfp_mask, int node); /** + * rq_ioc - determine io_context for request allocation + * @bio: request being allocated is for this bio (can be %NULL) + * + * Determine io_context to use for request allocation for @bio. May return + * %NULL if %current->io_context doesn't exist. + */ +static inline struct io_context *rq_ioc(struct bio *bio) +{ +#ifdef CONFIG_BLK_CGROUP + if (bio && bio->bi_ioc) + return bio->bi_ioc; +#endif + return current->io_context; +} + +/** * create_io_context - try to create task->io_context * @gfp_mask: allocation mask * @node: allocation node
We want to use it outside of blk-core.c. Signed-off-by: Jens Axboe <axboe@fb.com> --- block/blk-core.c | 16 ---------------- block/blk.h | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 16 deletions(-)