| Message ID | 1482131877-6097-3-git-send-email-andrew.smirnov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Remove 'fixed-link' nodes from DSA ports since they are not needed (they > are not limiting link's speed and the ports will be configured to their > maximux speed as a default) > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> With this patch, ports connected to revB's second switch stop working. Nikita
On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote: > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they > > are not limiting link's speed and the ports will be configured to their > > maximux speed as a default) > > > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > > With this patch, ports connected to revB's second switch stop working. This is probably because without a fixed-link node the phy-mode setting isn't applied by the driver. Best regards Uwe
On Wed, Dec 21, 2016 at 02:25:19PM +0100, Uwe Kleine-König wrote: > On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote: > > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they > > > are not limiting link's speed and the ports will be configured to their > > > maximux speed as a default) > > > > > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > > > > With this patch, ports connected to revB's second switch stop working. > > This is probably because without a fixed-link node the phy-mode setting > isn't applied by the driver. Yep, bad suggestion from me. If the phy-mode was not needed, then you can drop the fixed-link. With the phy-mode, you also need the fixed link. Sorry for the wasted time, Andrew
diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts index c0fc3f2..646c90c 100644 --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts @@ -97,10 +97,6 @@ phy-mode = "rgmii-txid"; link = <&switch1port6 &switch2port9>; - fixed-link { - speed = <1000>; - full-duplex; - }; }; port@6 { @@ -165,10 +161,6 @@ label = "dsa"; phy-mode = "rgmii-txid"; link = <&switch0port5>; - fixed-link { - speed = <1000>; - full-duplex; - }; }; }; mdio {
Remove 'fixed-link' nodes from DSA ports since they are not needed (they are not limiting link's speed and the ports will be configured to their maximux speed as a default) Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- Changes since v3: - None arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 8 -------- 1 file changed, 8 deletions(-)