diff mbox

IB/cma: Fix a race condition in iboe_addr_get_sgid()

Message ID 75d773f7-d8f2-a77d-6c7a-4991d71f0c9f@acm.org (mailing list archive)
State Accepted
Headers show

Commit Message

Bart Van Assche Dec. 19, 2016, 5 p.m. UTC 
From: Bart Van Assche <bart.vanassche@sandisk.com>

Code that dereferences the struct net_device ip_ptr member must be
protected with an in_dev_get() / in_dev_put() pair. Hence insert
calls to these functions.

Fixes: commit 7b85627b9f02 ("IB/cma: IBoE (RoCE) IP-based GID addressing")
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Moni Shoua <monis@mellanox.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Roland Dreier <roland@purestorage.com>
Cc: <stable@vger.kernel.org>
---
 include/rdma/ib_addr.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Doug Ledford Dec. 22, 2016, 4:40 p.m. UTC | #1 
On 12/19/2016 12:00 PM, Bart Van Assche wrote:
> From: Bart Van Assche <bart.vanassche@sandisk.com>
> 
> Code that dereferences the struct net_device ip_ptr member must be
> protected with an in_dev_get() / in_dev_put() pair. Hence insert
> calls to these functions.
> 
> Fixes: commit 7b85627b9f02 ("IB/cma: IBoE (RoCE) IP-based GID addressing")
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Reviewed-by: Moni Shoua <monis@mellanox.com>
> Cc: Or Gerlitz <ogerlitz@mellanox.com>
> Cc: Roland Dreier <roland@purestorage.com>
> Cc: <stable@vger.kernel.org>

Thanks, applied.
diff mbox

Patch

diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h
index 931a47ba4571..1beab5532035 100644
--- a/include/rdma/ib_addr.h
+++ b/include/rdma/ib_addr.h
@@ -205,10 +205,12 @@  static inline void iboe_addr_get_sgid(struct rdma_dev_addr *dev_addr,
 
 	dev = dev_get_by_index(&init_net, dev_addr->bound_dev_if);
 	if (dev) {
-		ip4 = (struct in_device *)dev->ip_ptr;
-		if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address)
+		ip4 = in_dev_get(dev);
+		if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address) {
 			ipv6_addr_set_v4mapped(ip4->ifa_list->ifa_address,
 					       (struct in6_addr *)gid);
+			in_dev_put(ip4);
+		}
 		dev_put(dev);
 	}
 }