| Message ID | 20161214085703.506-1-lokeshvutla@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Lokesh, On 14/12/16 10:57, Lokesh Vutla wrote: > Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") > added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies > to this file. But it missed adding voltage supplies to usb_phy, mmc, > dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply > phandles to these nodes in dra72-evm-tps65917.dtsi > > Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") > Reported-by: Carlos Hernandez <ceh@ti.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > Logs: > - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/ > - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/ > arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi > index ee6dac44edf1..e6df676886c0 100644 > --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi > +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi > @@ -132,3 +132,19 @@ > ti,palmas-long-press-seconds = <6>; > }; > }; > + > +&usb2_phy1 { > + phy-supply = <&ldo4_reg>; > +}; > + > +&usb2_phy2 { > + phy-supply = <&ldo4_reg>; > +}; > + > +&dss { > + vdda_video-supply = <&ldo5_reg>; > +}; > + > +&mmc1 { > + vmmc_aux-supply = <&ldo1_reg>; > +}; > Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration? If not I'd rather put this in the board dts files. cheers, -roger
On Wednesday 14 December 2016 04:30 PM, Roger Quadros wrote: > Lokesh, > > On 14/12/16 10:57, Lokesh Vutla wrote: >> Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") >> added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies >> to this file. But it missed adding voltage supplies to usb_phy, mmc, >> dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply >> phandles to these nodes in dra72-evm-tps65917.dtsi >> >> Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") >> Reported-by: Carlos Hernandez <ceh@ti.com> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> --- >> Logs: >> - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/ >> - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/ >> arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi >> index ee6dac44edf1..e6df676886c0 100644 >> --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi >> +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi >> @@ -132,3 +132,19 @@ >> ti,palmas-long-press-seconds = <6>; >> }; >> }; >> + >> +&usb2_phy1 { >> + phy-supply = <&ldo4_reg>; >> +}; >> + >> +&usb2_phy2 { >> + phy-supply = <&ldo4_reg>; >> +}; >> + >> +&dss { >> + vdda_video-supply = <&ldo5_reg>; >> +}; >> + >> +&mmc1 { >> + vmmc_aux-supply = <&ldo1_reg>; >> +}; >> > > Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration? > If not I'd rather put this in the board dts files. hmm..This debate already happened when creating dra72-evm-tps65917 file and concluded that all the common regulator stuff on dra72 evm revA,B,C should go in this file. Any new board which is not similar to dra72-evm will not be using this file. Thanks and regards, Lokesh > > cheers, > -roger >
On 14/12/16 14:35, Lokesh Vutla wrote: > > > On Wednesday 14 December 2016 04:30 PM, Roger Quadros wrote: >> Lokesh, >> >> On 14/12/16 10:57, Lokesh Vutla wrote: >>> Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") >>> added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies >>> to this file. But it missed adding voltage supplies to usb_phy, mmc, >>> dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply >>> phandles to these nodes in dra72-evm-tps65917.dtsi >>> >>> Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") >>> Reported-by: Carlos Hernandez <ceh@ti.com> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> >>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >>> --- >>> Logs: >>> - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/ >>> - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/ >>> arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi >>> index ee6dac44edf1..e6df676886c0 100644 >>> --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi >>> +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi >>> @@ -132,3 +132,19 @@ >>> ti,palmas-long-press-seconds = <6>; >>> }; >>> }; >>> + >>> +&usb2_phy1 { >>> + phy-supply = <&ldo4_reg>; >>> +}; >>> + >>> +&usb2_phy2 { >>> + phy-supply = <&ldo4_reg>; >>> +}; >>> + >>> +&dss { >>> + vdda_video-supply = <&ldo5_reg>; >>> +}; >>> + >>> +&mmc1 { >>> + vmmc_aux-supply = <&ldo1_reg>; >>> +}; >>> >> >> Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration? >> If not I'd rather put this in the board dts files. > > hmm..This debate already happened when creating dra72-evm-tps65917 file > and concluded that all the common regulator stuff on dra72 evm revA,B,C > should go in this file. Any new board which is not similar to dra72-evm > will not be using this file. OK, then it is fine. Thanks for clarifying. cheers, -roger
* Roger Quadros <rogerq@ti.com> [161214 04:46]: > On 14/12/16 14:35, Lokesh Vutla wrote: > > > > > > On Wednesday 14 December 2016 04:30 PM, Roger Quadros wrote: > >> Lokesh, > >> > >> On 14/12/16 10:57, Lokesh Vutla wrote: > >>> Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") > >>> added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies > >>> to this file. But it missed adding voltage supplies to usb_phy, mmc, > >>> dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply > >>> phandles to these nodes in dra72-evm-tps65917.dtsi > >>> > >>> Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") > >>> Reported-by: Carlos Hernandez <ceh@ti.com> > >>> Signed-off-by: Roger Quadros <rogerq@ti.com> > >>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > >>> --- > >>> Logs: > >>> - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/ > >>> - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/ > >>> arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++ > >>> 1 file changed, 16 insertions(+) > >>> > >>> diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi > >>> index ee6dac44edf1..e6df676886c0 100644 > >>> --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi > >>> +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi > >>> @@ -132,3 +132,19 @@ > >>> ti,palmas-long-press-seconds = <6>; > >>> }; > >>> }; > >>> + > >>> +&usb2_phy1 { > >>> + phy-supply = <&ldo4_reg>; > >>> +}; > >>> + > >>> +&usb2_phy2 { > >>> + phy-supply = <&ldo4_reg>; > >>> +}; > >>> + > >>> +&dss { > >>> + vdda_video-supply = <&ldo5_reg>; > >>> +}; > >>> + > >>> +&mmc1 { > >>> + vmmc_aux-supply = <&ldo1_reg>; > >>> +}; > >>> > >> > >> Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration? > >> If not I'd rather put this in the board dts files. > > > > hmm..This debate already happened when creating dra72-evm-tps65917 file > > and concluded that all the common regulator stuff on dra72 evm revA,B,C > > should go in this file. Any new board which is not similar to dra72-evm > > will not be using this file. > > OK, then it is fine. Thanks for clarifying. Applying into omap-for-v4.10/fixes thanks. Tony
diff --git a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi index ee6dac44edf1..e6df676886c0 100644 --- a/arch/arm/boot/dts/dra72-evm-tps65917.dtsi +++ b/arch/arm/boot/dts/dra72-evm-tps65917.dtsi @@ -132,3 +132,19 @@ ti,palmas-long-press-seconds = <6>; }; }; + +&usb2_phy1 { + phy-supply = <&ldo4_reg>; +}; + +&usb2_phy2 { + phy-supply = <&ldo4_reg>; +}; + +&dss { + vdda_video-supply = <&ldo5_reg>; +}; + +&mmc1 { + vmmc_aux-supply = <&ldo1_reg>; +};
Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies to this file. But it missed adding voltage supplies to usb_phy, mmc, dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply phandles to these nodes in dra72-evm-tps65917.dtsi Fixes: 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") Reported-by: Carlos Hernandez <ceh@ti.com> Signed-off-by: Roger Quadros <rogerq@ti.com> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- Logs: - DRA72-evm revC: http://pastebin.ubuntu.com/23627665/ - DRA72-evm revB: http://pastebin.ubuntu.com/23627658/ arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)