| Message ID | 20161216090625.2235668-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Fri, Dec 16, 2016 at 10:06:15AM +0100, Arnd Bergmann wrote: > s3c64xx_cpufreq_config_regulator is incorrectly annotated > as __init, since the caller is also not init: > > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() > > With modern gcc versions, the function gets inline, so we don't > see the warning, this only happens with gcc-4.6 and older. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 16-12-16, 10:06, Arnd Bergmann wrote: > s3c64xx_cpufreq_config_regulator is incorrectly annotated > as __init, since the caller is also not init: > > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() > > With modern gcc versions, the function gets inline, so we don't > see the warning, this only happens with gcc-4.6 and older. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c > index 176e84cc3991..0cb9040eca49 100644 > --- a/drivers/cpufreq/s3c64xx-cpufreq.c > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy, > } > > #ifdef CONFIG_REGULATOR > -static void __init s3c64xx_cpufreq_config_regulator(void) > +static void s3c64xx_cpufreq_config_regulator(void) > { > int count, v, i, found; > struct cpufreq_frequency_table *freq; Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote: > On 16-12-16, 10:06, Arnd Bergmann wrote: > > s3c64xx_cpufreq_config_regulator is incorrectly annotated > > as __init, since the caller is also not init: > > > > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() > > > > With modern gcc versions, the function gets inline, so we don't > > see the warning, this only happens with gcc-4.6 and older. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c > > index 176e84cc3991..0cb9040eca49 100644 > > --- a/drivers/cpufreq/s3c64xx-cpufreq.c > > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c > > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy, > > } > > > > #ifdef CONFIG_REGULATOR > > -static void __init s3c64xx_cpufreq_config_regulator(void) > > +static void s3c64xx_cpufreq_config_regulator(void) > > { > > int count, v, i, found; > > struct cpufreq_frequency_table *freq; > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Rafael, Are you going to pick it up? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 2, 2017 at 6:36 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote: >> On 16-12-16, 10:06, Arnd Bergmann wrote: >> > s3c64xx_cpufreq_config_regulator is incorrectly annotated >> > as __init, since the caller is also not init: >> > >> > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() >> > >> > With modern gcc versions, the function gets inline, so we don't >> > see the warning, this only happens with gcc-4.6 and older. >> > >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> > --- >> > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c >> > index 176e84cc3991..0cb9040eca49 100644 >> > --- a/drivers/cpufreq/s3c64xx-cpufreq.c >> > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c >> > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy, >> > } >> > >> > #ifdef CONFIG_REGULATOR >> > -static void __init s3c64xx_cpufreq_config_regulator(void) >> > +static void s3c64xx_cpufreq_config_regulator(void) >> > { >> > int count, v, i, found; >> > struct cpufreq_frequency_table *freq; >> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > Rafael, > Are you going to pick it up? I thought I did, didn't I? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 02, 2017 at 10:19:29PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 2, 2017 at 6:36 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Jan 02, 2017 at 12:39:03PM +0530, Viresh Kumar wrote: > >> On 16-12-16, 10:06, Arnd Bergmann wrote: > >> > s3c64xx_cpufreq_config_regulator is incorrectly annotated > >> > as __init, since the caller is also not init: > >> > > >> > WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() > >> > > >> > With modern gcc versions, the function gets inline, so we don't > >> > see the warning, this only happens with gcc-4.6 and older. > >> > > >> > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> > --- > >> > drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c > >> > index 176e84cc3991..0cb9040eca49 100644 > >> > --- a/drivers/cpufreq/s3c64xx-cpufreq.c > >> > +++ b/drivers/cpufreq/s3c64xx-cpufreq.c > >> > @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy, > >> > } > >> > > >> > #ifdef CONFIG_REGULATOR > >> > -static void __init s3c64xx_cpufreq_config_regulator(void) > >> > +static void s3c64xx_cpufreq_config_regulator(void) > >> > { > >> > int count, v, i, found; > >> > struct cpufreq_frequency_table *freq; > >> > >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > > > Rafael, > > Are you going to pick it up? > > I thought I did, didn't I? Right, you did. I missed that. Thanks! Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/s3c64xx-cpufreq.c b/drivers/cpufreq/s3c64xx-cpufreq.c index 176e84cc3991..0cb9040eca49 100644 --- a/drivers/cpufreq/s3c64xx-cpufreq.c +++ b/drivers/cpufreq/s3c64xx-cpufreq.c @@ -107,7 +107,7 @@ static int s3c64xx_cpufreq_set_target(struct cpufreq_policy *policy, } #ifdef CONFIG_REGULATOR -static void __init s3c64xx_cpufreq_config_regulator(void) +static void s3c64xx_cpufreq_config_regulator(void) { int count, v, i, found; struct cpufreq_frequency_table *freq;
s3c64xx_cpufreq_config_regulator is incorrectly annotated as __init, since the caller is also not init: WARNING: vmlinux.o(.text+0x92fe1c): Section mismatch in reference from the function s3c64xx_cpufreq_driver_init() to the function .init.text:s3c64xx_cpufreq_config_regulator() With modern gcc versions, the function gets inline, so we don't see the warning, this only happens with gcc-4.6 and older. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/cpufreq/s3c64xx-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)