| Message ID | E1cO4Vz-00005t-8n@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Russell, On lun., janv. 02 2017, Russell King <rmk+kernel@armlinux.org.uk> wrote: It would be nice to have some word here about this patch. Especially why we need it now. I guess it is for being less dependent on the initialization done by the bootloader but maybe you have other reasons. Thanks, Gregory > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > --- > arch/arm/boot/dts/armada-388-clearfog-base.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts > index f86e1876fb38..da788ea40717 100644 > --- a/arch/arm/boot/dts/armada-388-clearfog-base.dts > +++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts > @@ -74,7 +74,17 @@ > phy = <&phy1>; > }; > > +&gpio0 { > + phy1_reset { > + gpio-hog; > + gpios = <19 GPIO_ACTIVE_LOW>; > + output-low; > + line-name = "phy1-reset"; > + }; > +}; > + > &mdio { > + pinctrl-0 = <&mdio_pins µsom_phy_clk_pins &clearfog_phy_pins>; > phy1: ethernet-phy@1 { > /* > * Annoyingly, the marvell phy driver configures the LED > @@ -87,6 +97,11 @@ > }; > > &pinctrl { > + /* phy1 reset */ > + clearfog_phy_pins: clearfog-phy-pins { > + marvell,pins = "mpp19"; > + marvell,function = "gpio"; > + }; > rear_button_pins: rear-button-pins { > marvell,pins = "mpp44"; > marvell,function = "gpio"; > -- > 2.7.4 >
On Wed, Jan 04, 2017 at 05:26:08PM +0100, Gregory CLEMENT wrote: > Hi Russell, > > On lun., janv. 02 2017, Russell King <rmk+kernel@armlinux.org.uk> wrote: > > > It would be nice to have some word here about this patch. Especially why > we need it now. I guess it is for being less dependent on the > initialization done by the bootloader but maybe you have other reasons. I'm not sure I follow. This is adding it to the new platform, not the old one. I guess I should've rolled this into the patch creating the clearfog-base dts file, and this question wouldn't have come up. > > Thanks, > > Gregory > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > > --- > > arch/arm/boot/dts/armada-388-clearfog-base.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts > > index f86e1876fb38..da788ea40717 100644 > > --- a/arch/arm/boot/dts/armada-388-clearfog-base.dts > > +++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts > > @@ -74,7 +74,17 @@ > > phy = <&phy1>; > > }; > > > > +&gpio0 { > > + phy1_reset { > > + gpio-hog; > > + gpios = <19 GPIO_ACTIVE_LOW>; > > + output-low; > > + line-name = "phy1-reset"; > > + }; > > +}; > > + > > &mdio { > > + pinctrl-0 = <&mdio_pins µsom_phy_clk_pins &clearfog_phy_pins>; > > phy1: ethernet-phy@1 { > > /* > > * Annoyingly, the marvell phy driver configures the LED > > @@ -87,6 +97,11 @@ > > }; > > > > &pinctrl { > > + /* phy1 reset */ > > + clearfog_phy_pins: clearfog-phy-pins { > > + marvell,pins = "mpp19"; > > + marvell,function = "gpio"; > > + }; > > rear_button_pins: rear-button-pins { > > marvell,pins = "mpp44"; > > marvell,function = "gpio"; > > -- > > 2.7.4 > > > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com
Hi Russell King, On jeu., janv. 05 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: > On Wed, Jan 04, 2017 at 05:26:08PM +0100, Gregory CLEMENT wrote: >> Hi Russell, >> >> On lun., janv. 02 2017, Russell King <rmk+kernel@armlinux.org.uk> wrote: >> >> >> It would be nice to have some word here about this patch. Especially why >> we need it now. I guess it is for being less dependent on the >> initialization done by the bootloader but maybe you have other reasons. > > I'm not sure I follow. This is adding it to the new platform, not the > old one. I guess I should've rolled this into the patch creating the > clearfog-base dts file, and this question wouldn't have come up. > Indeed I missed the fact that it was on the new board as all the other patches were related to the common part. Do you agree that I squash this patch into the "ARM: dts: armada388-clearfog: add base model DTS file" patch? Thanks, Gregory >> >> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> >> > --- >> > arch/arm/boot/dts/armada-388-clearfog-base.dts | 15 +++++++++++++++ >> > 1 file changed, 15 insertions(+) >> > >> > diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > index f86e1876fb38..da788ea40717 100644 >> > --- a/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > +++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts >> > @@ -74,7 +74,17 @@ >> > phy = <&phy1>; >> > }; >> > >> > +&gpio0 { >> > + phy1_reset { >> > + gpio-hog; >> > + gpios = <19 GPIO_ACTIVE_LOW>; >> > + output-low; >> > + line-name = "phy1-reset"; >> > + }; >> > +}; >> > + >> > &mdio { >> > + pinctrl-0 = <&mdio_pins µsom_phy_clk_pins &clearfog_phy_pins>; >> > phy1: ethernet-phy@1 { >> > /* >> > * Annoyingly, the marvell phy driver configures the LED >> > @@ -87,6 +97,11 @@ >> > }; >> > >> > &pinctrl { >> > + /* phy1 reset */ >> > + clearfog_phy_pins: clearfog-phy-pins { >> > + marvell,pins = "mpp19"; >> > + marvell,function = "gpio"; >> > + }; >> > rear_button_pins: rear-button-pins { >> > marvell,pins = "mpp44"; >> > marvell,function = "gpio"; >> > -- >> > 2.7.4 >> > >> >> -- >> Gregory Clement, Free Electrons >> Kernel, drivers, real-time and embedded Linux >> development, consulting, training and support. >> http://free-electrons.com > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Jan 05, 2017 at 11:29:48AM +0100, Gregory CLEMENT wrote: > Hi Russell King, > > On jeu., janv. 05 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: > > > On Wed, Jan 04, 2017 at 05:26:08PM +0100, Gregory CLEMENT wrote: > >> Hi Russell, > >> > >> On lun., janv. 02 2017, Russell King <rmk+kernel@armlinux.org.uk> wrote: > >> > >> > >> It would be nice to have some word here about this patch. Especially why > >> we need it now. I guess it is for being less dependent on the > >> initialization done by the bootloader but maybe you have other reasons. > > > > I'm not sure I follow. This is adding it to the new platform, not the > > old one. I guess I should've rolled this into the patch creating the > > clearfog-base dts file, and this question wouldn't have come up. > > > > Indeed I missed the fact that it was on the new board as all the other > patches were related to the common part. > > Do you agree that I squash this patch into the "ARM: dts: > armada388-clearfog: add base model DTS file" patch? Yep, thanks.
Hi Russell King, On jeu., janv. 05 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: > On Thu, Jan 05, 2017 at 11:29:48AM +0100, Gregory CLEMENT wrote: >> Hi Russell King, >> >> On jeu., janv. 05 2017, Russell King - ARM Linux <linux@armlinux.org.uk> wrote: >> >> > On Wed, Jan 04, 2017 at 05:26:08PM +0100, Gregory CLEMENT wrote: >> >> Hi Russell, >> >> >> >> On lun., janv. 02 2017, Russell King <rmk+kernel@armlinux.org.uk> wrote: >> >> >> >> >> >> It would be nice to have some word here about this patch. Especially why >> >> we need it now. I guess it is for being less dependent on the >> >> initialization done by the bootloader but maybe you have other reasons. >> > >> > I'm not sure I follow. This is adding it to the new platform, not the >> > old one. I guess I should've rolled this into the patch creating the >> > clearfog-base dts file, and this question wouldn't have come up. >> > >> >> Indeed I missed the fact that it was on the new board as all the other >> patches were related to the common part. >> >> Do you agree that I squash this patch into the "ARM: dts: >> armada388-clearfog: add base model DTS file" patch? > > Yep, thanks. It's done and it is also part of mvebu/for-next now. Gregory > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net.
diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts index f86e1876fb38..da788ea40717 100644 --- a/arch/arm/boot/dts/armada-388-clearfog-base.dts +++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts @@ -74,7 +74,17 @@ phy = <&phy1>; }; +&gpio0 { + phy1_reset { + gpio-hog; + gpios = <19 GPIO_ACTIVE_LOW>; + output-low; + line-name = "phy1-reset"; + }; +}; + &mdio { + pinctrl-0 = <&mdio_pins µsom_phy_clk_pins &clearfog_phy_pins>; phy1: ethernet-phy@1 { /* * Annoyingly, the marvell phy driver configures the LED @@ -87,6 +97,11 @@ }; &pinctrl { + /* phy1 reset */ + clearfog_phy_pins: clearfog-phy-pins { + marvell,pins = "mpp19"; + marvell,function = "gpio"; + }; rear_button_pins: rear-button-pins { marvell,pins = "mpp44"; marvell,function = "gpio";
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> --- arch/arm/boot/dts/armada-388-clearfog-base.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)