| Message ID | 20170104123435.30740-4-jh80.chung@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Wed, Jan 04, 2017 at 09:34:33PM +0900, Jaehoon Chung wrote: > According to using PHY framework, updates the exynos5440-pcie binding. > For maintaining backward compatibility, leaves the current dt-binding. > (It should be deprecated.) > > Recommends to use the Phy Framework and "config" property to follow > the designware-pcie binding. > If you use the old way, can see "mssing *config* reg space" message. > Because the getting configuration space address from range is old way. > > NOTE: When use the "config" property, first name of 'reg-names' must be > set to "elbi". Otherwise driver can't maintain the backward capability. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > Changelog on V2: > - Describes more commit message > - Fixes the typos > - Adds the new example for using PHY framework > - Deprecated the old dt-binding description > - Removes 'phy-names' > > .../bindings/pci/samsung,exynos5440-pcie.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jaehoon, On Wednesday 04 January 2017 06:04 PM, Jaehoon Chung wrote: > According to using PHY framework, updates the exynos5440-pcie binding. > For maintaining backward compatibility, leaves the current dt-binding. > (It should be deprecated.) > > Recommends to use the Phy Framework and "config" property to follow > the designware-pcie binding. > If you use the old way, can see "mssing *config* reg space" message. > Because the getting configuration space address from range is old way. > > NOTE: When use the "config" property, first name of 'reg-names' must be > set to "elbi". Otherwise driver can't maintain the backward capability. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > Changelog on V2: > - Describes more commit message > - Fixes the typos > - Adds the new example for using PHY framework > - Deprecated the old dt-binding description > - Removes 'phy-names' > > .../bindings/pci/samsung,exynos5440-pcie.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt b/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt > index 4f9d23d..1d0af0e 100644 > --- a/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt > @@ -7,8 +7,19 @@ Required properties: > - compatible: "samsung,exynos5440-pcie" > - reg: base addresses and lengths of the pcie controller, > the phy controller, additional register for the phy controller. > + (Registers for the phy controller are DEPRECATED. > + Use the PHY framework.) > +- reg-names : First name should be set to "elbi". > + And use the "config" instead of getting the confgiruation address space > + from "ranges". > + NOTE: When use the "config" property, reg-names must be set. > - interrupts: A list of interrupt outputs for level interrupt, > pulse interrupt, special interrupt. > +- phys: From PHY binding. Phandle for the Generic PHY. > + Refer to Documentation/devicetree/bindings/phy/samsung-phy.txt > + > +Other common properties refer to > + Documentation/devicetree/binding/pci/designware-pcie.txt > > Example: > > @@ -54,6 +65,24 @@ SoC specific DT Entry: > num-lanes = <4>; > }; > > +With using PHY framework: > + pcie_phy0: pcie-phy@270000 { > + ... > + reg = <0x270000 0x1000>, <0x271000 0x40>; > + regn-names = "phy", "block"; typo: %s/regn-names/reg-names/ > + ... > + }; > + > + pcie@290000 { > + ... > + reg = <0x290000 0x1000>, <0x40000000 0x1000>; > + reg-names = "elbi", "config"; > + phys = <&pcie_phy0>; > + ranges = <0x81000000 0 0 0x60001000 0 0x00010000 > + 0x82000000 0 0x60011000 0x60011000 0 0x1ffef000>; > + ... > + }; > + > Board specific DT Entry: > > pcie@290000 { > Other than above one typo rest is looking fine. Once you address it, feel free to add Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com> Thanks, Pankaj Dubey -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jaehoon, On 01/04/2017 06:04 PM, Jaehoon Chung wrote: > According to using PHY framework, updates the exynos5440-pcie binding. > For maintaining backward compatibility, leaves the current dt-binding. > (It should be deprecated.) > > Recommends to use the Phy Framework and "config" property to follow > the designware-pcie binding. > If you use the old way, can see "mssing *config* reg space" message. > Because the getting configuration space address from range is old way. > > NOTE: When use the "config" property, first name of 'reg-names' must be > set to "elbi". Otherwise driver can't maintain the backward capability. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > Changelog on V2: > - Describes more commit message > - Fixes the typos > - Adds the new example for using PHY framework > - Deprecated the old dt-binding description > - Removes 'phy-names' > > .../bindings/pci/samsung,exynos5440-pcie.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt b/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt > index 4f9d23d..1d0af0e 100644 > --- a/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt > @@ -7,8 +7,19 @@ Required properties: > - compatible: "samsung,exynos5440-pcie" > - reg: base addresses and lengths of the pcie controller, > the phy controller, additional register for the phy controller. > + (Registers for the phy controller are DEPRECATED. > + Use the PHY framework.) > +- reg-names : First name should be set to "elbi". > + And use the "config" instead of getting the confgiruation address space > + from "ranges". > + NOTE: When use the "config" property, reg-names must be set. > - interrupts: A list of interrupt outputs for level interrupt, > pulse interrupt, special interrupt. > +- phys: From PHY binding. Phandle for the Generic PHY. > + Refer to Documentation/devicetree/bindings/phy/samsung-phy.txt > + > +Other common properties refer to > + Documentation/devicetree/binding/pci/designware-pcie.txt > > Example: > > @@ -54,6 +65,24 @@ SoC specific DT Entry: > num-lanes = <4>; > }; > > +With using PHY framework: > + pcie_phy0: pcie-phy@270000 { > + ... > + reg = <0x270000 0x1000>, <0x271000 0x40>; > + regn-names = "phy", "block"; > + ... > + }; > + > + pcie@290000 { > + ... > + reg = <0x290000 0x1000>, <0x40000000 0x1000>; > + reg-names = "elbi", "config"; > + phys = <&pcie_phy0>; > + ranges = <0x81000000 0 0 0x60001000 0 0x00010000 > + 0x82000000 0 0x60011000 0x60011000 0 0x1ffef000>; > + ... > + }; > + > Board specific DT Entry: > > pcie@290000 { > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt b/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt index 4f9d23d..1d0af0e 100644 --- a/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt +++ b/Documentation/devicetree/bindings/pci/samsung,exynos5440-pcie.txt @@ -7,8 +7,19 @@ Required properties: - compatible: "samsung,exynos5440-pcie" - reg: base addresses and lengths of the pcie controller, the phy controller, additional register for the phy controller. + (Registers for the phy controller are DEPRECATED. + Use the PHY framework.) +- reg-names : First name should be set to "elbi". + And use the "config" instead of getting the confgiruation address space + from "ranges". + NOTE: When use the "config" property, reg-names must be set. - interrupts: A list of interrupt outputs for level interrupt, pulse interrupt, special interrupt. +- phys: From PHY binding. Phandle for the Generic PHY. + Refer to Documentation/devicetree/bindings/phy/samsung-phy.txt + +Other common properties refer to + Documentation/devicetree/binding/pci/designware-pcie.txt Example: @@ -54,6 +65,24 @@ SoC specific DT Entry: num-lanes = <4>; }; +With using PHY framework: + pcie_phy0: pcie-phy@270000 { + ... + reg = <0x270000 0x1000>, <0x271000 0x40>; + regn-names = "phy", "block"; + ... + }; + + pcie@290000 { + ... + reg = <0x290000 0x1000>, <0x40000000 0x1000>; + reg-names = "elbi", "config"; + phys = <&pcie_phy0>; + ranges = <0x81000000 0 0 0x60001000 0 0x00010000 + 0x82000000 0 0x60011000 0x60011000 0 0x1ffef000>; + ... + }; + Board specific DT Entry: pcie@290000 {
According to using PHY framework, updates the exynos5440-pcie binding. For maintaining backward compatibility, leaves the current dt-binding. (It should be deprecated.) Recommends to use the Phy Framework and "config" property to follow the designware-pcie binding. If you use the old way, can see "mssing *config* reg space" message. Because the getting configuration space address from range is old way. NOTE: When use the "config" property, first name of 'reg-names' must be set to "elbi". Otherwise driver can't maintain the backward capability. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- Changelog on V2: - Describes more commit message - Fixes the typos - Adds the new example for using PHY framework - Deprecated the old dt-binding description - Removes 'phy-names' .../bindings/pci/samsung,exynos5440-pcie.txt | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+)