| Message ID | 1483675149-32598-2-git-send-email-jcsing.lee@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: > From: Chanwoo Choi <cw00.choi@samsung.com> > > This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. Please describe what is exactly wrong and how it affects the system/user. This is going to the fixes so it needs a good explanation. > > Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 7 ++++--- > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 10 ---------- > 2 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > index 3b5215c..e8971f4 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts > @@ -504,9 +504,9 @@ > }; > > ldo23_reg: LDO23 { > - regulator-name = "CAM_SEN_CORE_1.2V_AP"; > + regulator-name = "CAM_SEN_CORE_1.05V_AP"; > regulator-min-microvolt = <1050000>; > - regulator-max-microvolt = <1200000>; > + regulator-max-microvolt = <1050000>; > }; > > ldo24_reg: LDO24 { > @@ -516,9 +516,10 @@ > }; > > ldo25_reg: LDO25 { > - regulator-name = "CAM_SEN_A2.8V_AP"; > + regulator-name = "UNUSED_LDO25"; > regulator-min-microvolt = <2800000>; > regulator-max-microvolt = <2800000>; > + regulator-always-off; Don't add it. See my other patch. Best regards, Krzysztof > }; > > ldo26_reg: LDO26 { > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > index 1db4e7f..854c583 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts > @@ -18,16 +18,6 @@ > compatible = "samsung,tm2e", "samsung,exynos5433"; > }; > > -&ldo23_reg { > - regulator-name = "CAM_SEN_CORE_1.025V_AP"; > - regulator-max-microvolt = <1050000>; > -}; > - > -&ldo25_reg { > - regulator-name = "UNUSED_LDO25"; > - regulator-always-off; > -}; > - > &ldo31_reg { > regulator-name = "TSP_VDD_1.8V_AP"; > regulator-min-microvolt = <1800000>; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote: > On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: >> From: Chanwoo Choi <cw00.choi@samsung.com> >> >> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. > > Please describe what is exactly wrong and how it affects the > system/user. This is going to the fixes so it needs a good explanation. When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E. [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") After checking the highest version of schematic document of both TM2 and TM2E, there is no difference of ldo23/ldo25 on both TM2 and TM2E. - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. - ldo25 isn't used on TM2/TM2E. (not connected) Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board. this patch does not affect the operation to system/user. > >> >> Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Andi Shyti <andi.shyti@samsung.com> >> Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com> >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 7 ++++--- >> arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts | 10 ---------- >> 2 files changed, 4 insertions(+), 13 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index 3b5215c..e8971f4 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -504,9 +504,9 @@ >> }; >> >> ldo23_reg: LDO23 { >> - regulator-name = "CAM_SEN_CORE_1.2V_AP"; >> + regulator-name = "CAM_SEN_CORE_1.05V_AP"; >> regulator-min-microvolt = <1050000>; >> - regulator-max-microvolt = <1200000>; >> + regulator-max-microvolt = <1050000>; >> }; >> >> ldo24_reg: LDO24 { >> @@ -516,9 +516,10 @@ >> }; >> >> ldo25_reg: LDO25 { >> - regulator-name = "CAM_SEN_A2.8V_AP"; >> + regulator-name = "UNUSED_LDO25"; >> regulator-min-microvolt = <2800000>; >> regulator-max-microvolt = <2800000>; >> + regulator-always-off; > > Don't add it. See my other patch. OK. After completing the kernel booting, the unused regulators will be off. > > Best regards, > Krzysztof > >> }; >> >> ldo26_reg: LDO26 { >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> index 1db4e7f..854c583 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts >> @@ -18,16 +18,6 @@ >> compatible = "samsung,tm2e", "samsung,exynos5433"; >> }; >> >> -&ldo23_reg { >> - regulator-name = "CAM_SEN_CORE_1.025V_AP"; >> - regulator-max-microvolt = <1050000>; >> -}; >> - >> -&ldo25_reg { >> - regulator-name = "UNUSED_LDO25"; >> - regulator-always-off; >> -}; >> - >> &ldo31_reg { >> regulator-name = "TSP_VDD_1.8V_AP"; >> regulator-min-microvolt = <1800000>; >> -- >> 2.7.4 >> > > >
On Fri, Jan 06, 2017 at 04:20:52PM +0900, Chanwoo Choi wrote: > On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote: > > On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: > >> From: Chanwoo Choi <cw00.choi@samsung.com> > >> > >> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. > > > > Please describe what is exactly wrong and how it affects the > > system/user. This is going to the fixes so it needs a good explanation. > > When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E. > [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") > > After checking the highest version of schematic document of both TM2 and TM2E, > there is no difference of ldo23/ldo25 on both TM2 and TM2E. > - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. > - ldo25 isn't used on TM2/TM2E. (not connected) > > Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board. > this patch does not affect the operation to system/user. If it does not affect anyone (including TM2/TM2E) then this do not have to be a fix. Am I right? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2017년 01월 06일 17:50, Krzysztof Kozlowski wrote: > On Fri, Jan 06, 2017 at 04:20:52PM +0900, Chanwoo Choi wrote: >> On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote: >>> On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: >>>> From: Chanwoo Choi <cw00.choi@samsung.com> >>>> >>>> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. >>> >>> Please describe what is exactly wrong and how it affects the >>> system/user. This is going to the fixes so it needs a good explanation. >> >> When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E. >> [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") >> >> After checking the highest version of schematic document of both TM2 and TM2E, >> there is no difference of ldo23/ldo25 on both TM2 and TM2E. >> - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. >> - ldo25 isn't used on TM2/TM2E. (not connected) >> >> Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board. >> this patch does not affect the operation to system/user. > > If it does not affect anyone (including TM2/TM2E) then this do not have > to be a fix. Am I right? This patch does not affect the TM2/TM2E's operation because ldo23/25 are not used on TM2/TM2E. Just fix the wrong information.
On Fri, Jan 06, 2017 at 06:06:43PM +0900, Chanwoo Choi wrote: > On 2017년 01월 06일 17:50, Krzysztof Kozlowski wrote: > > On Fri, Jan 06, 2017 at 04:20:52PM +0900, Chanwoo Choi wrote: > >> On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote: > >>> On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote: > >>>> From: Chanwoo Choi <cw00.choi@samsung.com> > >>>> > >>>> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E. > >>> > >>> Please describe what is exactly wrong and how it affects the > >>> system/user. This is going to the fixes so it needs a good explanation. > >> > >> When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E. > >> [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board") > >> > >> After checking the highest version of schematic document of both TM2 and TM2E, > >> there is no difference of ldo23/ldo25 on both TM2 and TM2E. > >> - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong. > >> - ldo25 isn't used on TM2/TM2E. (not connected) > >> > >> Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board. > >> this patch does not affect the operation to system/user. > > > > If it does not affect anyone (including TM2/TM2E) then this do not have > > to be a fix. Am I right? > > This patch does not affect the TM2/TM2E's operation > because ldo23/25 are not used on TM2/TM2E. Just fix the wrong information. Ah, okay, thanks for explanation. Please just rebase on current next/dt64 (or for-next or just my https://patchwork.kernel.org/patch/9500153/) so the always-off property won't be copied. I'll take it then for v4.11. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts index 3b5215c..e8971f4 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts @@ -504,9 +504,9 @@ }; ldo23_reg: LDO23 { - regulator-name = "CAM_SEN_CORE_1.2V_AP"; + regulator-name = "CAM_SEN_CORE_1.05V_AP"; regulator-min-microvolt = <1050000>; - regulator-max-microvolt = <1200000>; + regulator-max-microvolt = <1050000>; }; ldo24_reg: LDO24 { @@ -516,9 +516,10 @@ }; ldo25_reg: LDO25 { - regulator-name = "CAM_SEN_A2.8V_AP"; + regulator-name = "UNUSED_LDO25"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; + regulator-always-off; }; ldo26_reg: LDO26 { diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts index 1db4e7f..854c583 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts @@ -18,16 +18,6 @@ compatible = "samsung,tm2e", "samsung,exynos5433"; }; -&ldo23_reg { - regulator-name = "CAM_SEN_CORE_1.025V_AP"; - regulator-max-microvolt = <1050000>; -}; - -&ldo25_reg { - regulator-name = "UNUSED_LDO25"; - regulator-always-off; -}; - &ldo31_reg { regulator-name = "TSP_VDD_1.8V_AP"; regulator-min-microvolt = <1800000>;