| Message ID | 20170107091651.10560-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello Krzysztof, I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :) On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: > Odroid U3 needs a power sequence for lan9730, if it was enabled by > bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device > is present on Odroid U3). > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > Do you think that makes sense to also enable GPIO_SYS for debugging purposes as you do in patch 3/4? In any case the patch looks good to me: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On Mon, Jan 9, 2017 at 6:24 PM, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > Hello Krzysztof, > > I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :) Ah, yes. > > On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: >> Odroid U3 needs a power sequence for lan9730, if it was enabled by >> bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device >> is present on Odroid U3). >> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> >> --- >> > > Do you think that makes sense to also enable GPIO_SYS for debugging > purposes as you do in patch 3/4? I like the GPIO_SYSFS interface because it is easy to use. However now, after your question, I found this: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-November/470154.html ARM/ARM64: defconfig: drop GPIO_SYSFS on multiplatforms ... so instead I will drop it from exynos_defconfig. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof, On 01/09/2017 02:38 PM, Krzysztof Kozlowski wrote: > On Mon, Jan 9, 2017 at 6:24 PM, Javier Martinez Canillas > <javier@osg.samsung.com> wrote: >> Hello Krzysztof, >> >> I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :) > > Ah, yes. > >> >> On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: >>> Odroid U3 needs a power sequence for lan9730, if it was enabled by >>> bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device >>> is present on Odroid U3). >>> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >>> >>> --- >>> >> >> Do you think that makes sense to also enable GPIO_SYS for debugging >> purposes as you do in patch 3/4? > > I like the GPIO_SYSFS interface because it is easy to use. However > now, after your question, I found this: > http://lists.infradead.org/pipermail/linux-arm-kernel/2016-November/470154.html > ARM/ARM64: defconfig: drop GPIO_SYSFS on multiplatforms > > ... so instead I will drop it from exynos_defconfig. > Right, I forgot that using the GPIO sysfs interface is discouraged now and the new chardev/ioctl based should be used instead. So it makes sense to drop it. > Best regards, > Krzysztof Best regards,
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index b01a43851294..8cc73e084b25 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -443,6 +443,7 @@ CONFIG_POWER_RESET_RMOBILE=y CONFIG_POWER_RESET_ST=y CONFIG_POWER_AVS=y CONFIG_ROCKCHIP_IODOMAIN=y +CONFIG_PWRSEQ_GENERIC=y CONFIG_SENSORS_IIO_HWMON=y CONFIG_SENSORS_LM90=y CONFIG_SENSORS_LM95245=y @@ -686,6 +687,7 @@ CONFIG_USB_DWC2=y CONFIG_USB_CHIPIDEA=y CONFIG_USB_CHIPIDEA_UDC=y CONFIG_USB_CHIPIDEA_HOST=y +CONFIG_USB_HSIC_USB3503=m CONFIG_AB8500_USB=y CONFIG_KEYSTONE_USB_PHY=y CONFIG_OMAP_USB3=y
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device is present on Odroid U3). Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Changes since v1 (v1 -> v1.1): 1. Enable also usb3503 driver. --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+)