diff mbox

[3/8] mmc-core: Use seq_puts() in mtf_testlist_show()

Message ID 5b8afe3b-0dee-0d95-c855-f0b93a95a072@users.sourceforge.net (mailing list archive)
State New, archived
Headers show

Commit Message

SF Markus Elfring Jan. 8, 2017, 9:45 p.m. UTC
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 8 Jan 2017 19:48:28 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: Prefer seq_puts to seq_printf

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/mmc/core/mmc_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij Jan. 9, 2017, 6:33 p.m. UTC | #1
On Sun, Jan 8, 2017 at 10:45 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 19:48:28 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: Prefer seq_puts to seq_printf
>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shawn Lin Jan. 10, 2017, 8:41 a.m. UTC | #2
On 2017/1/9 5:45, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 8 Jan 2017 19:48:28 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: Prefer seq_puts to seq_printf

it saves some lock time,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

>
> Thus fix the affected source code place.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/mmc/core/mmc_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 2f838a13a904..848f4f30e343 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -3163,7 +3163,7 @@ static int mtf_testlist_show(struct seq_file *sf, void *data)
>
>  	mutex_lock(&mmc_test_lock);
>
> -	seq_printf(sf, "0:\tRun all tests\n");
> +	seq_puts(sf, "0:\tRun all tests\n");
>  	for (i = 0; i < ARRAY_SIZE(mmc_test_cases); i++)
>  		seq_printf(sf, "%d:\t%s\n", i+1, mmc_test_cases[i].name);
>
>
diff mbox

Patch

diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
index 2f838a13a904..848f4f30e343 100644
--- a/drivers/mmc/core/mmc_test.c
+++ b/drivers/mmc/core/mmc_test.c
@@ -3163,7 +3163,7 @@  static int mtf_testlist_show(struct seq_file *sf, void *data)
 
 	mutex_lock(&mmc_test_lock);
 
-	seq_printf(sf, "0:\tRun all tests\n");
+	seq_puts(sf, "0:\tRun all tests\n");
 	for (i = 0; i < ARRAY_SIZE(mmc_test_cases); i++)
 		seq_printf(sf, "%d:\t%s\n", i+1, mmc_test_cases[i].name);