| Message ID | 20170109162449.5012-2-abailon@baylibre.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hello. On 01/09/2017 07:24 PM, Alexandre Bailon wrote: > This adds the device tree node for the cppi41 dma > used by the usb otg controller present in the da850 family of SoC's. > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > --- > arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 104155d..d6b406a 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -403,6 +403,22 @@ > phy-names = "usb-phy"; > status = "disabled"; > }; > + cppi41dma: dma-controller@201000 { > + compatible = "ti,da8xx-cppi41"; > + reg = <0x200000 0x1000 I don't remember any DA8xx glue regs having to do with the CPPI 4.1... > + 0x201000 0x1000 > + 0x202000 0x1000 > + 0x204000 0x4000>; > + reg-names = "glue", "controller", > + "scheduler", "queuemgr"; > + interrupts = <58>; > + interrupt-names = "glue"; > + #dma-cells = <2>; > + #dma-channels = <4>; > + #dma-requests = <256>; > + status = "disabled"; Why disabled? It doesn't use any external pins... [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/09/2017 07:26 PM, Sergei Shtylyov wrote: > Hello. > > On 01/09/2017 07:24 PM, Alexandre Bailon wrote: > >> This adds the device tree node for the cppi41 dma >> used by the usb otg controller present in the da850 family of SoC's. >> >> Signed-off-by: Alexandre Bailon <abailon@baylibre.com> >> --- >> arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 104155d..d6b406a 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -403,6 +403,22 @@ >> phy-names = "usb-phy"; >> status = "disabled"; >> }; >> + cppi41dma: dma-controller@201000 { >> + compatible = "ti,da8xx-cppi41"; >> + reg = <0x200000 0x1000 > > I don't remember any DA8xx glue regs having to do with the CPPI 4.1... The CPPI 4.1 driver need it to manage the IRQ. > >> + 0x201000 0x1000 >> + 0x202000 0x1000 >> + 0x204000 0x4000>; >> + reg-names = "glue", "controller", >> + "scheduler", "queuemgr"; >> + interrupts = <58>; >> + interrupt-names = "glue"; >> + #dma-cells = <2>; >> + #dma-channels = <4>; >> + #dma-requests = <256>; >> + status = "disabled"; > > Why disabled? It doesn't use any external pins... Will fix it. > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/09/2017 12:26 PM, Sergei Shtylyov wrote: > Hello. > > On 01/09/2017 07:24 PM, Alexandre Bailon wrote: > >> This adds the device tree node for the cppi41 dma >> used by the usb otg controller present in the da850 family of SoC's. >> >> Signed-off-by: Alexandre Bailon <abailon@baylibre.com> >> --- >> arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 104155d..d6b406a 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -403,6 +403,22 @@ >> phy-names = "usb-phy"; >> status = "disabled"; >> }; >> + cppi41dma: dma-controller@201000 { >> + compatible = "ti,da8xx-cppi41"; >> + reg = <0x200000 0x1000 > > I don't remember any DA8xx glue regs having to do with the CPPI 4.1... > >> + 0x201000 0x1000 >> + 0x202000 0x1000 >> + 0x204000 0x4000>; >> + reg-names = "glue", "controller", >> + "scheduler", "queuemgr"; >> + interrupts = <58>; >> + interrupt-names = "glue"; >> + #dma-cells = <2>; >> + #dma-channels = <4>; >> + #dma-requests = <256>; >> + status = "disabled"; > > Why disabled? It doesn't use any external pins... Why enable it if musb node is not also enabled? > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/10/2017 07:15 PM, David Lechner wrote: >>> This adds the device tree node for the cppi41 dma >>> used by the usb otg controller present in the da850 family of SoC's. >>> >>> Signed-off-by: Alexandre Bailon <abailon@baylibre.com> >>> --- >>> arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >>> index 104155d..d6b406a 100644 >>> --- a/arch/arm/boot/dts/da850.dtsi >>> +++ b/arch/arm/boot/dts/da850.dtsi >>> @@ -403,6 +403,22 @@ >>> phy-names = "usb-phy"; >>> status = "disabled"; >>> }; >>> + cppi41dma: dma-controller@201000 { >>> + compatible = "ti,da8xx-cppi41"; >>> + reg = <0x200000 0x1000 >> >> I don't remember any DA8xx glue regs having to do with the CPPI 4.1... >> >>> + 0x201000 0x1000 >>> + 0x202000 0x1000 >>> + 0x204000 0x4000>; >>> + reg-names = "glue", "controller", >>> + "scheduler", "queuemgr"; >>> + interrupts = <58>; >>> + interrupt-names = "glue"; >>> + #dma-cells = <2>; >>> + #dma-channels = <4>; >>> + #dma-requests = <256>; >>> + status = "disabled"; >> >> Why disabled? It doesn't use any external pins... > > Why enable it if musb node is not also enabled? Well, it's a good point. >> [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 10 January 2017 07:15 PM, Alexandre Bailon wrote: > On 01/09/2017 07:26 PM, Sergei Shtylyov wrote: >>> + 0x201000 0x1000 >>> + 0x202000 0x1000 >>> + 0x204000 0x4000>; >>> + reg-names = "glue", "controller", >>> + "scheduler", "queuemgr"; >>> + interrupts = <58>; >>> + interrupt-names = "glue"; >>> + #dma-cells = <2>; >>> + #dma-channels = <4>; >>> + #dma-requests = <256>; >>> + status = "disabled"; >> >> Why disabled? It doesn't use any external pins... > Will fix it. Please keep it disabled. See the other thread on this. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 104155d..d6b406a 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -403,6 +403,22 @@ phy-names = "usb-phy"; status = "disabled"; }; + cppi41dma: dma-controller@201000 { + compatible = "ti,da8xx-cppi41"; + reg = <0x200000 0x1000 + 0x201000 0x1000 + 0x202000 0x1000 + 0x204000 0x4000>; + reg-names = "glue", "controller", + "scheduler", "queuemgr"; + interrupts = <58>; + interrupt-names = "glue"; + #dma-cells = <2>; + #dma-channels = <4>; + #dma-requests = <256>; + status = "disabled"; + + }; mdio: mdio@224000 { compatible = "ti,davinci_mdio"; #address-cells = <1>;
This adds the device tree node for the cppi41 dma used by the usb otg controller present in the da850 family of SoC's. Signed-off-by: Alexandre Bailon <abailon@baylibre.com> --- arch/arm/boot/dts/da850.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)