| Message ID | c394e52447ed45fff9672eb3e3bb6729bea87ee7.1484219137.git.jsarha@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/01/17 13:16, Jyri Sarha wrote: > From: Tomi Valkeinen <tomi.valkeinen@ti.com> > > SSD1306 needs VBAT when it is wired in charge pump configuration. This > patch adds support to the driver to enable VBAT regulator at init time. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > Reviewed-by: Roger Quadros <rogerq@ti.com> > Signed-off-by: Jyri Sarha <jsarha@ti.com> > --- > Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/ssd1307fb.txt b/Documentation/devicetree/bindings/display/ssd1307fb.txt > index 6617df6..209d931 100644 > --- a/Documentation/devicetree/bindings/display/ssd1307fb.txt > +++ b/Documentation/devicetree/bindings/display/ssd1307fb.txt > @@ -16,6 +16,7 @@ Required properties: > Optional properties: > - reset-gpios: The GPIO used to reset the OLED display, if available. See > Documentation/devicetree/bindings/gpio/gpio.txt for details. > + - vbat-supply: The supply for VBAT > - solomon,segment-no-remap: Display needs normal (non-inverted) data column > to segment mapping > - solomon,com-seq: Display uses sequential COM pin configuration > It's rather confusing to have two patches with identical subjects and descs (this and 4). And there's even an unrelated patch in between this and the driver change... Tomi
On 01/12/17 14:05, Tomi Valkeinen wrote: > On 12/01/17 13:16, Jyri Sarha wrote: >> From: Tomi Valkeinen <tomi.valkeinen@ti.com> >> >> SSD1306 needs VBAT when it is wired in charge pump configuration. This >> patch adds support to the driver to enable VBAT regulator at init time. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> >> Reviewed-by: Roger Quadros <rogerq@ti.com> >> Signed-off-by: Jyri Sarha <jsarha@ti.com> >> --- >> Documentation/devicetree/bindings/display/ssd1307fb.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/display/ssd1307fb.txt b/Documentation/devicetree/bindings/display/ssd1307fb.txt >> index 6617df6..209d931 100644 >> --- a/Documentation/devicetree/bindings/display/ssd1307fb.txt >> +++ b/Documentation/devicetree/bindings/display/ssd1307fb.txt >> @@ -16,6 +16,7 @@ Required properties: >> Optional properties: >> - reset-gpios: The GPIO used to reset the OLED display, if available. See >> Documentation/devicetree/bindings/gpio/gpio.txt for details. >> + - vbat-supply: The supply for VBAT >> - solomon,segment-no-remap: Display needs normal (non-inverted) data column >> to segment mapping >> - solomon,com-seq: Display uses sequential COM pin configuration >> > > It's rather confusing to have two patches with identical subjects and > descs (this and 4). And there's even an unrelated patch in between this > and the driver change... > Argh. I wonder how did this even happen. Something weird must have been going on... there is only one such patch in branch I cherry-picked these patches from. These last patches did not give me any errors and compiled fine, so did not look too carefully at the results. Anyway, I'll squash this into the earlier patch with the same subject in version 2 series. Best regards, Jyri -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/display/ssd1307fb.txt b/Documentation/devicetree/bindings/display/ssd1307fb.txt index 6617df6..209d931 100644 --- a/Documentation/devicetree/bindings/display/ssd1307fb.txt +++ b/Documentation/devicetree/bindings/display/ssd1307fb.txt @@ -16,6 +16,7 @@ Required properties: Optional properties: - reset-gpios: The GPIO used to reset the OLED display, if available. See Documentation/devicetree/bindings/gpio/gpio.txt for details. + - vbat-supply: The supply for VBAT - solomon,segment-no-remap: Display needs normal (non-inverted) data column to segment mapping - solomon,com-seq: Display uses sequential COM pin configuration