| Message ID | 1481142941-15616-3-git-send-email-loic.pallardy@st.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Loic, On 12/07/2016 02:35 PM, Loic Pallardy wrote: > To specify memory for remoteproc, we declare (dma_declare_coherent_memory()) > an area which is ioremap'ed to the vmalloc area. However, this address is > not a kernel address so virt_addr_valid(buf) fails. > > Signed-off-by: Ludovic Barre <ludovic.barre@st.com> > Signed-off-by: Loic Pallardy <loic.pallardy@st.com> I like this patch compared to the old RFC series from Edgar (from the same discussion pointed out in Wendy's RFC). With vrp->buf_size initialized properly, I have been able to use this patch to have rpmsg functional both with CMA pools in HIGHMEM as well as with using a device-specific carveout. Tested-by: Suman Anna <s-anna@ti.com> regards Suman > --- > drivers/rpmsg/virtio_rpmsg_bus.c | 29 ++++++++++++++++++++++++++--- > 1 file changed, 26 insertions(+), 3 deletions(-) > > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 1f6dfc6..0810d1f 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -195,6 +195,29 @@ static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, > }; > > /** > + * rpmsg_sg_init - initialize scatterlist according to cpu address location > + * @sg: scatterlist to fill > + * @cpu_addr: virtual address of the buffer > + * @len: buffer length > + * > + * An internal function filling scatterlist according to virtual address > + * location (in vmalloc or in kernel). > + */ > +static void > +rpmsg_sg_init(struct scatterlist *sg, void *cpu_addr, unsigned int len) > +{ > + if (is_vmalloc_addr(cpu_addr)) { > + sg_init_table(sg, 1); > + sg_set_page(sg, vmalloc_to_page(cpu_addr), len, > + offset_in_page(cpu_addr)); > + } else { > + WARN_ON(!virt_addr_valid(cpu_addr)); > + sg_init_one(sg, cpu_addr, len); > + } > +} > + > + > +/** > * __ept_release() - deallocate an rpmsg endpoint > * @kref: the ept's reference count > * > @@ -606,7 +629,7 @@ static int rpmsg_send_offchannel_raw(struct rpmsg_device *rpdev, > msg, sizeof(*msg) + msg->len, true); > #endif > > - sg_init_one(&sg, msg, sizeof(*msg) + len); > + rpmsg_sg_init(&sg, msg, sizeof(*msg) + len); > > mutex_lock(&vrp->tx_lock); > > @@ -731,7 +754,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, > dev_warn(dev, "msg received with no recipient\n"); > > /* publish the real size of the buffer */ > - sg_init_one(&sg, msg, vrp->buf_size); > + rpmsg_sg_init(&sg, msg, vrp->buf_size); > > /* add the buffer back to the remote processor's virtqueue */ > err = virtqueue_add_inbuf(vrp->rvq, &sg, 1, msg, GFP_KERNEL); > @@ -913,7 +936,7 @@ static int rpmsg_probe(struct virtio_device *vdev) > struct scatterlist sg; > void *cpu_addr = vrp->rbufs + i * vrp->buf_size; > > - sg_init_one(&sg, cpu_addr, vrp->buf_size); > + rpmsg_sg_init(&sg, cpu_addr, vrp->buf_size); > > err = virtqueue_add_inbuf(vrp->rvq, &sg, 1, cpu_addr, > GFP_KERNEL); > -- To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 1f6dfc6..0810d1f 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -195,6 +195,29 @@ static int virtio_rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, }; /** + * rpmsg_sg_init - initialize scatterlist according to cpu address location + * @sg: scatterlist to fill + * @cpu_addr: virtual address of the buffer + * @len: buffer length + * + * An internal function filling scatterlist according to virtual address + * location (in vmalloc or in kernel). + */ +static void +rpmsg_sg_init(struct scatterlist *sg, void *cpu_addr, unsigned int len) +{ + if (is_vmalloc_addr(cpu_addr)) { + sg_init_table(sg, 1); + sg_set_page(sg, vmalloc_to_page(cpu_addr), len, + offset_in_page(cpu_addr)); + } else { + WARN_ON(!virt_addr_valid(cpu_addr)); + sg_init_one(sg, cpu_addr, len); + } +} + + +/** * __ept_release() - deallocate an rpmsg endpoint * @kref: the ept's reference count * @@ -606,7 +629,7 @@ static int rpmsg_send_offchannel_raw(struct rpmsg_device *rpdev, msg, sizeof(*msg) + msg->len, true); #endif - sg_init_one(&sg, msg, sizeof(*msg) + len); + rpmsg_sg_init(&sg, msg, sizeof(*msg) + len); mutex_lock(&vrp->tx_lock); @@ -731,7 +754,7 @@ static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, dev_warn(dev, "msg received with no recipient\n"); /* publish the real size of the buffer */ - sg_init_one(&sg, msg, vrp->buf_size); + rpmsg_sg_init(&sg, msg, vrp->buf_size); /* add the buffer back to the remote processor's virtqueue */ err = virtqueue_add_inbuf(vrp->rvq, &sg, 1, msg, GFP_KERNEL); @@ -913,7 +936,7 @@ static int rpmsg_probe(struct virtio_device *vdev) struct scatterlist sg; void *cpu_addr = vrp->rbufs + i * vrp->buf_size; - sg_init_one(&sg, cpu_addr, vrp->buf_size); + rpmsg_sg_init(&sg, cpu_addr, vrp->buf_size); err = virtqueue_add_inbuf(vrp->rvq, &sg, 1, cpu_addr, GFP_KERNEL);