| Message ID | 20170112142132.14552-1-weiyj.lk@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
> -----Original Message----- > From: Wei Yongjun [mailto:weiyj.lk@gmail.com] > Sent: Thursday, January 12, 2017 7:52 PM > To: Subbu Seetharaman; Ketan Mukadam; Jitendra Bhivare; James E.J. > Bottomley; Martin K. Petersen > Cc: Wei Yongjun; linux-scsi@vger.kernel.org > Subject: [PATCH -next] scsi: be2iscsi: Use GFP_ATOMIC under spin lock > > From: Wei Yongjun <weiyongjun1@huawei.com> > > A spin lock is taken here so we should use GFP_ATOMIC. > > Fixes: 987132167f4b ("scsi: be2iscsi: Fix for crash in beiscsi_eh_device_reset") > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/scsi/be2iscsi/be_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c > index 6372613..c9b9daa 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -294,7 +294,7 @@ static int beiscsi_eh_device_reset(struct scsi_cmnd > *sc) > beiscsi_conn = conn->dd_data; > phba = beiscsi_conn->phba; > > - inv_tbl = kzalloc(sizeof(*inv_tbl), GFP_KERNEL); > + inv_tbl = kzalloc(sizeof(*inv_tbl), GFP_ATOMIC); > if (!inv_tbl) { > spin_unlock_bh(&session->frwd_lock); > beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_EH, Reviewed-by: Jitendra Bhivare <jitendra.bhivare@broadcom.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Wei" == Wei Yongjun <weiyj.lk@gmail.com> writes:
Wei> From: Wei Yongjun <weiyongjun1@huawei.com> A spin lock is taken
Wei> here so we should use GFP_ATOMIC.
Applied to 4.11/scsi-queue.
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 6372613..c9b9daa 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -294,7 +294,7 @@ static int beiscsi_eh_device_reset(struct scsi_cmnd *sc) beiscsi_conn = conn->dd_data; phba = beiscsi_conn->phba; - inv_tbl = kzalloc(sizeof(*inv_tbl), GFP_KERNEL); + inv_tbl = kzalloc(sizeof(*inv_tbl), GFP_ATOMIC); if (!inv_tbl) { spin_unlock_bh(&session->frwd_lock); beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_EH,