| Message ID | 1484311234-21978-2-git-send-email-ravibabu@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Ravi Babu <ravibabu@ti.com> [170113 04:41]: > The SPL size for DRA74x platform has increased and > is now more than 64KB. Increase QSPI SPL partition > size to 256KB for DRA74x EVM. > > QSPI partition numbering changes because of this. And this will break the existing partitions potentially.. See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table". It's best to have these left empty or as they originally were and let u-boot configure the partitions. Regards, Tony > Signed-off-by: Ravi Babu <ravibabu@ti.com> > Signed-off-by: Sekhar Nori <nsekhar@ti.com> > --- > arch/arm/boot/dts/dra7-evm.dts | 24 ++++++------------------ > 1 file changed, 6 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts > index 132f2be..2784241 100644 > --- a/arch/arm/boot/dts/dra7-evm.dts > +++ b/arch/arm/boot/dts/dra7-evm.dts > @@ -681,41 +681,29 @@ > */ > partition@0 { > label = "QSPI.SPL"; > - reg = <0x00000000 0x000010000>; > + reg = <0x00000000 0x000040000>; > }; > partition@1 { > - label = "QSPI.SPL.backup1"; > - reg = <0x00010000 0x00010000>; > - }; > - partition@2 { > - label = "QSPI.SPL.backup2"; > - reg = <0x00020000 0x00010000>; > - }; > - partition@3 { > - label = "QSPI.SPL.backup3"; > - reg = <0x00030000 0x00010000>; > - }; > - partition@4 { > label = "QSPI.u-boot"; > reg = <0x00040000 0x00100000>; > }; > - partition@5 { > + partition@2 { > label = "QSPI.u-boot-spl-os"; > reg = <0x00140000 0x00080000>; > }; > - partition@6 { > + partition@3 { > label = "QSPI.u-boot-env"; > reg = <0x001c0000 0x00010000>; > }; > - partition@7 { > + partition@4 { > label = "QSPI.u-boot-env.backup1"; > reg = <0x001d0000 0x0010000>; > }; > - partition@8 { > + partition@5 { > label = "QSPI.kernel"; > reg = <0x001e0000 0x0800000>; > }; > - partition@9 { > + partition@6 { > label = "QSPI.file-system"; > reg = <0x009e0000 0x01620000>; > }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tony >* Ravi Babu <ravibabu@ti.com> [170113 04:41]: >> The SPL size for DRA74x platform has increased and is now more than >> 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM. >> >> QSPI partition numbering changes because of this. >And this will break the existing partitions potentially.. >See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table". >It's best to have these left empty or as they originally were and let u-boot configure the partitions. Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform. >> Signed-off-by: Ravi Babu <ravibabu@ti.com> >> Signed-off-by: Sekhar Nori <nsekhar@ti.com> >> --- >> arch/arm/boot/dts/dra7-evm.dts | 24 ++++++------------------ >> 1 file changed, 6 insertions(+), 18 deletions(-) >> >> diff --git a/arch/arm/boot/dts/dra7-evm.dts >> b/arch/arm/boot/dts/dra7-evm.dts index 132f2be..2784241 100644 >> --- a/arch/arm/boot/dts/dra7-evm.dts >> +++ b/arch/arm/boot/dts/dra7-evm.dts >> @@ -681,41 +681,29 @@ >> */ >> partition@0 { >> label = "QSPI.SPL"; >> - reg = <0x00000000 0x000010000>; >> + reg = <0x00000000 0x000040000>; >> }; >> partition@1 { >> - label = "QSPI.SPL.backup1"; >> - reg = <0x00010000 0x00010000>; >> - }; >> - partition@2 { >> - label = "QSPI.SPL.backup2"; >> - reg = <0x00020000 0x00010000>; >> - }; >> - partition@3 { >> - label = "QSPI.SPL.backup3"; >> - reg = <0x00030000 0x00010000>; >> - }; >> - partition@4 { >> label = "QSPI.u-boot"; >> reg = <0x00040000 0x00100000>; >> }; >> - partition@5 { >> + partition@2 { >> label = "QSPI.u-boot-spl-os"; >> reg = <0x00140000 0x00080000>; >> }; >> - partition@6 { >> + partition@3 { >> label = "QSPI.u-boot-env"; >> reg = <0x001c0000 0x00010000>; >> }; >> - partition@7 { >> + partition@4 { >> label = "QSPI.u-boot-env.backup1"; >> reg = <0x001d0000 0x0010000>; >> }; >> - partition@8 { >> + partition@5 { >> label = "QSPI.kernel"; >> reg = <0x001e0000 0x0800000>; >> }; >> - partition@9 { >> + partition@6 { >> label = "QSPI.file-system"; >> reg = <0x009e0000 0x01620000>; >> }; >> -- Regards Ravi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* B, Ravi <ravibabu@ti.com> [170117 00:15]: > Hi Tony > > >* Ravi Babu <ravibabu@ti.com> [170113 04:41]: > >> The SPL size for DRA74x platform has increased and is now more than > >> 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM. > >> > >> QSPI partition numbering changes because of this. > > >And this will break the existing partitions potentially.. > >See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table". > > >It's best to have these left empty or as they originally were and let u-boot configure the partitions. > > Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. > Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform. What about the renumbering of partitions in your patch? Probably just best to make the partition information empty in the kernel as discussed. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tony, On Wednesday 18 January 2017 04:57 AM, Tony Lindgren wrote: > * B, Ravi <ravibabu@ti.com> [170117 00:15]: >> Hi Tony >> >>> * Ravi Babu <ravibabu@ti.com> [170113 04:41]: >>>> The SPL size for DRA74x platform has increased and is now more than >>>> 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM. >>>> >>>> QSPI partition numbering changes because of this. >> >>> And this will break the existing partitions potentially.. >>> See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table". >> >>> It's best to have these left empty or as they originally were and let u-boot configure the partitions. >> >> Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. >> Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform. > > What about the renumbering of partitions in your patch? Thats true, partitions will get renumbered. But mtd numbering can change depending on probe order of devices anyway. So usespace which uses hardcoded mtd partition numbers is pretty fragile already, I guess. > > Probably just best to make the partition information empty in the > kernel as discussed. Given that existing dtbs already have the partition information, wont this be treated as a regression for someone upgrading to new kernel? Going forward, is the preference that new boards shall not have partition information in DT? Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Sekhar Nori <nsekhar@ti.com> [170118 03:59]: > Hi Tony, > > On Wednesday 18 January 2017 04:57 AM, Tony Lindgren wrote: > > * B, Ravi <ravibabu@ti.com> [170117 00:15]: > >> Hi Tony > >> > >>> * Ravi Babu <ravibabu@ti.com> [170113 04:41]: > >>>> The SPL size for DRA74x platform has increased and is now more than > >>>> 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM. > >>>> > >>>> QSPI partition numbering changes because of this. > >> > >>> And this will break the existing partitions potentially.. > >>> See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table". > >> > >>> It's best to have these left empty or as they originally were and let u-boot configure the partitions. > >> > >> Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. > >> Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform. > > > > What about the renumbering of partitions in your patch? > > Thats true, partitions will get renumbered. But mtd numbering can change > depending on probe order of devices anyway. So usespace which uses > hardcoded mtd partition numbers is pretty fragile already, I guess. > > > > > Probably just best to make the partition information empty in the > > kernel as discussed. > > Given that existing dtbs already have the partition information, wont > this be treated as a regression for someone upgrading to new kernel? Well these "flag day" type changes are not acceptable because they are impossible to coordinate. You can't assume people update their bootloader on regular basis, or update both bootloader and kernel to some specific versions. > Going forward, is the preference that new boards shall not have > partition information in DT? Yes or else it will have to stay as it was originally set because of these issues. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index 132f2be..2784241 100644 --- a/arch/arm/boot/dts/dra7-evm.dts +++ b/arch/arm/boot/dts/dra7-evm.dts @@ -681,41 +681,29 @@ */ partition@0 { label = "QSPI.SPL"; - reg = <0x00000000 0x000010000>; + reg = <0x00000000 0x000040000>; }; partition@1 { - label = "QSPI.SPL.backup1"; - reg = <0x00010000 0x00010000>; - }; - partition@2 { - label = "QSPI.SPL.backup2"; - reg = <0x00020000 0x00010000>; - }; - partition@3 { - label = "QSPI.SPL.backup3"; - reg = <0x00030000 0x00010000>; - }; - partition@4 { label = "QSPI.u-boot"; reg = <0x00040000 0x00100000>; }; - partition@5 { + partition@2 { label = "QSPI.u-boot-spl-os"; reg = <0x00140000 0x00080000>; }; - partition@6 { + partition@3 { label = "QSPI.u-boot-env"; reg = <0x001c0000 0x00010000>; }; - partition@7 { + partition@4 { label = "QSPI.u-boot-env.backup1"; reg = <0x001d0000 0x0010000>; }; - partition@8 { + partition@5 { label = "QSPI.kernel"; reg = <0x001e0000 0x0800000>; }; - partition@9 { + partition@6 { label = "QSPI.file-system"; reg = <0x009e0000 0x01620000>; };