diff mbox

ARM: Exynos4415: remove dead build rule

Message ID 20170119091153.8439-1-valentinrothberg@gmail.com (mailing list archive)
State Rejected
Headers show

Commit Message

Valentin Rothberg Jan. 19, 2017, 9:11 a.m. UTC
Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
we are safe to remove the last reference in the Makefile.

Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
---
Detected by using ./scripts/checkkconfigsymbols.py

 drivers/clk/samsung/Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Chanwoo Choi Jan. 19, 2017, 9:14 a.m. UTC | #1
Hi,

On 2017년 01월 19일 18:11, Valentin Rothberg wrote:
> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
> we are safe to remove the last reference in the Makefile.
> 
> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
> ---
> Detected by using ./scripts/checkkconfigsymbols.py
> 
>  drivers/clk/samsung/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index 57f4dc6dc447..7afc21dc374e 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -5,7 +5,6 @@
>  obj-$(CONFIG_COMMON_CLK)	+= clk.o clk-pll.o clk-cpu.o
>  obj-$(CONFIG_SOC_EXYNOS3250)	+= clk-exynos3250.o
>  obj-$(CONFIG_ARCH_EXYNOS4)	+= clk-exynos4.o
> -obj-$(CONFIG_SOC_EXYNOS4415)	+= clk-exynos4415.o
>  obj-$(CONFIG_SOC_EXYNOS5250)	+= clk-exynos5250.o
>  obj-$(CONFIG_SOC_EXYNOS5260)	+= clk-exynos5260.o
>  obj-$(CONFIG_SOC_EXYNOS5410)	+= clk-exynos5410.o
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Krzysztof Kozlowski Jan. 19, 2017, 9:18 a.m. UTC | #2
On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
> we are safe to remove the last reference in the Makefile.
>
> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
> ---
> Detected by using ./scripts/checkkconfigsymbols.py
>
>  drivers/clk/samsung/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index 57f4dc6dc447..7afc21dc374e 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -5,7 +5,6 @@
>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o

It is already removed. Which tree are you using?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski Jan. 19, 2017, 9:20 a.m. UTC | #3
On Thu, Jan 19, 2017 at 11:18 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
> <valentinrothberg@gmail.com> wrote:
>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>> we are safe to remove the last reference in the Makefile.
>>
>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>> ---
>> Detected by using ./scripts/checkkconfigsymbols.py
>>
>>  drivers/clk/samsung/Makefile | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
>> index 57f4dc6dc447..7afc21dc374e 100644
>> --- a/drivers/clk/samsung/Makefile
>> +++ b/drivers/clk/samsung/Makefile
>> @@ -5,7 +5,6 @@
>>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
>> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o
>
> It is already removed. Which tree are you using?

BTW, please fix your own mail/name etc in from and Signed-off-by. One
of them is wrong and bounces.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Valentin Rothberg Jan. 19, 2017, 9:25 a.m. UTC | #4
Hi Krzysztof,

On 19/01/2017 10:20, Krzysztof Kozlowski wrote:
> On Thu, Jan 19, 2017 at 11:18 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
>> <valentinrothberg@gmail.com> wrote:
>>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>>> we are safe to remove the last reference in the Makefile.
>>>
>>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>>> ---
>>> Detected by using ./scripts/checkkconfigsymbols.py
>>>
>>>  drivers/clk/samsung/Makefile | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
>>> index 57f4dc6dc447..7afc21dc374e 100644
>>> --- a/drivers/clk/samsung/Makefile
>>> +++ b/drivers/clk/samsung/Makefile
>>> @@ -5,7 +5,6 @@
>>>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>>>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>>>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
>>> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o
>>
>> It is already removed. Which tree are you using?

I'm on today's linux-next.  Please excuse the noise, I did not see your
other patch on lkml.

> BTW, please fix your own mail/name etc in from and Signed-off-by. One
> of them is wrong and bounces.

Thanks for the hint.

Kind regards,
 Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski Jan. 19, 2017, 9:28 a.m. UTC | #5
On Thu, Jan 19, 2017 at 11:25 AM, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Hi Krzysztof,
>
> On 19/01/2017 10:20, Krzysztof Kozlowski wrote:
>> On Thu, Jan 19, 2017 at 11:18 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
>>> <valentinrothberg@gmail.com> wrote:
>>>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>>>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>>>> we are safe to remove the last reference in the Makefile.
>>>>
>>>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>>>> ---
>>>> Detected by using ./scripts/checkkconfigsymbols.py
>>>>
>>>>  drivers/clk/samsung/Makefile | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
>>>> index 57f4dc6dc447..7afc21dc374e 100644
>>>> --- a/drivers/clk/samsung/Makefile
>>>> +++ b/drivers/clk/samsung/Makefile
>>>> @@ -5,7 +5,6 @@
>>>>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>>>>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>>>>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
>>>> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o
>>>
>>> It is already removed. Which tree are you using?
>
> I'm on today's linux-next.  Please excuse the noise, I did not see your
> other patch on lkml.

Sylwester,

Is your tree included in linux-next? I see my patch here:
https://git.linuxtv.org/snawrocki/samsung.git/log/?h=for-v4.11/clk/next
so maybe something in linux-next is missing?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chanwoo Choi Jan. 19, 2017, 9:31 a.m. UTC | #6
Dear all,

On 2017년 01월 19일 18:14, Chanwoo Choi wrote:
> Hi,
> 
> On 2017년 01월 19일 18:11, Valentin Rothberg wrote:
>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>> we are safe to remove the last reference in the Makefile.
>>
>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>> ---
>> Detected by using ./scripts/checkkconfigsymbols.py
>>
>>  drivers/clk/samsung/Makefile | 1 -
>>  1 file changed, 1 deletion(-)

Please ignore this reply. Krzysztof's patch[1] already
removed the entry of clk-exynos4415.c.
[1] https://www.spinics.net/lists/arm-kernel/msg554369.html
On 01/19/2017 10:28 AM, Krzysztof Kozlowski wrote:
> Is your tree included in linux-next? I see my patch here:
> https://git.linuxtv.org/snawrocki/samsung.git/log/?h=for-v4.11/clk/next
> so maybe something in linux-next is missing?

No, it's not included. I will be sending a pull request to the clk
maintainers this week so the patches should end up in linux-next soon.
Krzysztof Kozlowski Jan. 19, 2017, 1:56 p.m. UTC | #8
On Thu, Jan 19, 2017 at 11:44 AM, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
> On 01/19/2017 10:28 AM, Krzysztof Kozlowski wrote:
>> Is your tree included in linux-next? I see my patch here:
>> https://git.linuxtv.org/snawrocki/samsung.git/log/?h=for-v4.11/clk/next
>> so maybe something in linux-next is missing?
>
> No, it's not included. I will be sending a pull request to the clk
> maintainers this week so the patches should end up in linux-next soon.

... so how about including it? I do not see any reasons not to be part
of linux-next. You are picking patches for Samsung clk and pinctrl
(and media drivers? and maybe more?) so everything you pick should be
in next as fast as possible.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-clk" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
index 57f4dc6dc447..7afc21dc374e 100644
--- a/drivers/clk/samsung/Makefile
+++ b/drivers/clk/samsung/Makefile
@@ -5,7 +5,6 @@ 
 obj-$(CONFIG_COMMON_CLK)	+= clk.o clk-pll.o clk-cpu.o
 obj-$(CONFIG_SOC_EXYNOS3250)	+= clk-exynos3250.o
 obj-$(CONFIG_ARCH_EXYNOS4)	+= clk-exynos4.o
-obj-$(CONFIG_SOC_EXYNOS4415)	+= clk-exynos4415.o
 obj-$(CONFIG_SOC_EXYNOS5250)	+= clk-exynos5250.o
 obj-$(CONFIG_SOC_EXYNOS5260)	+= clk-exynos5260.o
 obj-$(CONFIG_SOC_EXYNOS5410)	+= clk-exynos5410.o