| Message ID | 20170125233646.2243-5-bart.vanassche@sandisk.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 01/26/2017 12:36 AM, Bart Van Assche wrote: > Fix the spelling of this word in a function name, messages and > source code comments. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Nicholas A. Bellinger <nab@linux-iscsi.org> > --- > drivers/target/iscsi/iscsi_target.c | 4 ++-- > drivers/target/iscsi/iscsi_target_erl2.c | 6 +++--- > drivers/target/iscsi/iscsi_target_erl2.h | 2 +- > drivers/target/iscsi/iscsi_target_tmr.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c > index 3b770fddcb3b..e11f8d0f1fa3 100644 > --- a/drivers/target/iscsi/iscsi_target.c > +++ b/drivers/target/iscsi/iscsi_target.c > @@ -4136,7 +4136,7 @@ int iscsit_close_connection( > /* > * During Connection recovery drop unacknowledged out of order > * commands for this connection, and prepare the other commands > - * for realligence. > + * for reallegiance. > * > * During normal operation clear the out of order commands (but > * do not free the struct iscsi_ooo_cmdsn's) and release all > @@ -4144,7 +4144,7 @@ int iscsit_close_connection( > */ > if (atomic_read(&conn->connection_recovery)) { > iscsit_discard_unacknowledged_ooo_cmdsns_for_conn(conn); > - iscsit_prepare_cmds_for_realligance(conn); > + iscsit_prepare_cmds_for_reallegiance(conn); > } else { > iscsit_clear_ooo_cmdsns_for_conn(conn); > iscsit_release_commands_from_conn(conn); > diff --git a/drivers/target/iscsi/iscsi_target_erl2.c b/drivers/target/iscsi/iscsi_target_erl2.c > index faf9ae014b30..8df9c90f3db3 100644 > --- a/drivers/target/iscsi/iscsi_target_erl2.c > +++ b/drivers/target/iscsi/iscsi_target_erl2.c > @@ -312,7 +312,7 @@ int iscsit_discard_unacknowledged_ooo_cmdsns_for_conn(struct iscsi_conn *conn) > return 0; > } > > -int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn) > +int iscsit_prepare_cmds_for_reallegiance(struct iscsi_conn *conn) > { > u32 cmd_count = 0; > struct iscsi_cmd *cmd, *cmd_tmp; > @@ -347,7 +347,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn) > > if ((cmd->iscsi_opcode != ISCSI_OP_SCSI_CMD) && > (cmd->iscsi_opcode != ISCSI_OP_NOOP_OUT)) { > - pr_debug("Not performing realligence on" > + pr_debug("Not performing reallegiance on" > " Opcode: 0x%02x, ITT: 0x%08x, CmdSN: 0x%08x," > " CID: %hu\n", cmd->iscsi_opcode, > cmd->init_task_tag, cmd->cmd_sn, conn->cid); > @@ -382,7 +382,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn) > cmd_count++; > pr_debug("Preparing Opcode: 0x%02x, ITT: 0x%08x," > " CmdSN: 0x%08x, StatSN: 0x%08x, CID: %hu for" > - " realligence.\n", cmd->iscsi_opcode, > + " reallegiance.\n", cmd->iscsi_opcode, > cmd->init_task_tag, cmd->cmd_sn, cmd->stat_sn, > conn->cid); > > diff --git a/drivers/target/iscsi/iscsi_target_erl2.h b/drivers/target/iscsi/iscsi_target_erl2.h > index 7965f1e86506..634d01e13652 100644 > --- a/drivers/target/iscsi/iscsi_target_erl2.h > +++ b/drivers/target/iscsi/iscsi_target_erl2.h > @@ -19,7 +19,7 @@ extern int iscsit_remove_cmd_from_connection_recovery(struct iscsi_cmd *, > struct iscsi_session *); > extern void iscsit_discard_cr_cmds_by_expstatsn(struct iscsi_conn_recovery *, u32); > extern int iscsit_discard_unacknowledged_ooo_cmdsns_for_conn(struct iscsi_conn *); > -extern int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *); > +extern int iscsit_prepare_cmds_for_reallegiance(struct iscsi_conn *); > extern int iscsit_connection_recovery_transport_reset(struct iscsi_conn *); > > #endif /*** ISCSI_TARGET_ERL2_H ***/ > diff --git a/drivers/target/iscsi/iscsi_target_tmr.c b/drivers/target/iscsi/iscsi_target_tmr.c > index 3d637055c36f..cb231c907d51 100644 > --- a/drivers/target/iscsi/iscsi_target_tmr.c > +++ b/drivers/target/iscsi/iscsi_target_tmr.c > @@ -440,14 +440,14 @@ static int iscsit_task_reassign_complete( > break; > default: > pr_err("Illegal iSCSI Opcode 0x%02x during" > - " command realligence\n", cmd->iscsi_opcode); > + " command reallegiance\n", cmd->iscsi_opcode); > return -1; > } > > if (ret != 0) > return ret; > > - pr_debug("Completed connection realligence for Opcode: 0x%02x," > + pr_debug("Completed connection reallegiance for Opcode: 0x%02x," > " ITT: 0x%08x to CID: %hu.\n", cmd->iscsi_opcode, > cmd->init_task_tag, conn->cid); > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 3b770fddcb3b..e11f8d0f1fa3 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -4136,7 +4136,7 @@ int iscsit_close_connection( /* * During Connection recovery drop unacknowledged out of order * commands for this connection, and prepare the other commands - * for realligence. + * for reallegiance. * * During normal operation clear the out of order commands (but * do not free the struct iscsi_ooo_cmdsn's) and release all @@ -4144,7 +4144,7 @@ int iscsit_close_connection( */ if (atomic_read(&conn->connection_recovery)) { iscsit_discard_unacknowledged_ooo_cmdsns_for_conn(conn); - iscsit_prepare_cmds_for_realligance(conn); + iscsit_prepare_cmds_for_reallegiance(conn); } else { iscsit_clear_ooo_cmdsns_for_conn(conn); iscsit_release_commands_from_conn(conn); diff --git a/drivers/target/iscsi/iscsi_target_erl2.c b/drivers/target/iscsi/iscsi_target_erl2.c index faf9ae014b30..8df9c90f3db3 100644 --- a/drivers/target/iscsi/iscsi_target_erl2.c +++ b/drivers/target/iscsi/iscsi_target_erl2.c @@ -312,7 +312,7 @@ int iscsit_discard_unacknowledged_ooo_cmdsns_for_conn(struct iscsi_conn *conn) return 0; } -int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn) +int iscsit_prepare_cmds_for_reallegiance(struct iscsi_conn *conn) { u32 cmd_count = 0; struct iscsi_cmd *cmd, *cmd_tmp; @@ -347,7 +347,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn) if ((cmd->iscsi_opcode != ISCSI_OP_SCSI_CMD) && (cmd->iscsi_opcode != ISCSI_OP_NOOP_OUT)) { - pr_debug("Not performing realligence on" + pr_debug("Not performing reallegiance on" " Opcode: 0x%02x, ITT: 0x%08x, CmdSN: 0x%08x," " CID: %hu\n", cmd->iscsi_opcode, cmd->init_task_tag, cmd->cmd_sn, conn->cid); @@ -382,7 +382,7 @@ int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *conn) cmd_count++; pr_debug("Preparing Opcode: 0x%02x, ITT: 0x%08x," " CmdSN: 0x%08x, StatSN: 0x%08x, CID: %hu for" - " realligence.\n", cmd->iscsi_opcode, + " reallegiance.\n", cmd->iscsi_opcode, cmd->init_task_tag, cmd->cmd_sn, cmd->stat_sn, conn->cid); diff --git a/drivers/target/iscsi/iscsi_target_erl2.h b/drivers/target/iscsi/iscsi_target_erl2.h index 7965f1e86506..634d01e13652 100644 --- a/drivers/target/iscsi/iscsi_target_erl2.h +++ b/drivers/target/iscsi/iscsi_target_erl2.h @@ -19,7 +19,7 @@ extern int iscsit_remove_cmd_from_connection_recovery(struct iscsi_cmd *, struct iscsi_session *); extern void iscsit_discard_cr_cmds_by_expstatsn(struct iscsi_conn_recovery *, u32); extern int iscsit_discard_unacknowledged_ooo_cmdsns_for_conn(struct iscsi_conn *); -extern int iscsit_prepare_cmds_for_realligance(struct iscsi_conn *); +extern int iscsit_prepare_cmds_for_reallegiance(struct iscsi_conn *); extern int iscsit_connection_recovery_transport_reset(struct iscsi_conn *); #endif /*** ISCSI_TARGET_ERL2_H ***/ diff --git a/drivers/target/iscsi/iscsi_target_tmr.c b/drivers/target/iscsi/iscsi_target_tmr.c index 3d637055c36f..cb231c907d51 100644 --- a/drivers/target/iscsi/iscsi_target_tmr.c +++ b/drivers/target/iscsi/iscsi_target_tmr.c @@ -440,14 +440,14 @@ static int iscsit_task_reassign_complete( break; default: pr_err("Illegal iSCSI Opcode 0x%02x during" - " command realligence\n", cmd->iscsi_opcode); + " command reallegiance\n", cmd->iscsi_opcode); return -1; } if (ret != 0) return ret; - pr_debug("Completed connection realligence for Opcode: 0x%02x," + pr_debug("Completed connection reallegiance for Opcode: 0x%02x," " ITT: 0x%08x to CID: %hu.\n", cmd->iscsi_opcode, cmd->init_task_tag, conn->cid);
Fix the spelling of this word in a function name, messages and source code comments. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Nicholas A. Bellinger <nab@linux-iscsi.org> --- drivers/target/iscsi/iscsi_target.c | 4 ++-- drivers/target/iscsi/iscsi_target_erl2.c | 6 +++--- drivers/target/iscsi/iscsi_target_erl2.h | 2 +- drivers/target/iscsi/iscsi_target_tmr.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)