| Message ID | 20170125233646.2243-8-bart.vanassche@sandisk.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 01/26/2017 12:36 AM, Bart Van Assche wrote: > Member tmr_lun of se_tmr_req is set but not used. Hence remove it. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Himanshu Madhani <himanshu.madhani@cavium.com> > Cc: Giridhar Malavali <giridhar.malavali@cavium.com> > --- > drivers/target/target_core_device.c | 1 - > include/target/target_core_base.h | 1 - > 2 files changed, 2 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 25, 2017 at 03:36:19PM -0800, Bart Van Assche wrote: > Member tmr_lun of se_tmr_req is set but not used. Hence remove it. Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 1/25/17, 3:36 PM, "Bart Van Assche" <bart.vanassche@sandisk.com> wrote: >Member tmr_lun of se_tmr_req is set but not used. Hence remove it. > >Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> >Cc: Christoph Hellwig <hch@lst.de> >Cc: Himanshu Madhani <himanshu.madhani@cavium.com> >Cc: Giridhar Malavali <giridhar.malavali@cavium.com> >--- > drivers/target/target_core_device.c | 1 - > include/target/target_core_base.h | 1 - > 2 files changed, 2 deletions(-) > >diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c >index 1ebd13ef7bd3..9d55e9fe7857 100644 >--- a/drivers/target/target_core_device.c >+++ b/drivers/target/target_core_device.c >@@ -163,7 +163,6 @@ int transport_lookup_tmr_lun(struct se_cmd *se_cmd, u64 unpacked_lun) > rcu_read_lock(); > deve = target_nacl_find_deve(nacl, unpacked_lun); > if (deve) { >- se_tmr->tmr_lun = rcu_dereference(deve->se_lun); > se_cmd->se_lun = rcu_dereference(deve->se_lun); > se_lun = rcu_dereference(deve->se_lun); > se_cmd->pr_res_key = deve->pr_res_key; >diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h >index 43edf82e54ff..fc52207e8076 100644 >--- a/include/target/target_core_base.h >+++ b/include/target/target_core_base.h >@@ -397,7 +397,6 @@ struct se_tmr_req { > void *fabric_tmr_ptr; > struct se_cmd *task_cmd; > struct se_device *tmr_dev; >- struct se_lun *tmr_lun; > struct list_head tmr_list; > }; > >-- >2.11.0 Looks good. Reviewed-By: Himanshu Madhani <himanshu.madhani@cavium.com>
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 1ebd13ef7bd3..9d55e9fe7857 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -163,7 +163,6 @@ int transport_lookup_tmr_lun(struct se_cmd *se_cmd, u64 unpacked_lun) rcu_read_lock(); deve = target_nacl_find_deve(nacl, unpacked_lun); if (deve) { - se_tmr->tmr_lun = rcu_dereference(deve->se_lun); se_cmd->se_lun = rcu_dereference(deve->se_lun); se_lun = rcu_dereference(deve->se_lun); se_cmd->pr_res_key = deve->pr_res_key; diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 43edf82e54ff..fc52207e8076 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h @@ -397,7 +397,6 @@ struct se_tmr_req { void *fabric_tmr_ptr; struct se_cmd *task_cmd; struct se_device *tmr_dev; - struct se_lun *tmr_lun; struct list_head tmr_list; };
Member tmr_lun of se_tmr_req is set but not used. Hence remove it. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Himanshu Madhani <himanshu.madhani@cavium.com> Cc: Giridhar Malavali <giridhar.malavali@cavium.com> --- drivers/target/target_core_device.c | 1 - include/target/target_core_base.h | 1 - 2 files changed, 2 deletions(-)