| Message ID | 1485773289-19844-1-git-send-email-augustocaringi@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
On Mon, 30 Jan 2017 10:47:36 +0000 Augusto Mecking Caringi <augustocaringi@gmail.com> wrote: > In poll_pkg_cstate() function, the variables jiffies_last and > jiffies_now are set but never used. > > This has been detected by building the driver with W=1: > > drivers/thermal/intel_powerclamp.c: In function ‘poll_pkg_cstate’: > drivers/thermal/intel_powerclamp.c:464:23: warning: variable > ‘jiffies_last’ set but not used [-Wunused-but-set-variable] > static unsigned long jiffies_last; > ^ > Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com> Thanks, > Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com> > --- > drivers/thermal/intel_powerclamp.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/thermal/intel_powerclamp.c > b/drivers/thermal/intel_powerclamp.c index df64692..a47103a 100644 > --- a/drivers/thermal/intel_powerclamp.c > +++ b/drivers/thermal/intel_powerclamp.c > @@ -461,16 +461,13 @@ static void poll_pkg_cstate(struct work_struct > *dummy) { > static u64 msr_last; > static u64 tsc_last; > - static unsigned long jiffies_last; > > u64 msr_now; > - unsigned long jiffies_now; > u64 tsc_now; > u64 val64; > > msr_now = pkg_state_counter(); > tsc_now = rdtsc(); > - jiffies_now = jiffies; > > /* calculate pkg cstate vs tsc ratio */ > if (!msr_last || !tsc_last) > @@ -485,7 +482,6 @@ static void poll_pkg_cstate(struct work_struct > *dummy) > /* update record */ > msr_last = msr_now; > - jiffies_last = jiffies_now; > tsc_last = tsc_now; > > if (true == clamping) [Jacob Pan] -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c index df64692..a47103a 100644 --- a/drivers/thermal/intel_powerclamp.c +++ b/drivers/thermal/intel_powerclamp.c @@ -461,16 +461,13 @@ static void poll_pkg_cstate(struct work_struct *dummy) { static u64 msr_last; static u64 tsc_last; - static unsigned long jiffies_last; u64 msr_now; - unsigned long jiffies_now; u64 tsc_now; u64 val64; msr_now = pkg_state_counter(); tsc_now = rdtsc(); - jiffies_now = jiffies; /* calculate pkg cstate vs tsc ratio */ if (!msr_last || !tsc_last) @@ -485,7 +482,6 @@ static void poll_pkg_cstate(struct work_struct *dummy) /* update record */ msr_last = msr_now; - jiffies_last = jiffies_now; tsc_last = tsc_now; if (true == clamping)
In poll_pkg_cstate() function, the variables jiffies_last and jiffies_now are set but never used. This has been detected by building the driver with W=1: drivers/thermal/intel_powerclamp.c: In function ‘poll_pkg_cstate’: drivers/thermal/intel_powerclamp.c:464:23: warning: variable ‘jiffies_last’ set but not used [-Wunused-but-set-variable] static unsigned long jiffies_last; ^ Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com> --- drivers/thermal/intel_powerclamp.c | 4 ---- 1 file changed, 4 deletions(-)