| Message ID | 20170126142554.8812-1-jprvita@endlessm.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Andy Shevchenko |
| Headers | show |
On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote: > Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com> > --- > drivers/platform/x86/asus-wireless.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c > index 9f31bc1a47d0..c9b5ac152cf1 100644 > --- a/drivers/platform/x86/asus-wireless.c > +++ b/drivers/platform/x86/asus-wireless.c > @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work) > } > > static void led_state_set(struct led_classdev *led, > - enum led_brightness value) > + enum led_brightness value) I would see benefit if it would be one line. > { > struct asus_wireless_data *data;
On 27 January 2017 at 10:28, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, Jan 26, 2017 at 4:25 PM, João Paulo Rechi Vita > <jprvita@gmail.com> wrote: >> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com> >> --- >> drivers/platform/x86/asus-wireless.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c >> index 9f31bc1a47d0..c9b5ac152cf1 100644 >> --- a/drivers/platform/x86/asus-wireless.c >> +++ b/drivers/platform/x86/asus-wireless.c >> @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work) >> } >> >> static void led_state_set(struct led_classdev *led, >> - enum led_brightness value) >> + enum led_brightness value) > > I would see benefit if it would be one line. > Yes, I fixed this in a hurry and missed it actually fits in one line. Thanks for catching it! I'll reply with an updated patch. -- João Paulo Rechi Vita http://about.me/jprvita
diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c index 9f31bc1a47d0..c9b5ac152cf1 100644 --- a/drivers/platform/x86/asus-wireless.c +++ b/drivers/platform/x86/asus-wireless.c @@ -77,7 +77,7 @@ static void led_state_update(struct work_struct *work) } static void led_state_set(struct led_classdev *led, - enum led_brightness value) + enum led_brightness value) { struct asus_wireless_data *data;
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com> --- drivers/platform/x86/asus-wireless.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)