| Message ID | 20170131100552.27949-2-mylene.josserand@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: > Add a new compatible for sun4i-i2s driver to handle some > SoCs that have a reset line that must be asserted/deasserted. > > This new compatible, "allwinner,sun6i-a31-i2s", requires the > property "resets" which should be a phandle to the reset line. > Except these differences, the compatible is identical to previous one > which will not handle a reset line. > > Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks, Maxime
On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: > Add a new compatible for sun4i-i2s driver to handle some > SoCs that have a reset line that must be asserted/deasserted. This doesn't apply against current code, please check and resend.
Hello, On 31/01/2017 22:17, Mark Brown wrote: > On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: >> Add a new compatible for sun4i-i2s driver to handle some >> SoCs that have a reset line that must be asserted/deasserted. > > This doesn't apply against current code, please check and resend. > I based my series on linux-next 20170131. Which one I should use? Thank you in advance, Best regards,
On Wed, Feb 01, 2017 at 08:44:56AM +0100, Mylene Josserand wrote: > On 31/01/2017 22:17, Mark Brown wrote: > > On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: > > > Add a new compatible for sun4i-i2s driver to handle some > > > SoCs that have a reset line that must be asserted/deasserted. > > This doesn't apply against current code, please check and resend. > I based my series on linux-next 20170131. Which one I should use? You should be submitting against my git tree (which should be what's in -next...). git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Hi, On 01/02/2017 12:59, Mark Brown wrote: > On Wed, Feb 01, 2017 at 08:44:56AM +0100, Mylene Josserand wrote: >> On 31/01/2017 22:17, Mark Brown wrote: >>> On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: >>>> Add a new compatible for sun4i-i2s driver to handle some >>>> SoCs that have a reset line that must be asserted/deasserted. > >>> This doesn't apply against current code, please check and resend. > >> I based my series on linux-next 20170131. Which one I should use? > > You should be submitting against my git tree (which should be what's in > -next...). > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > Okay, thank you! I will update my series according to your branch. Best regards,
On Tue, Jan 31, 2017 at 11:05:45AM +0100, Mylène Josserand wrote: > Add a new compatible for sun4i-i2s driver to handle some > SoCs that have a reset line that must be asserted/deasserted. > > This new compatible, "allwinner,sun6i-a31-i2s", requires the > property "resets" which should be a phandle to the reset line. > Except these differences, the compatible is identical to previous one > which will not handle a reset line. > > Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> > --- > Documentation/devicetree/bindings/sound/sun4i-i2s.txt | 5 +++++ > 1 file changed, 5 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt index 7a2c0945fd22..b71df552bc0c 100644 --- a/Documentation/devicetree/bindings/sound/sun4i-i2s.txt +++ b/Documentation/devicetree/bindings/sound/sun4i-i2s.txt @@ -7,6 +7,7 @@ Required properties: - compatible: should be one of the following: - "allwinner,sun4i-a10-i2s" + - "allwinner,sun6i-a31-i2s" - reg: physical base address of the controller and length of memory mapped region. - interrupts: should contain the I2S interrupt. @@ -19,6 +20,10 @@ Required properties: - "mod" : module clock for the I2S controller - #sound-dai-cells : Must be equal to 0 +Required properties for the following compatibles: + - "allwinner,sun6i-a31-i2s" +- resets: phandle to the reset line for this codec + Example: i2s0: i2s@01c22400 {
Add a new compatible for sun4i-i2s driver to handle some SoCs that have a reset line that must be asserted/deasserted. This new compatible, "allwinner,sun6i-a31-i2s", requires the property "resets" which should be a phandle to the reset line. Except these differences, the compatible is identical to previous one which will not handle a reset line. Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com> --- Documentation/devicetree/bindings/sound/sun4i-i2s.txt | 5 +++++ 1 file changed, 5 insertions(+)