diff mbox

asus-wireless: Fix identation

Message ID 20170201122707.14738-1-jprvita@endlessm.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

João Paulo Rechi Vita Feb. 1, 2017, 12:27 p.m. UTC 
Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
---
 drivers/platform/x86/asus-wireless.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Andy Shevchenko Feb. 4, 2017, 3:08 p.m. UTC | #1 
On Wed, Feb 1, 2017 at 2:27 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:

Do not leave empty commit message. Describe your changes here in a few words.

For the drivers/platform/x86 use a pattern in subject

platform/x86: asus-wireless: ...

> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
> ---
>  drivers/platform/x86/asus-wireless.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index 9f31bc1a47d0..a7ee18383146 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
>                              data->led_state);
>  }
>
> -static void led_state_set(struct led_classdev *led,
> -                                 enum led_brightness value)
> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
>  {
>         struct asus_wireless_data *data;
>
> --
> 2.11.0
>
Andy Shevchenko Feb. 4, 2017, 3:10 p.m. UTC | #2 
On Sat, Feb 4, 2017 at 5:08 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Feb 1, 2017 at 2:27 PM, João Paulo Rechi Vita <jprvita@gmail.com> wrote:
>
> Do not leave empty commit message. Describe your changes here in a few words.
>
> For the drivers/platform/x86 use a pattern in subject
>
> platform/x86: asus-wireless: ...

And one more, use versioning of your patches: PATCHv1, PATCHv2, ...

>
>> Signed-off-by: João Paulo Rechi Vita <jprvita@endlessm.com>
>> ---
>>  drivers/platform/x86/asus-wireless.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
>> index 9f31bc1a47d0..a7ee18383146 100644
>> --- a/drivers/platform/x86/asus-wireless.c
>> +++ b/drivers/platform/x86/asus-wireless.c
>> @@ -76,8 +76,7 @@ static void led_state_update(struct work_struct *work)
>>                              data->led_state);
>>  }
>>
>> -static void led_state_set(struct led_classdev *led,
>> -                                 enum led_brightness value)
>> +static void led_state_set(struct led_classdev *led, enum led_brightness value)
>>  {
>>         struct asus_wireless_data *data;
>>
>> --
>> 2.11.0
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
diff mbox

Patch

diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index 9f31bc1a47d0..a7ee18383146 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -76,8 +76,7 @@  static void led_state_update(struct work_struct *work)
 			     data->led_state);
 }
 
-static void led_state_set(struct led_classdev *led,
-				  enum led_brightness value)
+static void led_state_set(struct led_classdev *led, enum led_brightness value)
 {
 	struct asus_wireless_data *data;